From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 165CBA0C41; Tue, 11 May 2021 09:59:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F3ED40140; Tue, 11 May 2021 09:59:37 +0200 (CEST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mails.dpdk.org (Postfix) with ESMTP id 2A5A24003E; Tue, 11 May 2021 09:59:36 +0200 (CEST) Received: by mail-lf1-f41.google.com with SMTP id c3so27309887lfs.7; Tue, 11 May 2021 00:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9q+RJaPtgbS5WS9zRkaVSInB3NE+FYupVZA4kmlZDrk=; b=Z8R3538ap4x4yuPdkwFFC/d5Z9tCV9r5cq+OCETOxwKLxOumKXDs7TXp+l9dR07rji R6WBdrU5Rl1cyis43TNBv7jyE8hKkvB9JlDB1d+nMiVkh6+VRNKBfpZIcvbLwwINU4+h 9C3EU0pGiTxgnhs5lsvp6pkry0WEmARaJAJ0M3AnBzHd3AzhFBBprbtl35IgcfJTmJXr b0lCnL3GRtaCXrcAgeXf7WkVww9CDPbY9B1OSKeJaMtmm1Xu7PNvs6cH/Je+VIgWPWGX rHCvOMUlm9I3OVgC3PznfO4XJ7pRIHMfjOM2IPxNP8tgrMHF17xXj2wLcYaZab5jOCus 3CVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9q+RJaPtgbS5WS9zRkaVSInB3NE+FYupVZA4kmlZDrk=; b=GpywYIHEFF7iXUZf1xeoJzDNFIUn75gXspVmDlFG6BeGvaXfFWgx5uVssDi80z04y2 4y37O3tPiS8Nu9Zgtxo6p/6Fj31Jlk7KWx3YCvboLgk1//RvaHNKW9Jbub8sQ/hV7U5b XzNOAbl47zl8SD2BpjVTlbLRC+dAndGrZpG7MBd9BP3Ozg+70x90zlHP3LOo2087GGHa z3I2juYOmtHYZ9U46EkZuPINwn6MWKkcF+I2sK5QDjug+UpyCz6a58Iu5dhRPvMJjRni jd/z1iydO4gPaspeiA9q/j4m6xpuUJGUAatIFEp8EsB9lwPXHAmz98PsnnLbChC/Frqc bUfg== X-Gm-Message-State: AOAM532WSB/ZnFJfhphvzTN9qmvSNEGiwp+xeS7n2UFMA2Nr/7gdH2yn ACaxcQnhlhxT48jFEGM/vMI= X-Google-Smtp-Source: ABdhPJzhnlE91wzcOdHSMZdwtuPB0P8EBC5r+ZpcmohZY2Y1pG58lSlrRVk+X8OvyyvqC6FQ8aPG2Q== X-Received: by 2002:a05:6512:3193:: with SMTP id i19mr19846357lfe.70.1620719975681; Tue, 11 May 2021 00:59:35 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id c13sm2499943lfr.104.2021.05.11.00.59.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 00:59:35 -0700 (PDT) Date: Tue, 11 May 2021 10:59:34 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Harman Kalra , Harini Ramakrishnan , ranjit.menon@intel.com Message-ID: <20210511105934.104bbca5@sovereign> In-Reply-To: <2970635.tDqZXrgMp7@thomas> References: <20210502023333.30351-1-dmitry.kozliuk@gmail.com> <20210502023333.30351-3-dmitry.kozliuk@gmail.com> <2970635.tDqZXrgMp7@thomas> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] eal/windows: cleanup interrupt resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-05-11 09:41 (UTC+0200), Thomas Monjalon: > 02/05/2021 04:33, Dmitry Kozlyuk: > > Interrupt manager in Windows EAL allocates on IOCP and starts > > a control thread that runs indefinitely. At DPDK cleanup > > this thread was not stopped and IOCP handle was not closed. > > > > Gracefully stop interrupt-handling in rte_eal_cleanup(). > > The thread already closes IOCP handle before exiting. > > > > Fixes: 5c016fc0205a ("eal/windows: add interrupt thread skeleton") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dmitry Kozlyuk > > --- > > lib/eal/windows/eal.c | 1 + > > lib/eal/windows/eal_interrupts.c | 26 ++++++++++++++++++++++++-- > > lib/eal/windows/eal_windows.h | 5 +++++ > > 3 files changed, 30 insertions(+), 2 deletions(-) > > It seems nobody reviewed. > To be on the safe side, I'll merge this series after DPDK 21.05 is released. > Or am I missing any critical issue? IIRC Windows DPDK is not shipped anywhere yet, so the fix can be postponed. Without fix in 2/3 rte_eal_alarm_set() will start failing after some thousands of calls (i40e calls every 50 ms, mlx5 call every 1 sec or less). For mlx5 it seems to break flow counters (mlx5_flow_query_alarm function).