DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: timothy.mcdaniel@intel.com, maxime.coquelin@redhat.com,
	chenbo.xia@intel.com
Subject: [dpdk-dev] [PATCH v2 0/2] Thread termination leak fixes
Date: Tue, 11 May 2021 13:33:56 +0200	[thread overview]
Message-ID: <20210511113358.2485-1-david.marchand@redhat.com> (raw)
In-Reply-To: <20210506094452.1689-1-david.marchand@redhat.com>

After looking at the control thread API use in recent changes, I noticed
that some thread resources are not properly released.
This series fixes two net drivers.

Additional notes:
- I noticed that event/dlb2 never kills/terminates its service thread.
  It means unplug of this device (if supported) would leak the associated
  thread resources. I leave it to this driver maintainer to comment/fix.

- The vhost library also lets a service thread in the background but since
  there is no way to unitialize this library, there is no leak to fix from
  my pov.

-- 
David Marchand

Changes since v1:
- fixed build for net/ice on Windows

David Marchand (2):
  net/ark: fix leak on thread termination
  net/ice: fix leak on thread termination

 drivers/net/ark/ark_pktgen.c      | 2 ++
 drivers/net/ice/ice_dcf_parent.c  | 2 ++
 lib/eal/windows/include/pthread.h | 6 ++++++
 3 files changed, 10 insertions(+)

-- 
2.23.0


  parent reply	other threads:[~2021-05-11 11:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06  9:44 [dpdk-dev] [PATCH " David Marchand
2021-05-06  9:44 ` [dpdk-dev] [PATCH 1/2] net/ark: fix leak on thread termination David Marchand
2021-05-11 17:55   ` Ed Czeck
2021-05-06  9:44 ` [dpdk-dev] [PATCH 2/2] net/ice: " David Marchand
2021-05-06 10:31   ` Wang, Haiyue
2021-05-07  8:13   ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-05-07 17:14     ` Dmitry Kozlyuk
2021-05-11 11:33 ` David Marchand [this message]
2021-05-11 11:33   ` [dpdk-dev] [PATCH v2 1/2] net/ark: " David Marchand
2021-05-11 11:33   ` [dpdk-dev] [PATCH v2 2/2] net/ice: " David Marchand
2021-05-11 17:34     ` Dmitry Kozlyuk
2021-05-11 21:41   ` [dpdk-dev] [PATCH v2 0/2] Thread termination leak fixes Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210511113358.2485-1-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).