From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 404FEA0A0E;
	Tue, 11 May 2021 18:08:34 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B244E40140;
	Tue, 11 May 2021 18:08:33 +0200 (CEST)
Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com
 [209.85.167.46])
 by mails.dpdk.org (Postfix) with ESMTP id CC7E84003E;
 Tue, 11 May 2021 18:08:31 +0200 (CEST)
Received: by mail-lf1-f46.google.com with SMTP id c3so29433789lfs.7;
 Tue, 11 May 2021 09:08:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=TB+JzRubYK9m4nAsoC6WjHfUJ27/8ic2t2IUU2saPds=;
 b=Edhb4/81Mr+DBBU89Rjl3pMHX/Cf61lluZMq+lya6lsJOzrCws6CnwsHyykwHzdol+
 yMwQMEtVombe+kXM/02rnyuIbK2Q4IFLopAXYftlkHfsd4Y5IxUkrR5N57YfqXwe6d9M
 920T0xqzBURQFiMpKRFmi6ArP34xHWAzU+PxZVkDwWDRbA8ELBsKEVFC1675CQU2B92r
 M3oMqp4fVbMVm0zQOsXivQcn2M8WHwPkQdC+Da6aEfIs1jFZwu6Jhpy87oaKwbxOStk3
 EnwMYyE5lX47j+MdzHcnGE4/MHZ9VZ9YrkO/IojeRGmcdNpTj2c5P9rEOn5ZQru9qS1S
 xtJw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=TB+JzRubYK9m4nAsoC6WjHfUJ27/8ic2t2IUU2saPds=;
 b=ZPaqpewf2JkWJDh28e9sYSbkSuyF0yXz43FU+rcyBUUpZomQZ++wDg9vhxgZZcUpuQ
 iv/vu3sj0YwjV6sVSagIYoI6thexd1Py/3WQSi455tGhAmY3/brTa/x1PEuwUsYdimvl
 hOy3Jd4Zh70ZutcQ7hu4MeEAfTjxIkjwqdikScDpD3aGxVJOi5krNydPH1NrSSp54M5L
 JzM8D6BBxAZIn/MDFoAgppbQHls1hJWNYXtTtbnqQNt978ajkleSJiYE2TtU72Z/ssX6
 YgC/zn3hfJr+mxlj116v0WV5lX2uHuHJS2DV+GGWrOtieP7LEsk9SxBuhilGRtt6jxW1
 Q2ww==
X-Gm-Message-State: AOAM532gm4UBFgWBldPF6t61mDOWukrpvnh3bgAjzMYm473T5yOjFwR7
 VKSbNcZEEo6MXVNJWVV0KpE=
X-Google-Smtp-Source: ABdhPJwB3mFVR4n7exuzXdAD8EHTsllJQjk0O7WHSKvaG6mvPhhFOkK+wHJNIwvd3BHI9NOFLPASAA==
X-Received: by 2002:a05:6512:3e14:: with SMTP id
 i20mr20884332lfv.142.1620749311263; 
 Tue, 11 May 2021 09:08:31 -0700 (PDT)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
 [37.110.65.23])
 by smtp.gmail.com with ESMTPSA id s23sm1359635lfc.86.2021.05.11.09.08.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 11 May 2021 09:08:30 -0700 (PDT)
Date: Tue, 11 May 2021 19:08:29 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Lance Richardson <lance.richardson@broadcom.com>
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy
 <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>, dev
 <dev@dpdk.org>, Anatoly Burakov <anatoly.burakov@intel.com>, Thomas
 Monjalon <thomas@monjalon.net>, dpdk stable <stable@dpdk.org>
Message-ID: <20210511190829.5aa8e256@sovereign>
In-Reply-To: <CADyeNEBtdqDE+KCJi3=VyME5x46X7rsKVQUD0ucqsvkn4k7TTQ@mail.gmail.com>
References: <20210507181025.84012-1-lance.richardson@broadcom.com>
 <20210511144554.146987-1-lance.richardson@broadcom.com>
 <CADyeNEBtdqDE+KCJi3=VyME5x46X7rsKVQUD0ucqsvkn4k7TTQ@mail.gmail.com>
X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4] eal: fix memory mapping for 32-bit targets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2021-05-11 11:56 (UTC-0400), Lance Richardson:
> >  v4: Identical to v1, with <sys/types.h> now included in rte_eal_paging.h
> >      to (hopefully) make off_t available for Windows builds.  
> 
> With this version, using off_t is no longer a problem, however based on the
> new compilation error it appears that for Windows, off_t is a 32-bit type
> while size_t is a 64-bit type:
> 
> ../lib/eal/windows/eal_memory.c:519:37: error: shift count >= width of
> type [-Werror,-Wshift-count-overflow]
> DWORD offset_high = (DWORD)(offset >> 32);
> ^  ~~
> 
> So the options seem to be to either use uint64_t for the offset parameter
> as in patch v3, or else introduce something like:
>      typedef uint64_t rte_off_t;
> 
> Thoughts/opinions?

I'm for uint64_t: it's explicit and will hardly ever change.