From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 02F28A0C46;
	Wed, 12 May 2021 00:34:38 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 705AF4003F;
	Wed, 12 May 2021 00:34:38 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 48D1C4003E;
 Wed, 12 May 2021 00:34:36 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 54E4220B7178; Tue, 11 May 2021 15:34:35 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 54E4220B7178
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1620772475;
 bh=TFSsSX4IhRzs1Ju8+I+OHK0BfLKcj4MbrIBFaXFv/78=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=qeaK6TSl91Jgo+dhYGESo7iY4wmx9wbWBaCFzRkqxDIbVXrPrUhz5rDTp7yHKiNrV
 WgvYaZTm/xw/tmcGyMOn6yc/uazrP7PIxRPnsyoxQMO6WonkwLW3CE4qM1lz7iV5la
 TOIUqR16nYHT61WghTjBLWHmrn5DUPkZx6nZylos=
Date: Tue, 11 May 2021 15:34:35 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, stable@dpdk.org,
 dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 John McNamara <john.mcnamara@intel.com>
Message-ID: <20210511223435.GA4881@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20210502025656.29910-1-dmitry.kozliuk@gmail.com>
 <10660804.QYKOPib57F@thomas>
 <20210505224521.GA32065@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <2280101.VUMvbZbiro@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2280101.VUMvbZbiro@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/rxtx_callbacks: fix
 port ID format specifier
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, May 06, 2021 at 01:13:07AM +0200, Thomas Monjalon wrote:
> 06/05/2021 00:45, Tyler Retzlaff:
> > as a side question, what is the projects stance on getting more warnings
> > clean? there are a few not enabled that i'd really like to see e.g.
> > format, conversion, truncation etc..
> > 
> > i looked at lib/eal previously and there are... hundreds? of instances so
> > it's a non-trivial task. the problem i see is somehow getting to a
> > warnings clean state where we can enable -Werror in the CI pipeline but
> > at the same time figuring out how to prevent new instances from
> > appearing until we do.
> 
> I don't understand the question.
> We are already supposed to be warning-free,
> and -werror should be enabled in all CI labs.
> What are the gaps?

with the warnings we have enabled -Werror passes, but we don't have all
the warnings we could have that are of value.  it would be great to see
-Wconversion -Wsign-compare -Wsign-conversion passing clean.

i admit it is a lot of work though.