* [dpdk-dev] [PATCH] net/iavf: fix wrong Tx context descriptor
@ 2021-05-12 7:06 beilei.xing
2021-05-12 8:10 ` [dpdk-dev] [PATCH v2] " beilei.xing
0 siblings, 1 reply; 4+ messages in thread
From: beilei.xing @ 2021-05-12 7:06 UTC (permalink / raw)
To: qi.z.zhang; +Cc: dev, Beilei Xing, stable
From: Beilei Xing <beilei.xing@intel.com>
The QW0 of Tx context descriptor should be reset to 0, otherwise the
previous hardware writeback value may polute the next context descriptor
write.
Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/iavf/iavf_rxtx.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 74b5ab5bde..6a713df828 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -2245,6 +2245,11 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
(volatile struct iavf_tx_context_desc *)
&txr[tx_id];
+ /* clear QW0 or the previous writeback value
+ * may impact next write
+ */
+ *(volatile uint64_t *)ctx_txd = 0;
+
txn = &sw_ring[txe->next_id];
RTE_MBUF_PREFETCH_TO_FREE(txn->mbuf);
if (txe->mbuf) {
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] net/iavf: fix wrong Tx context descriptor
2021-05-12 7:06 [dpdk-dev] [PATCH] net/iavf: fix wrong Tx context descriptor beilei.xing
@ 2021-05-12 8:10 ` beilei.xing
2021-05-12 8:51 ` Zhang, Qi Z
0 siblings, 1 reply; 4+ messages in thread
From: beilei.xing @ 2021-05-12 8:10 UTC (permalink / raw)
To: qi.z.zhang; +Cc: dev, Beilei Xing, stable
From: Beilei Xing <beilei.xing@intel.com>
The QW0 of Tx context descriptor should be reset to 0, otherwise the
previous hardware writeback value may pollute the next context descriptor
write.
Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
v2 change:
- Typo fix.
drivers/net/iavf/iavf_rxtx.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 74b5ab5bde..6a713df828 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -2245,6 +2245,11 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
(volatile struct iavf_tx_context_desc *)
&txr[tx_id];
+ /* clear QW0 or the previous writeback value
+ * may impact next write
+ */
+ *(volatile uint64_t *)ctx_txd = 0;
+
txn = &sw_ring[txe->next_id];
RTE_MBUF_PREFETCH_TO_FREE(txn->mbuf);
if (txe->mbuf) {
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/iavf: fix wrong Tx context descriptor
2021-05-12 8:10 ` [dpdk-dev] [PATCH v2] " beilei.xing
@ 2021-05-12 8:51 ` Zhang, Qi Z
0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2021-05-12 8:51 UTC (permalink / raw)
To: Xing, Beilei; +Cc: dev, stable
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Wednesday, May 12, 2021 4:10 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/iavf: fix wrong Tx context descriptor
>
> From: Beilei Xing <beilei.xing@intel.com>
>
> The QW0 of Tx context descriptor should be reset to 0, otherwise the previous
> hardware writeback value may pollute the next context descriptor write.
>
> Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] net/iavf: fix wrong Tx context descriptor
@ 2021-05-12 8:04 beilei.xing
0 siblings, 0 replies; 4+ messages in thread
From: beilei.xing @ 2021-05-12 8:04 UTC (permalink / raw)
To: qi.z.zhang; +Cc: dev, Beilei Xing, stable
From: Beilei Xing <beilei.xing@intel.com>
The QW0 of Tx context descriptor should be reset to 0, otherwise the
previous hardware writeback value may pollute the next context descriptor
write.
Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
v2 change:
- Typo fix.
drivers/net/iavf/iavf_rxtx.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 74b5ab5bde..6a713df828 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -2245,6 +2245,11 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
(volatile struct iavf_tx_context_desc *)
&txr[tx_id];
+ /* clear QW0 or the previous writeback value
+ * may impact next write
+ */
+ *(volatile uint64_t *)ctx_txd = 0;
+
txn = &sw_ring[txe->next_id];
RTE_MBUF_PREFETCH_TO_FREE(txn->mbuf);
if (txe->mbuf) {
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-12 8:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 7:06 [dpdk-dev] [PATCH] net/iavf: fix wrong Tx context descriptor beilei.xing
2021-05-12 8:10 ` [dpdk-dev] [PATCH v2] " beilei.xing
2021-05-12 8:51 ` Zhang, Qi Z
2021-05-12 8:04 beilei.xing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).