DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ciara Power <ciara.power@intel.com>
To: dev@dpdk.org
Cc: roy.fan.zhang@intel.com, declan.doherty@intel.com,
	aconole@redhat.com, gakhil@marvell.com,
	Ciara Power <ciara.power@intel.com>
Subject: [dpdk-dev] [PATCH] test/crypto: fix test status when PMD isn't loaded
Date: Tue, 18 May 2021 14:19:55 +0000	[thread overview]
Message-ID: <20210518141955.960508-1-ciara.power@intel.com> (raw)

The return value for a test when the required PMD is not loaded should
be TEST_SKIPPED, rather than TEST_FAILED.

Fixes: 8bfdd8a7f0f1 ("test/crypto: refactor to use sub test suites")

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 app/test/test_cryptodev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 736952a9e6..c68684b80b 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -14504,7 +14504,7 @@ run_cryptodev_testsuite(const char *pmd_name)
 
 	if (gbl_driver_id == -1) {
 		RTE_LOG(ERR, USER1, "%s PMD must be loaded.\n", pmd_name);
-		return TEST_FAILED;
+		return TEST_SKIPPED;
 	}
 
 	ts.unit_test_suites = malloc(sizeof(struct unit_test_suite *) *
-- 
2.25.1


             reply	other threads:[~2021-05-18 14:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 14:19 Ciara Power [this message]
2021-05-18 14:37 ` Zhang, Roy Fan
2021-05-19  8:32   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210518141955.960508-1-ciara.power@intel.com \
    --to=ciara.power@intel.com \
    --cc=aconole@redhat.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).