From: Steve Yang <stevex.yang@intel.com>
To: dev@dpdk.org
Cc: beilei.xing@intel.com, Steve Yang <stevex.yang@intel.com>
Subject: [dpdk-dev] [PATCH v1] net/i40e: fix flow director does not work
Date: Wed, 19 May 2021 03:27:45 +0000 [thread overview]
Message-ID: <20210519032745.707639-1-stevex.yang@intel.com> (raw)
When user configured the flow rule with raw packet via command
"flow_director_filter", it would reset all previous fdir input set
flags with "i40e_flow_set_fdir_inset()".
Ignore to configure the flow input set with raw packet rule used.
Fixes: ff04964ea6d5 ("net/i40e: fix flow director for common pctypes")
Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
drivers/net/i40e/i40e_fdir.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index ac0e09bfdd..3c7cf1ba90 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -1768,7 +1768,8 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev *dev,
if (add) {
/* configure the input set for common PCTYPEs*/
- if (!filter->input.flow_ext.customized_pctype) {
+ if (!filter->input.flow_ext.customized_pctype &&
+ !filter->input.flow_ext.pkt_template) {
ret = i40e_flow_set_fdir_inset(pf, pctype,
filter->input.flow_ext.input_set);
if (ret < 0)
--
2.27.0
next reply other threads:[~2021-05-19 3:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 3:27 Steve Yang [this message]
2021-05-24 3:32 ` Xing, Beilei
2021-06-01 11:12 ` Zhang, Qi Z
2021-06-16 17:23 ` Thomas Monjalon
2021-06-17 3:38 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519032745.707639-1-stevex.yang@intel.com \
--to=stevex.yang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).