Add in missing rte_mbuf size in mempool allocation for out-of-place op. Fixes: bf9d6702eca9 ("app/crypto-perf: use single mempool") Cc: pablo.de.lara.guarch@intel.com Signed-off-by: Kai Ji <kai.ji@intel.com> --- app/test-crypto-perf/cperf_test_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_test_common.c b/app/test-crypto-perf/cperf_test_common.c index 058e0ba564..12925c7f22 100644 --- a/app/test-crypto-perf/cperf_test_common.c +++ b/app/test-crypto-perf/cperf_test_common.c @@ -194,7 +194,7 @@ cperf_alloc_common_memory(const struct cperf_options *options, (mbuf_size * segments_nb); params.dst_buf_offset = *dst_buf_offset; /* Destination buffer will be one segment only */ - obj_size += max_size; + obj_size += max_size + sizeof(struct rte_mbuf); } *pool = rte_mempool_create_empty(pool_name, -- 2.17.1 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
> -----Original Message-----
> From: Ji, Kai <kai.ji@intel.com>
> Sent: Thursday, May 20, 2021 4:07 PM
> To: dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Ji, Kai <kai.ji@intel.com>;
> De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev v1] cperf: fix crypto perf out-of-place mempool alloc
>
> Add in missing rte_mbuf size in mempool allocation for out-of-place op.
>
> Fixes: bf9d6702eca9 ("app/crypto-perf: use single mempool")
> Cc: pablo.de.lara.guarch@intel.com
>
> Signed-off-by: Kai Ji <kai.ji@intel.com>
> ---
> app/test-crypto-perf/cperf_test_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-crypto-perf/cperf_test_common.c b/app/test-crypto-
> perf/cperf_test_common.c
> index 058e0ba564..12925c7f22 100644
> --- a/app/test-crypto-perf/cperf_test_common.c
> +++ b/app/test-crypto-perf/cperf_test_common.c
> @@ -194,7 +194,7 @@ cperf_alloc_common_memory(const struct
> cperf_options *options,
> (mbuf_size * segments_nb);
> params.dst_buf_offset = *dst_buf_offset;
> /* Destination buffer will be one segment only */
> - obj_size += max_size;
> + obj_size += max_size + sizeof(struct rte_mbuf);
> }
>
> *pool = rte_mempool_create_empty(pool_name,
> --
> 2.17.1
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Sent: Friday, May 21, 2021 10:05 AM
> To: Ji, Kai <kai.ji@intel.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: RE: [dpdk-dev v1] cperf: fix crypto perf out-of-place mempool alloc
>
> > -----Original Message-----
> > From: Ji, Kai <kai.ji@intel.com>
> > Sent: Thursday, May 20, 2021 4:07 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Ji, Kai
> > <kai.ji@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Subject: [dpdk-dev v1] cperf: fix crypto perf out-of-place mempool
> > alloc
> >
> > Add in missing rte_mbuf size in mempool allocation for out-of-place op.
> >
> > Fixes: bf9d6702eca9 ("app/crypto-perf: use single mempool")
> > Cc: pablo.de.lara.guarch@intel.com
> >
> > Signed-off-by: Kai Ji <kai.ji@intel.com>
> > ---
> > app/test-crypto-perf/cperf_test_common.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-crypto-perf/cperf_test_common.c
> > b/app/test-crypto- perf/cperf_test_common.c index
> > 058e0ba564..12925c7f22 100644
> > --- a/app/test-crypto-perf/cperf_test_common.c
> > +++ b/app/test-crypto-perf/cperf_test_common.c
> > @@ -194,7 +194,7 @@ cperf_alloc_common_memory(const struct
> > cperf_options *options,
> > (mbuf_size * segments_nb);
> > params.dst_buf_offset = *dst_buf_offset;
> > /* Destination buffer will be one segment only */
> > - obj_size += max_size;
> > + obj_size += max_size + sizeof(struct rte_mbuf);
> > }
> >
> > *pool = rte_mempool_create_empty(pool_name,
> > --
> > 2.17.1
>
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > > Add in missing rte_mbuf size in mempool allocation for out-of-place op.
> > >
> > > Fixes: bf9d6702eca9 ("app/crypto-perf: use single mempool")
> > > Cc: pablo.de.lara.guarch@intel.com
> > >
> > > Signed-off-by: Kai Ji <kai.ji@intel.com>
> > Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Given the root cause is 3 years old, it is probably not urgent enough
to be merged in the last day of 21.05.
I won't take any risk at this stage.
Hi Thomas,
Sure, no problem. Thanks.
Congrats on 21.05 release!
Regards,
Fan
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, May 21, 2021 4:37 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Ji, Kai <kai.ji@intel.com>;
> De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [dpdk-dev v1] cperf: fix crypto perf out-of-place
> mempool alloc
>
> > > > Add in missing rte_mbuf size in mempool allocation for out-of-place op.
> > > >
> > > > Fixes: bf9d6702eca9 ("app/crypto-perf: use single mempool")
> > > > Cc: pablo.de.lara.guarch@intel.com
> > > >
> > > > Signed-off-by: Kai Ji <kai.ji@intel.com>
> > > Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Given the root cause is 3 years old, it is probably not urgent enough
> to be merged in the last day of 21.05.
> I won't take any risk at this stage.
>
Add in missing rte_mbuf size in mempool allocation for out-of-place op. Fixes: bf9d6702eca9 ("app/crypto-perf: use single mempool") Cc: pablo.de.lara.guarch@intel.com Signed-off-by: Kai Ji <kai.ji@intel.com> Acked-by: Fan Zhang <roy.fan.zhang@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> --- v2: -- commit message update app/test-crypto-perf/cperf_test_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_test_common.c b/app/test-crypto-perf/cperf_test_common.c index 058e0ba564..12925c7f22 100644 --- a/app/test-crypto-perf/cperf_test_common.c +++ b/app/test-crypto-perf/cperf_test_common.c @@ -194,7 +194,7 @@ cperf_alloc_common_memory(const struct cperf_options *options, (mbuf_size * segments_nb); params.dst_buf_offset = *dst_buf_offset; /* Destination buffer will be one segment only */ - obj_size += max_size; + obj_size += max_size + sizeof(struct rte_mbuf); } *pool = rte_mempool_create_empty(pool_name, -- 2.17.1
> Add in missing rte_mbuf size in mempool allocation for out-of-place op.
>
> Fixes: bf9d6702eca9 ("app/crypto-perf: use single mempool")
> Cc: pablo.de.lara.guarch@intel.com
>
> Signed-off-by: Kai Ji <kai.ji@intel.com>
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> v2:
> -- commit message update
Applied to dpdk-next-crypto
Thanks.