* [dpdk-dev] [PATCH] net/octeontx_ep: do not use a NULL Pointer
@ 2021-05-24 8:59 Thierry Herbelot
2021-06-29 18:09 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Herbelot @ 2021-05-24 8:59 UTC (permalink / raw)
To: dev
Cc: Thierry Herbelot, Thomas Monjalon, stable, Nalla Pradeep,
Radha Mohan Chintakuntla, Veerasenareddy Burru
mz is known to be NULL: do not use it to print a memzone name.
Fixes: 242e18c056890 ("net/octeontx_ep: add Rx queue setup and release")
Cc: stable@dpdk.org
Cc: Nalla Pradeep <pnalla@marvell.com>
Cc: Radha Mohan Chintakuntla <radhac@marvell.com>
Cc: Veerasenareddy Burru <vburru@marvell.com>
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
drivers/net/octeontx_ep/otx_ep_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/octeontx_ep/otx_ep_rxtx.c b/drivers/net/octeontx_ep/otx_ep_rxtx.c
index 28ff74d2d5b0..a7d433547e36 100644
--- a/drivers/net/octeontx_ep/otx_ep_rxtx.c
+++ b/drivers/net/octeontx_ep/otx_ep_rxtx.c
@@ -27,7 +27,7 @@ otx_ep_dmazone_free(const struct rte_memzone *mz)
int ret = 0;
if (mz == NULL) {
- otx_ep_err("Memzone %s : NULL\n", mz->name);
+ otx_ep_err("Memzone: NULL\n");
return;
}
--
2.29.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] net/octeontx_ep: do not use a NULL Pointer
2021-05-24 8:59 [dpdk-dev] [PATCH] net/octeontx_ep: do not use a NULL Pointer Thierry Herbelot
@ 2021-06-29 18:09 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2021-06-29 18:09 UTC (permalink / raw)
To: Thierry Herbelot
Cc: dpdk-dev, Thomas Monjalon, dpdk stable, Nalla Pradeep,
Radha Mohan Chintakuntla, Veerasenareddy Burru
On Mon, May 24, 2021 at 2:30 PM Thierry Herbelot
<thierry.herbelot@6wind.com> wrote:
>
> mz is known to be NULL: do not use it to print a memzone name.
>
> Fixes: 242e18c056890 ("net/octeontx_ep: add Rx queue setup and release")
> Cc: stable@dpdk.org
> Cc: Nalla Pradeep <pnalla@marvell.com>
> Cc: Radha Mohan Chintakuntla <radhac@marvell.com>
> Cc: Veerasenareddy Burru <vburru@marvell.com>
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Changed the git log to following and Applied to
dpdk-next-net-mrvl/for-next-net. Thanks
Author: Thierry Herbelot <thierry.herbelot@6wind.com>
Date: Mon May 24 10:59:35 2021 +0200
net/octeontx_ep: fix null pointer access
mz is known to be NULL. Do not use it to print a memzone name.
Fixes: 242e18c056890 ("net/octeontx_ep: add Rx queue setup and release")
Cc: stable@dpdk.org
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
> drivers/net/octeontx_ep/otx_ep_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/octeontx_ep/otx_ep_rxtx.c b/drivers/net/octeontx_ep/otx_ep_rxtx.c
> index 28ff74d2d5b0..a7d433547e36 100644
> --- a/drivers/net/octeontx_ep/otx_ep_rxtx.c
> +++ b/drivers/net/octeontx_ep/otx_ep_rxtx.c
> @@ -27,7 +27,7 @@ otx_ep_dmazone_free(const struct rte_memzone *mz)
> int ret = 0;
>
> if (mz == NULL) {
> - otx_ep_err("Memzone %s : NULL\n", mz->name);
> + otx_ep_err("Memzone: NULL\n");
> return;
> }
>
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-29 18:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 8:59 [dpdk-dev] [PATCH] net/octeontx_ep: do not use a NULL Pointer Thierry Herbelot
2021-06-29 18:09 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).