From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59A95A0547; Mon, 24 May 2021 18:19:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBE4D4003E; Mon, 24 May 2021 18:19:48 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 590154003C for ; Mon, 24 May 2021 18:19:47 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id a7so6169839plh.3 for ; Mon, 24 May 2021 09:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wDl0mFjjgdqHgl8Y4gmn8AI3VxDyQtIaBuKHUYX4cv0=; b=sk5znEjIt9shm7Vgu9HPO5D3DfVDkOXnO7+7qlyZQcLOh9t0UG2LNxaA7AithRxRmv ZSP9ecOK1e/mBLLZ3SQd8ZRiW0k+uyndmarkgTyrcd4ZuCzMv1dbIsuyRw8ymzKGKxFN sIXMF9PerxfNETzyTdJLlrEyH43g0h/VsU/mZdWKvIBc4dXV4rWT5FfxxXvI5y6tyFZe 0sQqRDyzmLtQb4vG6Hzwa/nLPRl9XafDZmMlncJlYzcYq4D8IV6yJIzd6b0HTLUL+jSb RBW6pPfXDyJr1fLdW1FATSsMRsQkr+fMIP8EJQwIoRfKgotvIyaNqm3dHgCk92s/sfsf SyNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wDl0mFjjgdqHgl8Y4gmn8AI3VxDyQtIaBuKHUYX4cv0=; b=Ct3Opi8QLBtyw+1OI4zO3ZPvvwnRJaX/WD1llEGFCMKca7m4Dz0vhb+e3UQtxdl+Eh C1UwY2kCN4xf7lwqnpKhPo4qPM7Ft8GA5FEp9UifKQbF1/dxjs3SK09evSw4Ttgcm1Io QS+LyY9S3YUqvHppmT+dEPwsuNQETL7BaQjC76WFiiCXnd9FO4USoAjtW/Uqxeyvttq1 OyIzgh2+KCaUl+f93RKrU/qXEMKLG3JK4w6rOGF5LNwIim0EJzHBXhkGKlAVD5dkLCnG j8nRYq8zfokqPfv753AHFB7UAkTuuGn2jhD4QpF1O5jEDaIQg/ag0btGjlL0AVnRqApY P92A== X-Gm-Message-State: AOAM530Tbh2hKmHaOiItMphkOLtJNEKnmktEsFZDSVVNFVjX0r8LiShZ pawzcuk9CxWm0QDFnxA3RSDNaA== X-Google-Smtp-Source: ABdhPJw9KzTUGoA2LrrPDLovdWlX+YVOtWL2xC5T8mnjUE1nCirh3qG3PY8ltKskxuf+NTyWr7lFhA== X-Received: by 2002:a17:902:f545:b029:f5:4b82:9cc9 with SMTP id h5-20020a170902f545b02900f54b829cc9mr26047106plf.68.1621873186248; Mon, 24 May 2021 09:19:46 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id n2sm10390356pjo.1.2021.05.24.09.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 May 2021 09:19:45 -0700 (PDT) Date: Mon, 24 May 2021 09:19:43 -0700 From: Stephen Hemminger To: "Liguzinski, WojciechX" Cc: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, savinay.dharmappa@intel.com Message-ID: <20210524091943.2599114a@hermes.local> In-Reply-To: <20210524105822.63171-1-wojciechx.liguzinski@intel.com> References: <20210524105822.63171-1-wojciechx.liguzinski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH 0/3] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 24 May 2021 11:58:19 +0100 "Liguzinski, WojciechX" wrote: > DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem > which is a situation when excess buffers in the network cause high latency and latency > variation. Currently, it supports RED for queue congestion control (which is designed > to control the queue length but it does not control latency directly and is now being > obsoleted ). However, more advanced queue management is required to address this problem > and provide desirable quality of service to users. > > This solution (RFC) proposes usage of new algorithm called "PIE" (Proportional Integral > controller Enhanced) that can effectively and directly control queuing latency to address > the bufferbloat problem. > > The implementation of mentioned functionality includes modification of existing and > adding a new set of data structures to the library, adding PIE related APIs. > This affects structures in public API/ABI. That is why deprecation notice is going > to be prepared and sent. > > > Liguzinski, WojciechX (3): > sched: add pie based congestion management > example/qos_sched: add pie support > example/ip_pipeline: add pie support > > config/rte_config.h | 1 - > drivers/net/softnic/rte_eth_softnic_tm.c | 4 +- > examples/ip_pipeline/tmgr.c | 4 +- > examples/qos_sched/app_thread.c | 1 - > examples/qos_sched/cfg_file.c | 82 +++++++-- > examples/qos_sched/init.c | 5 +- > examples/qos_sched/profile.cfg | 196 +++++++++++++------- > lib/sched/meson.build | 10 +- > lib/sched/rte_sched.c | 220 +++++++++++++++++------ > lib/sched/rte_sched.h | 53 ++++-- > 10 files changed, 411 insertions(+), 165 deletions(-) What about FQ codel which is more widely deployed, has less configuration?