From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE177A0524; Mon, 31 May 2021 13:30:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39DF540040; Mon, 31 May 2021 13:30:24 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D76744003F for ; Mon, 31 May 2021 13:30:22 +0200 (CEST) IronPort-SDR: +CgVMkXYe5g3/3tQgyf/Y79ENCMsHXOaQDdNAyo7OgwcSdQbjZc5BdCGcyRzPIIz2vFqUQKhHU MKpQKnSx9lAA== X-IronPort-AV: E=McAfee;i="6200,9189,10000"; a="190457336" X-IronPort-AV: E=Sophos;i="5.83,237,1616482800"; d="scan'208";a="190457336" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2021 04:30:18 -0700 IronPort-SDR: HNew3u7UO67AjUHnwqs7ORYE2vsyqFeZUjEJDOTSRpTDIyKPzpGYJ+ZRAmANULZtVDO+YeZ8df HSpW4gDeFkPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,237,1616482800"; d="scan'208";a="416130881" Received: from silpixa00399952.ir.intel.com ([10.55.129.13]) by orsmga002.jf.intel.com with ESMTP; 31 May 2021 04:30:18 -0700 From: David Hunt To: dev@dpdk.org Cc: david.hunt@intel.com Date: Mon, 31 May 2021 12:30:08 +0100 Message-Id: <20210531113008.3087-1-david.hunt@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH v1] examples/power: add baseline mode to PMD power X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD Power Management scheme currently has 3 modes, scale, monitor and pause. However, it would be nice to have a baseline mode for easy comparison of power savings with and without these modes. This patch adds a 'baseline' mode were the pmd power management is not enabled. Use --pmg-mgmt=baseline. Signed-off-by: David Hunt --- examples/l3fwd-power/main.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index f8dfed1634..34b0eaa401 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1617,7 +1617,7 @@ print_usage(const char *prgname) " empty polls, full polls, and core busyness to telemetry\n" " --interrupt-only: enable interrupt-only mode\n" " --pmd-mgmt MODE: enable PMD power management mode. " - "Currently supported modes: monitor, pause, scale\n", + "Currently supported modes: baseline, monitor, pause, scale\n", prgname); } @@ -1714,6 +1714,7 @@ parse_pmd_mgmt_config(const char *name) #define PMD_MGMT_MONITOR "monitor" #define PMD_MGMT_PAUSE "pause" #define PMD_MGMT_SCALE "scale" +#define PMD_MGMT_BASELINE "baseline" if (strncmp(PMD_MGMT_MONITOR, name, sizeof(PMD_MGMT_MONITOR)) == 0) { pmgmt_type = RTE_POWER_MGMT_TYPE_MONITOR; @@ -1729,6 +1730,10 @@ parse_pmd_mgmt_config(const char *name) pmgmt_type = RTE_POWER_MGMT_TYPE_SCALE; return 0; } + if (strncmp(PMD_MGMT_BASELINE, name, sizeof(PMD_MGMT_BASELINE)) == 0) { + pmgmt_type = -1; + return 0; + } /* unknown PMD power management mode */ return -1; } @@ -2767,7 +2772,8 @@ main(int argc, char **argv) "Fail to add ptype cb\n"); } - if (app_mode == APP_MODE_PMD_MGMT) { + if ((app_mode == APP_MODE_PMD_MGMT) && + (pmgmt_type >= 0)) { ret = rte_power_ethdev_pmgmt_queue_enable( lcore_id, portid, queueid, pmgmt_type); -- 2.17.1