From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8622A0524; Tue, 1 Jun 2021 07:42:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5972D40041; Tue, 1 Jun 2021 07:42:54 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 547BB40040 for ; Tue, 1 Jun 2021 07:42:53 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lnxAy-0002A1-Ck; Tue, 01 Jun 2021 05:42:52 +0000 From: Christian Ehrhardt To: dev Cc: Nithin Dabilpuram , Anatoly Burakov , Thomas Monjalon , Christian Ehrhardt Date: Tue, 1 Jun 2021 07:42:47 +0200 Message-Id: <20210601054247.1540154-1-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] vfio: fix stdbool usage without include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This became visible by backporting the following for the 19.11 stable tree: c13ca4e8 "vfio: fix DMA mapping granularity for IOVA as VA" The usage of type bool in the vfio code would require "#include ", but rte_vfio.h has no direct paths to stdbool.h. It happens that in eal_vfio_mp_sync.c it comes after "#include ". And rte_log.h since 20.05 includes stdbool since this change: 241e67bfe "log: add API to check if a logtype can log in a given level" and thereby masks the issue in >20.05. It should be safe to include stdbool.h from rte_vfio.h itself to have bool present exactly when needed for the struct it defines using that type. Signed-off-by: Christian Ehrhardt --- lib/eal/include/rte_vfio.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h index e7a87454bea..2d90b364801 100644 --- a/lib/eal/include/rte_vfio.h +++ b/lib/eal/include/rte_vfio.h @@ -14,6 +14,7 @@ extern "C" { #endif +#include #include /* -- 2.31.1