From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Heinrich Kuhn <heinrich.kuhn@netronome.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Igor Russkikh <irusskikh@marvell.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares
Date: Thu, 3 Jun 2021 00:19:19 +0300 [thread overview]
Message-ID: <20210603001919.7ea9c273@sovereign> (raw)
In-Reply-To: <20210602095836.24901-3-david.marchand@redhat.com>
2021-06-02 11:58 (UTC+0200), David Marchand:
> Introduce an internal firmware loading helper to remove code duplication
> in our drivers and handle xz compressed firmwares by calling libarchive.
>
> This helper tries to look for .xz suffixes so that drivers are not aware
> the firmwares have been compressed.
>
> libarchive is set as an optional dependency: without libarchive, a
> runtime warning is emitted so that users know there is a compressed
> firmware.
>
> Windows implementation is left as an empty stub.
JFYI, it doesn't seem hard to implement as a follow-up if need be.
libarchive is available for Windows and even provides a .pc file.
[...]
> diff --git a/config/meson.build b/config/meson.build
> index 017bb2efbb..337daa2719 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -166,6 +166,15 @@ if fdt_dep.found() and cc.has_header('fdt.h')
> dpdk_extra_ldflags += '-lfdt'
> endif
>
> +has_libarchive = 0
> +archive_dep = cc.find_library('libarchive', required: false)
> +if archive_dep.found() and cc.has_header('archive.h')
> + dpdk_conf.set10('RTE_HAS_LIBARCHIVE', true)
> + has_libarchive = 1
> + add_project_link_arguments('-larchive', language: 'c')
> + dpdk_extra_ldflags += '-larchive'
> +endif
> +
Why not use pkg-config?
`has_libarchive` is unused.
> libexecinfo = cc.find_library('libexecinfo', required: false)
> if libexecinfo.found() and cc.has_header('execinfo.h')
> add_project_link_arguments('-lexecinfo', language: 'c')
[...]
> diff --git a/lib/eal/version.map b/lib/eal/version.map
> index fe5c3dac98..020c058e5f 100644
> --- a/lib/eal/version.map
> +++ b/lib/eal/version.map
> @@ -423,11 +423,13 @@ EXPERIMENTAL {
> rte_version_release; # WINDOWS_NO_EXPORT
> rte_version_suffix; # WINDOWS_NO_EXPORT
> rte_version_year; # WINDOWS_NO_EXPORT
> +
> };
Unnecessary empty line.
>
> INTERNAL {
> global:
>
> + rte_firmware_read;
> rte_mem_lock;
> rte_mem_map;
> rte_mem_page_size;
next prev parent reply other threads:[~2021-06-02 21:19 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 9:58 [dpdk-dev] [PATCH 0/2] Support " David Marchand
2021-06-02 9:58 ` [dpdk-dev] [PATCH 1/2] net/ice: factorize firmware loading David Marchand
2021-06-02 9:58 ` [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares David Marchand
2021-06-02 11:13 ` Jerin Jacob
2021-06-02 15:46 ` David Marchand
2021-06-02 11:30 ` [dpdk-dev] [EXT] " Igor Russkikh
2021-06-02 21:19 ` Dmitry Kozlyuk [this message]
2021-06-03 7:23 ` [dpdk-dev] " David Marchand
2021-06-03 7:53 ` David Marchand
2021-06-03 8:14 ` Bruce Richardson
2021-06-02 10:35 ` [dpdk-dev] [EXT] [PATCH 0/2] Support " Igor Russkikh
2021-06-02 11:05 ` David Marchand
2021-06-02 11:23 ` Igor Russkikh
2021-06-03 16:55 ` [dpdk-dev] [PATCH v2 " David Marchand
2021-06-03 16:55 ` [dpdk-dev] [PATCH v2 1/2] net/ice: factorize firmware loading David Marchand
2021-06-28 7:58 ` David Marchand
2021-06-03 16:55 ` [dpdk-dev] [PATCH v2 2/2] eal: handle compressed firmwares David Marchand
2021-06-03 22:29 ` Dmitry Kozlyuk
2021-06-04 7:27 ` David Marchand
2021-06-04 21:40 ` Dmitry Kozlyuk
2021-06-07 9:28 ` David Marchand
2021-06-14 13:17 ` [dpdk-dev] [PATCH v2 0/2] Support " David Marchand
2021-06-29 8:06 ` [dpdk-dev] [PATCH v3 " David Marchand
2021-06-29 8:06 ` [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading David Marchand
2021-07-05 1:43 ` Wang, Haiyue
2021-07-05 3:33 ` Wang, Haiyue
2021-07-05 7:08 ` David Marchand
2021-07-05 8:02 ` Wang, Haiyue
2021-07-05 8:33 ` David Marchand
2021-07-05 9:59 ` Zhang, Qi Z
2021-07-05 11:46 ` Wang, Haiyue
2021-07-05 11:44 ` Wang, Haiyue
2021-07-05 13:18 ` Wang, Haiyue
2021-07-05 13:34 ` David Marchand
2021-06-29 8:06 ` [dpdk-dev] [PATCH v3 2/2] eal: handle compressed firmwares David Marchand
2021-06-29 12:45 ` Aaron Conole
2021-07-05 6:35 ` Wang, Haiyue
2021-07-05 6:54 ` David Marchand
2021-07-05 13:19 ` Wang, Haiyue
2021-07-06 14:29 ` [dpdk-dev] [PATCH v4 0/2] Support " David Marchand
2021-07-06 14:29 ` [dpdk-dev] [PATCH v4 1/2] net/ice: factorize firmware loading David Marchand
2021-07-06 14:29 ` [dpdk-dev] [PATCH v4 2/2] eal: handle compressed firmwares David Marchand
2021-07-07 12:08 ` [dpdk-dev] [PATCH v5 0/2] Support " David Marchand
2021-07-07 12:08 ` [dpdk-dev] [PATCH v5 1/2] net/ice: factorize firmware loading David Marchand
2021-07-07 12:08 ` [dpdk-dev] [PATCH v5 2/2] eal: handle compressed firmware David Marchand
2021-07-07 15:03 ` [dpdk-dev] [PATCH v5 0/2] Support compressed firmwares David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603001919.7ea9c273@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitrym@microsoft.com \
--cc=dsinghrawat@marvell.com \
--cc=heinrich.kuhn@netronome.com \
--cc=irusskikh@marvell.com \
--cc=maicolgabriel@hotmail.com \
--cc=mdr@ashroe.eu \
--cc=navasile@linux.microsoft.com \
--cc=nhorman@tuxdriver.com \
--cc=pallavi.kadam@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rmody@marvell.com \
--cc=shshaikh@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).