DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stanislaw Kardach <kda@semihalf.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Stanislaw Kardach <kda@semihalf.com>,
	pablo.de.lara.guarch@intel.com
Subject: [dpdk-dev] [PATCH v2 3/3] test: fix the -n unit test description
Date: Fri,  4 Jun 2021 16:16:01 +0200	[thread overview]
Message-ID: <20210604141601.275430-4-kda@semihalf.com> (raw)
In-Reply-To: <20210604141601.275430-1-kda@semihalf.com>

When -n argument became optional, the test logic was fixed (by
1e0b51fd4) but the comment indicating why --no-huge and --no-shconf are
used was not changed.
Today those flags are used for compatibility with FreeBSD (see
b5d878e6d), so change the comment to reflect that.

Signed-off-by: Stanislaw Kardach <kda@semihalf.com>

Fixes: b5d878e6db56 ("test: fix EAL flags autotest on FreeBSD")
Cc: anatoly.burakov@intel.com
Fixes: 1e0b51fd4b75 ("app/test: fix unit test for option -n")
Cc: pablo.de.lara.guarch@intel.com
---
 app/test/test_eal_flags.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index e2248a5d9a..b1ab87cf8d 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -666,8 +666,8 @@ test_main_lcore_flag(void)
 /*
  * Test that the app doesn't run with invalid -n flag option.
  * Final test ensures it does run with valid options as sanity check
- * Since -n is not compulsory for MP, we instead use --no-huge and --no-shconf
- * flags.
+ * For compatibility with BSD use --no-huge and --no-shconf flags as we need to
+ * run a primary process.
  */
 static int
 test_invalid_n_flag(void)
-- 
2.27.0


  parent reply	other threads:[~2021-06-04 14:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 14:15 [dpdk-dev] [PATCH v2 0/3] Increase test compatibility with PA IOVA Stanislaw Kardach
2021-06-04 14:15 ` [dpdk-dev] [PATCH v2 1/3] test: disable no-huge test " Stanislaw Kardach
2021-06-04 14:16 ` [dpdk-dev] [PATCH v2 2/3] test: disable no-huge where it's not necessary Stanislaw Kardach
2021-06-04 14:16 ` Stanislaw Kardach [this message]
2021-06-10  7:51 ` [dpdk-dev] [PATCH v2 0/3] Increase test compatibility with PA IOVA Stanislaw Kardach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604141601.275430-4-kda@semihalf.com \
    --to=kda@semihalf.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).