From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D389A034F; Tue, 8 Jun 2021 07:50:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 086EC410E7; Tue, 8 Jun 2021 07:50:36 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 1091C4013F for ; Tue, 8 Jun 2021 07:50:34 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1059) id 6689420B83DC; Mon, 7 Jun 2021 22:50:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6689420B83DC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1623131433; bh=t2eWCqBWgnUg3JuWc7odffUaEDidd6srU3O0YXzsyS8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ab1y94s775vZ8HT8bV/ZFrfykQ9RJORubsM6LSnjbGb/OFR9lY+yVGE4HNq5JJYI9 CSJkYdgXUmDvZHjKccaHzWHqqBFqudNETUdnlwwLl7oUSmo+ENl1tUva3fJrqpIe4t bT+bCiADREJHE4ou5ZRheviUus0fsTJT53r2vb3k= Date: Mon, 7 Jun 2021 22:50:33 -0700 From: Narcisa Ana Maria Vasile To: dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com, khot@microsoft.com, navasile@microsoft.com, dmitrym@microsoft.com, roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com Cc: bruce.richardson@intel.com, david.marchand@redhat.com, pallavi.kadam@intel.com Message-ID: <20210608055033.GA20476@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1622849908-5710-1-git-send-email-navasile@linux.microsoft.com> <1622850274-6946-1-git-send-email-navasile@linux.microsoft.com> <1622850274-6946-11-git-send-email-navasile@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1622850274-6946-11-git-send-email-navasile@linux.microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v9 10/10] Enable the new EAL thread API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 04, 2021 at 04:44:34PM -0700, Narcisa Ana Maria Vasile wrote: > From: Narcisa Vasile > > Rename pthread_* occurrences with the new rte_thread_* API. > Enable the new API in the build system. > > Signed-off-by: Narcisa Vasile > --- I'll send v10. Can someone please help with an example on how to check for ABI breaks? Thank you! I've run: DPDK_ABI_REF_VERSION=v21.05 DPDK_ABI_REF_DIR=~/ref ./devtools/test-meson-builds.sh which doesn't give any warnings about the ABI break. I've cloned the dpdk repo in "~/ref" and checkout v21.05 tag. "~/dpdk" is on a local branch that contains my changes: "./devtools/check-abi.sh ~/ref ~/dpdk" - didn't work. I've then used gen-abi.sh (with a small change to skip the *.symbols, since abidw can't handle them) to generate the *.dump files. Reruning check-abi.sh worked this time, but didn't show the ABI break. This is the entire output: ------ WARNING: could not identify an include directory for /home/administrator/ref, expect false positives... WARNING: could not identify an include directory for /home/administrator/dpdk, expect false positives... Functions changes summary: 0 Removed, 0 Changed, 0 Added function Variables changes summary: 0 Removed, 0 Changed, 0 Added variable Variable symbols changes summary: 0 Removed, 0 Added variable symbol not referenced by debug info ------ I've also tried to compare each file: abidiff --suppr ./devtools/libabigail.abignore --no-added-syms ~/ref/dump/librte_eal.dump ~/dpdk/dump/librte_eal.dump