From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 720B2A0C46; Wed, 9 Jun 2021 17:52:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53D53410FD; Wed, 9 Jun 2021 17:52:23 +0200 (CEST) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by mails.dpdk.org (Postfix) with ESMTP id AE28C410F6; Wed, 9 Jun 2021 17:52:21 +0200 (CEST) Received: by mail-lf1-f50.google.com with SMTP id r198so35441268lff.11; Wed, 09 Jun 2021 08:52:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VMFeAy7KMxaLSe0XYkZ73MJvdtfyCUEubyAsYE0i4vE=; b=htNsIrMyaGWEbKuSnWs3LBm7zZDIvMzR7L0qvkyQBIXivyZ+0ovRWadr5xWfsUpMRb t/ZzVVsrkA4aCFYLjorYiIbqtxOQZGqSmj9foRrur1ZPY09kM7m5ci0NXJI0e0pigOu/ Ti0zfGCngDI0/fArHFwiE+aB5I73DE2rxyN+9kQ5UjTlAQ+fusJ96KcpBlkmRtPac5DU TGZMODK9v0ezkFqTbSIi/VF582kGaYpGdH0/QfALG7mKj55JOUuATFep37jLyDovhzci RCJy64rEqvMmNoYdUlSK9yj77ahH66YA6f2s6hybJnLDrd+chS4jCQWosnKJJZ9sN045 T8DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VMFeAy7KMxaLSe0XYkZ73MJvdtfyCUEubyAsYE0i4vE=; b=Ev6x+mlDfckJI717F1jUEHctniORvzXkZ3TXEs/WWkE7GrPoDCzVJ4mDe5Z2fMYiBX e/61oPoQNDTFul9MLnqkKALSr97LEUeyDV45tdCVoZ27AFAgnEjrjhyAd0vDd8kcBucA QSNLg8UtPVDBYU0+XSXkNFA+yXXwlNFYtVwgmVD9P89RwVh6MeP1jwCCJdsQkNf9btnJ q919fn7+udYVNJCUCy4/aRWPKW5y4LGivhFHYegRoI6up5oFIeCOW1DFm3WKwB+uJbTT V2cbcvyB/hLC5GTJklG4hWpCztYrUZcU5WTSh+JsIbUQP7e9cnJD2tmxSbZDMfUDaU8H 351A== X-Gm-Message-State: AOAM530loCK9hqGt19snflmIuVsOphNoSp6PyeHR/1NoIQTzR8rIyN7D WhUgUIbc5ovkW2QIrjI1P2ZJbyUyGvxabWED X-Google-Smtp-Source: ABdhPJxR1EM+91oeF1dEf2kjK0w6pPONsBJpfaBv64p4cr1LafspBN/u+TWv/20fLhzQdyCGoTeiBA== X-Received: by 2002:a05:6512:2186:: with SMTP id b6mr128756lft.490.1623253941083; Wed, 09 Jun 2021 08:52:21 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id l3sm22449lfe.230.2021.06.09.08.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 08:52:20 -0700 (PDT) Date: Wed, 9 Jun 2021 18:52:19 +0300 From: Dmitry Kozlyuk To: dev@dpdk.org Cc: Zhihong Peng , Neil Horman , ci@dpdk.org Message-ID: <20210609185219.5eefdddd@sovereign> In-Reply-To: <20210527212421.24224-1-dmitry.kozliuk@gmail.com> References: <20210526214343.31352-1-dmitry.kozliuk@gmail.com> <20210527212421.24224-1-dmitry.kozliuk@gmail.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] pmdinfogen: allow padding after NUL terminator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-05-28 00:24 (UTC+0300), Dmitry Kozlyuk: > Size of string constant symbol may be larger than its length > measured up to NUL terminator. In this case pmdinfogen included padding > bytes after NUL terminator in generated source, yielding incorrect code. > > Always trim string data to NUL terminator while reading ELF. > It was already done for COFF because there's no symbol size. > > Bugzilla ID: 720 > Fixes: f0f93a7adfee ("buildtools: use Python pmdinfogen") > > Signed-off-by: Dmitry Kozlyuk > --- > v2: return helper to coff.py, where it's needed (David Marchand). > > buildtools/pmdinfogen.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/buildtools/pmdinfogen.py b/buildtools/pmdinfogen.py > index 7a739ec7d4..2a44f17bda 100755 > --- a/buildtools/pmdinfogen.py > +++ b/buildtools/pmdinfogen.py > @@ -28,7 +28,7 @@ def __init__(self, image, symbol): > def string_value(self): > size = self._symbol["st_size"] > value = self.get_value(0, size) > - return value[:-1].decode() if value else "" > + return coff.decode_asciiz(value) # not COFF-specific > > def get_value(self, offset, size): > section = self._symbol["st_shndx"] There are CI failures that seem unrelated to this patch: some tests with NICs that I can't check and an Arch Linux build failure that I failed to reproduce. GitHub Actions are passing. Are these known CI bugs or does this patch need any corrections?