From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4763A0C51; Thu, 10 Jun 2021 09:51:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CE374067C; Thu, 10 Jun 2021 09:51:13 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 021C74003C for ; Thu, 10 Jun 2021 09:51:11 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id f30so1738272lfj.1 for ; Thu, 10 Jun 2021 00:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=glh0SZP6ym5cdjQL5n0oiIfa3xNwJem3RADnWDPBi4Y=; b=tarqg9niliO7VhrquELSruiesw0oSIWrGuuL0vkduO/BD38QunISVSZuMfpm2oe9Om unztfgeJ6/n5/68ui+qVFz4HlqM/ZyDtNQrX/yRi8E3rjjF9a7b1WfgXceLOKtmMDpFy LJvFoViAMVGeYhx6tc6CY/DJfI576RTolwHt5TsasZbKdjxG7jScPsuEn2YQo0UAeKpz /exLLmRoXOOXgt5KoXTjLoWLqmFrYPOx8TxZlceNJYRyndxwLbW0zjb38jTF8kV0qckv pe82aJV2p8tTWu+3F1Erue+qDG/vtwF+OAgxGo8uqpVLz7/wEE5n1OSGkZCOIpc+V8fw HZ7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=glh0SZP6ym5cdjQL5n0oiIfa3xNwJem3RADnWDPBi4Y=; b=tta7QH0IQc61c/sQH2miaeHacMC9qMa8OxarsFJUSIc6D0hAHx6NOXHb221YlivhX/ FnOK6q8Sj3vjoBOsZsm6C/uj+yP7l6TgCvt0Tjf/PIV6rZAezqPBdQZHZ36pARFk0ki8 9AqSDAEGFM/XZt6H1oOIEt12SylcAdw2XJbn+d8ASTw9ukQ5nu6NrLCxTzPZ5hJ+Povl 6VEuU5EK1b6SezT6nP+wrgCQIXJ/lSSLtiQdq93O0CDXBHGiPUZ+LANEgNN4yq6F07of 6zUAFk9gloJJKrBEX4JP2Jj0Mzw6i/EPXk4Y7GLnO/Aedlgzha6W9O1vh6j0Utp9KLxn 9JFw== X-Gm-Message-State: AOAM532ulKYn42RVMs6qV87UmQyHeA0w9piyVJ68HdM9dWcRRK8U0iBK Lo0wgpqUP3mg92PpG3pt5gi69A== X-Google-Smtp-Source: ABdhPJxWrI60MAroFngmC0JaNKLQDbzEcUGaTNc41m1lvThczDvYXimOsNxF//+SKmmw/ESV9fqk5g== X-Received: by 2002:ac2:4542:: with SMTP id j2mr1076127lfm.435.1623311471358; Thu, 10 Jun 2021 00:51:11 -0700 (PDT) Received: from toster (89-73-146-138.dynamic.chello.pl. [89.73.146.138]) by smtp.gmail.com with ESMTPSA id 138sm246170ljf.71.2021.06.10.00.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 00:51:11 -0700 (PDT) Date: Thu, 10 Jun 2021 09:51:09 +0200 From: Stanislaw Kardach To: Anatoly Burakov Cc: dev@dpdk.org, upstream@semihalf.com Message-ID: <20210610075109.6mcody2zaer3gdi2@toster> References: <20210604141601.275430-1-kda@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604141601.275430-1-kda@semihalf.com> Subject: Re: [dpdk-dev] [PATCH v2 0/3] Increase test compatibility with PA IOVA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 04, 2021 at 04:15:58PM +0200, Stanislaw Kardach wrote: > Please let me know if I'm missing a bigger picture with the --no-huge > and --no-shconf usage on non-FreeBSD platforms. > After looking at this issue again I'm abandoning this patchset because it seems wrong for 2 reasons: 1. --iova-mode=pa and --no-huge combination is still unsupported but detecting such situation is not straightforward in the eal_flags_no_huge_autotest. That is because it is not only a product of user input but IOMMU requirements (if any), bus requirements and PA map availability. If a PCI device is bound to UIO and no IOMMU is avilable, then bus requests PA mapping. However if there's no UIO device, PCI reports DC and therefore decision relies on PA map availability. If it's not available, VA will be chosen. This changes between the parent dpdk-test binary being run (available->PA) and the child processes being spawned by the test (not-available->VA). However rte_eal_iova_mode() only reports the final IOVA mode. Even if in the parent process it is PA, it doesn't mean it will be so in the child process. So test will be skipped when it shouldn't. 2. Because of the above, the same test can pass on a non-IOMMU platform if no PCI device is bound to UIO while it would fail if there is a PCI device bound to UIO. It seems that the silent assumption is that fast-tests should be run without any UIO devices (or basically with all buses requestin DC IOVA mode). Sorry for any confusion with this patchset. -- Best Regards, Stanislaw Kardach