From: Ruifeng Wang <ruifeng.wang@arm.com>
To: viktorin@rehivetech.com, jerinj@marvell.com, bruce.richardson@intel.com
Cc: dev@dpdk.org, nd@arm.com, J.Grant@qub.ac.uk,
david.marchand@redhat.com, thomas@monjalon.net,
Ruifeng Wang <ruifeng.wang@arm.com>,
James Grant <j.grant@qub.ac.uk>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Subject: [dpdk-dev] [PATCH v2] eal/arm: remove irrelevant code
Date: Fri, 11 Jun 2021 14:42:18 +0000 [thread overview]
Message-ID: <20210611144219.322428-1-ruifeng.wang@arm.com> (raw)
In-Reply-To: <20210604054851.425452-1-ruifeng.wang@arm.com>
Data types Elf32_auxv_t and Elf64_auxv_t are used by OS Linux
auxiliary vector read, and not used by arch specific cpu flag
API implementations. Hence remove them from Arm file.
Reported-by: James Grant <j.grant@qub.ac.uk>
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
v2:
Update commit message to remove implication of FreeBSD support.
lib/eal/arm/rte_cpuflags.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/eal/arm/rte_cpuflags.c b/lib/eal/arm/rte_cpuflags.c
index 845770f1e5..d84c9fc09f 100644
--- a/lib/eal/arm/rte_cpuflags.c
+++ b/lib/eal/arm/rte_cpuflags.c
@@ -48,7 +48,6 @@ struct feature_entry {
#ifdef RTE_ARCH_ARMv7
#define PLATFORM_STR "v7l"
-typedef Elf32_auxv_t _Elfx_auxv_t;
const struct feature_entry rte_cpu_feature_table[] = {
FEAT_DEF(SWP, REG_HWCAP, 0)
@@ -83,7 +82,6 @@ const struct feature_entry rte_cpu_feature_table[] = {
#elif defined RTE_ARCH_ARM64
#define PLATFORM_STR "aarch64"
-typedef Elf64_auxv_t _Elfx_auxv_t;
const struct feature_entry rte_cpu_feature_table[] = {
FEAT_DEF(FP, REG_HWCAP, 0)
--
2.25.1
next prev parent reply other threads:[~2021-06-11 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 5:48 [dpdk-dev] [PATCH] eal/arm: enable FreeBSD build Ruifeng Wang
2021-06-04 9:32 ` James Grant
2021-06-11 8:58 ` David Marchand
2021-06-11 10:49 ` Ruifeng Wang
2021-06-11 14:42 ` Ruifeng Wang [this message]
2021-07-05 7:54 ` [dpdk-dev] [PATCH v2] eal/arm: remove irrelevant code David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611144219.322428-1-ruifeng.wang@arm.com \
--to=ruifeng.wang@arm.com \
--cc=J.Grant@qub.ac.uk \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).