DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>,
	<andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v2] net/hns3: support Tx push quick doorbell to improve perf
Date: Mon, 14 Jun 2021 19:36:40 -0700	[thread overview]
Message-ID: <20210614193640.03da7078@hermes.local> (raw)
In-Reply-To: <1623720869-26320-1-git-send-email-humin29@huawei.com>

On Tue, 15 Jun 2021 09:34:29 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:

> +	return (void *)((char *)pci_dev->mem_resource[bar_id].addr +
> +			(pci_dev->mem_resource[bar_id].len >> 1) +
> +			HNS3_TX_PUSH_TQP_REGION_SIZE * queue_id +
> +			HNS3_TX_PUSH_QUICK_DOORBELL_OFFSET);

Minor nit: cast here (in C) is unnecessary. C will automatically
cast the return any pointer type to void *

  reply	other threads:[~2021-06-15  2:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-13  1:42 [dpdk-dev] [PATCH] " Min Hu (Connor)
2021-06-13  1:42 ` Min Hu (Connor)
2021-06-14 14:35   ` Andrew Rybchenko
2021-06-15  1:35     ` Min Hu (Connor)
2021-06-15  1:34   ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-06-15  2:36     ` Stephen Hemminger [this message]
2021-06-15  2:37     ` Stephen Hemminger
2021-06-15  3:46       ` Min Hu (Connor)
2021-06-17 15:18     ` Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210614193640.03da7078@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=humin29@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).