From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C46C9A0C4A; Tue, 15 Jun 2021 04:36:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44C4D4067A; Tue, 15 Jun 2021 04:36:51 +0200 (CEST) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id EAB3840140 for ; Tue, 15 Jun 2021 04:36:49 +0200 (CEST) Received: by mail-pg1-f175.google.com with SMTP id w31so7727326pga.6 for ; Mon, 14 Jun 2021 19:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jzgrk5tN38pCQ5oJtJJCcqnwO+Jut6kiRTfe2GtNtFE=; b=fTU1UkFfpOYQcwnDSDJK7jvDLdbRW5O3Pxzq9O3rG1Pfqspq33oR4vG5+GdfUh/yXo jjSLdL5PBU8JD2wJmVHfH0CV0+LyB5Mjh2RgWHMvOfrdgoowRgr4F+9E71c+kxe8L2aJ i5pD7MpvSzqhGTyNxReHjrUCyRQg5RoIGbJYBSF+GP6gtM5zrMEAhdtVC/2a52lqKjPY pN4BcToBEUAfO67YBq6aoTRvDaLq2grRujA1PS8Iw5mRHbQtkfPkxdWxc1TtX1xoDkK/ E5BMoDip9qqXnOS3nyhioD3fdJrAYLoCDr3D5TXycdEk99OuTC17PwLZmszbeqj37sGB xLNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jzgrk5tN38pCQ5oJtJJCcqnwO+Jut6kiRTfe2GtNtFE=; b=BrPbMji3+pMAlXJBZpcgfrYd+ocXSQha/GNRd520iTSsOspaKrgdEI3zKm+GMOMXyI HgQTYpokCNEd1Embh16LwOjR17O7o6jrvLN3NPCWZd4qHln3ViQ2SkdW9gbQxejp7Q/g 9TrGMYs75OxJu+VwumkfkvdueVMI8LHoN2vbpcfhqwYrJ2Hp5eYcNVdukSrSn9V4JpDG /n871s9VRoWKXdxpkmm4GDS2121mIB9Ldv2FmhptGmS0f+bYT/KYSWn0DvddCoyLD2hQ n6v5fPu25l9gib6L+eBmmwfOrSnU/NG/BCv6floUMIBLTliDiQLH6wBPovtIJ/6avU0X z0gw== X-Gm-Message-State: AOAM531SfgP+85iZzfuzz8svl7NlNLyASF/AJ1/f7XnbHW3OR2ao4pJp HGBVmuV4oOwcV1fFuGxP/kxFlQ== X-Google-Smtp-Source: ABdhPJyCAmuE+li2ejPw3WKNzrpw5TaFky8ZlgGNxxNNR6dnOZY/nbYN3BZDeRyJYSpOngdAz9zczg== X-Received: by 2002:a63:6644:: with SMTP id a65mr19835359pgc.431.1623724608951; Mon, 14 Jun 2021 19:36:48 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id x22sm13419715pjp.37.2021.06.14.19.36.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 19:36:48 -0700 (PDT) Date: Mon, 14 Jun 2021 19:36:40 -0700 From: Stephen Hemminger To: "Min Hu (Connor)" Cc: , , Message-ID: <20210614193640.03da7078@hermes.local> In-Reply-To: <1623720869-26320-1-git-send-email-humin29@huawei.com> References: <1623548576-34995-2-git-send-email-humin29@huawei.com> <1623720869-26320-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/hns3: support Tx push quick doorbell to improve perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 15 Jun 2021 09:34:29 +0800 "Min Hu (Connor)" wrote: > + return (void *)((char *)pci_dev->mem_resource[bar_id].addr + > + (pci_dev->mem_resource[bar_id].len >> 1) + > + HNS3_TX_PUSH_TQP_REGION_SIZE * queue_id + > + HNS3_TX_PUSH_QUICK_DOORBELL_OFFSET); Minor nit: cast here (in C) is unnecessary. C will automatically cast the return any pointer type to void *