From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
To: <dev@dpdk.org>
Cc: Xueming Li <xuemingl@nvidia.com>, <stable@dpdk.org>,
Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Guy Tzalik <gtzalik@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Igor Chauskin <igorch@amazon.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Long Li <longli@microsoft.com>,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: [dpdk-dev] [PATCH] bus: clarify log for non-NUMA-aware devices
Date: Tue, 15 Jun 2021 13:51:55 +0300 [thread overview]
Message-ID: <20210615105156.760308-1-dkozlyuk@nvidia.com> (raw)
PCI and vmbus drivers printed a warning
when NUMA node had beed reported as (-1) or not reported by OS:
EAL: Invalid NUMA socket, default to 0
This message and its level might confuse users, because configuration
is valid and nothing happens that requires attention or intervention.
Reduce level to INFO and reword the message.
Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe")
Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
Cc: stable@dpdk.org
Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Reviewed-by: Slava Ovsiienko <viacheslavo@nvidia.com>
---
Hi Xueming,
Please align logging in the pending bus/auxiliary patch.
doc/guides/nics/ena.rst | 2 +-
drivers/bus/pci/pci_common.c | 2 +-
drivers/bus/vmbus/vmbus_common.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst
index 0f1f63f722..694ce1da74 100644
--- a/doc/guides/nics/ena.rst
+++ b/doc/guides/nics/ena.rst
@@ -234,7 +234,7 @@ Example output:
[...]
EAL: PCI device 0000:00:06.0 on NUMA socket -1
- EAL: Invalid NUMA socket, default to 0
+ EAL: Device is not NUMA-aware, defaulting socket to 0
EAL: probe driver: 1d0f:ec20 net_ena
Interactive-mode selected
diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 35d7d092d1..bf06f81229 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -190,7 +190,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
}
if (dev->device.numa_node < 0) {
- RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n");
+ RTE_LOG(INFO, EAL, " Device is not NUMA-aware, defaulting socket to 0\n");
dev->device.numa_node = 0;
}
diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c
index d25fd14ef5..ef23af90ec 100644
--- a/drivers/bus/vmbus/vmbus_common.c
+++ b/drivers/bus/vmbus/vmbus_common.c
@@ -112,7 +112,7 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr,
dev->driver = dr;
if (dev->device.numa_node < 0) {
- VMBUS_LOG(WARNING, " Invalid NUMA socket, default to 0");
+ VMBUS_LOG(INFO, " Device is not NUMA-aware, defaulting socket to 0\n");
dev->device.numa_node = 0;
}
--
2.18.2
next reply other threads:[~2021-06-15 10:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 10:51 Dmitry Kozlyuk [this message]
2021-06-15 15:12 ` Stephen Hemminger
2021-06-16 10:07 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2021-07-23 20:07 ` Andrew Rybchenko
2021-07-27 8:08 ` Dmitry Kozlyuk
2021-07-27 10:27 ` [dpdk-dev] [PATCH v3] " Dmitry Kozlyuk
2021-07-28 22:06 ` [dpdk-dev] [PATCH v4] " Dmitry Kozlyuk
2021-07-29 7:45 ` Andrew Rybchenko
2021-07-30 16:18 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-08-04 8:03 ` [dpdk-dev] [PATCH v5] " Dmitry Kozlyuk
2021-08-04 9:34 ` Thomas Monjalon
[not found] <20210615104409.759899-1-dkozlyuk@nvidia.com>
2021-06-15 11:08 ` [dpdk-dev] [PATCH] " Xueming(Steven) Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615105156.760308-1-dkozlyuk@nvidia.com \
--to=dkozlyuk@nvidia.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=longli@microsoft.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=stable@dpdk.org \
--cc=sthemmin@microsoft.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).