From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95768A0C47; Tue, 15 Jun 2021 12:52:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BFA44067A; Tue, 15 Jun 2021 12:52:17 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2067.outbound.protection.outlook.com [40.107.243.67]) by mails.dpdk.org (Postfix) with ESMTP id 2D67B40140; Tue, 15 Jun 2021 12:52:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fVMIBvIZdFF4MQ6PQ/piABVBfUIHahPCBwAZL5RCCAuPj5KxrM8vBVXmEDErmGiCR2XovuRW4544xaIs9I4ut13x4MWU7o5XO6ObkUG6DMDD4ryH4p6onOGhAEWA4qWASOdg4msa7YMidXAjWd+2But6FB/yiKXbtfkzmj281UO2iCqAcgk1Dk/mvqsZZScX/GedkbXlCVW41kAsFb6f5wWGUOw4IABtnRcP9HmFLUnYlPzy/2iqumOBXyaocKezkOkZX9YY6LKYAOXafG0OOmkG6AGPe94/fK0ZZVrP+G1XwdnIpHz/CK1WeY11Z98NekYAWXqoHDCzQGbhaj+yMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OJZEWBPaaCVRzcdUquqwmke9nw2YptZ4TqwjDmHnxdo=; b=c6u/3X6WkHdAwDbYnBffIj1APHhh9Y0frxGRrWgtnMDmR3gAYLdEhpVjVJgFdsqP2VLxKuuZ535LHxg8vmyrEModZ+25RbglTR4korQbLHeYLMPZLTVteGhy0lf4r9E+OkntSgl+E+cjustnwdym0bNO44s/M+xIg2+gdgAnxnWpZY2Z7qE5MCDMKiLyNfViYGDAdZD2MkND3PQ37SFzQk2SkzbL5+v4RJVF3Y2StUOaGEIjx2qsk2tYsW+MUlxPTZPnYLJV8BK7Zh2pV//9xCHFiQS6cYgS5izxm5VeSESITNtAod3QaWllskACoX7g3EUxBR+YziDbeUMhyc4HqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=amazon.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OJZEWBPaaCVRzcdUquqwmke9nw2YptZ4TqwjDmHnxdo=; b=ig2XiZvp4TBBpsM2qpQKdC+IOD3gCJhr+VTQn3ppBc4Lw9IuXcgFrlyv50g7vGN7OpWm06vXsQYAgJRNYLumoisrIxbc+8+VL1mq6hlzT5A72zEp+LixLZ9u3guBHXQjkOzO1r/aVeCPP/OjMB8rL5rwknTczEVmskZuxK3EyHe9WbjP0uU+zV2ilOKrs23aVKGzzoc83+ihGc8g8fZLzi9YcI6kohsA8fcghc1UypzvItbtz0Heqo3ck8LcCA7422By0ODfHJf5NC4u5uQYkvlHd+8CJ1DvI8G+CgteKlRDdQ8LJJPW0f3fpLkeughlr7/htkzowL8iX6XfaXh7qQ== Received: from MWHPR18CA0045.namprd18.prod.outlook.com (2603:10b6:320:31::31) by CO6PR12MB5476.namprd12.prod.outlook.com (2603:10b6:303:138::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.15; Tue, 15 Jun 2021 10:52:14 +0000 Received: from CO1NAM11FT050.eop-nam11.prod.protection.outlook.com (2603:10b6:320:31:cafe::2d) by MWHPR18CA0045.outlook.office365.com (2603:10b6:320:31::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Tue, 15 Jun 2021 10:52:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; amazon.com; dkim=none (message not signed) header.d=none;amazon.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT050.mail.protection.outlook.com (10.13.174.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Tue, 15 Jun 2021 10:52:14 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Jun 2021 10:52:11 +0000 From: Dmitry Kozlyuk To: CC: Xueming Li , , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Stephen Hemminger , Long Li , Sergio Gonzalez Monroy Date: Tue, 15 Jun 2021 13:51:55 +0300 Message-ID: <20210615105156.760308-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 57b28cd5-bb27-4a23-5df1-08d92feba2f1 X-MS-TrafficTypeDiagnostic: CO6PR12MB5476: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ACQNNc6ywVzlNKUlvJe3Ih8dEGvTHxL54ChTqdRThqCBGHsk1xUbjclPUqNhNv6+z+rqSME/kvF5spdqhMNUqdfvfuq6k3Dyrvo3KS8lwpMWmQZvOS0wPD+mlK5e+Iyljh5sSqodfcIj5f0dmcyZ+E1gZtzbiNZjOoXtXE8gsn770+hxMDD9HPa7RbU4nQtNT7cTANiCaAsCvSQmRdZe1RYzziF6CMN7TrDcaFvpS4nt2+u9c45HgYVwzYFw2CXee8le3r4N2H0PsN12RqCQ7QbalpeTSvi1P65YRfYop1MwM/ijCPN2e0kxZDocSe5W3rtJ3NBMAQxmhMielABu1HOUO4VuBlk2dQr7BUtCmykIfL0xktnySwK2K28f3cu2kwAdWW5E+PGoN3jN0Due1jW6LKWka529kwO/TP9VG5npNhKxocvMKRkAPuFxlcvrB4+l1ereADE+ohGqCHRaFT190AQMtgyZl4m91kw+4+m7FiRQ30jQpJXeDW9AmMGK06OfDFWy7JjDEh7PhMYmFuMArR3ZU2edOjT27lM+LqV4PPInBw8zjUxmKvwIvq03uBaLd1J2ueNvjc4LX2Z3KM4jNf6aoTF0bwcav6gZtz9iegetDwswz2opuP3BVEKutm2G9Mztwn8eGtwLCkthwg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(346002)(39860400002)(36840700001)(46966006)(70586007)(8676002)(83380400001)(16526019)(82310400003)(82740400003)(70206006)(7416002)(336012)(2616005)(4326008)(8936002)(7696005)(2906002)(6916009)(86362001)(6666004)(6286002)(36860700001)(426003)(316002)(36906005)(5660300002)(1076003)(26005)(55016002)(36756003)(7636003)(356005)(478600001)(54906003)(47076005)(186003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2021 10:52:14.6043 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 57b28cd5-bb27-4a23-5df1-08d92feba2f1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT050.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5476 Subject: [dpdk-dev] [PATCH] bus: clarify log for non-NUMA-aware devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" PCI and vmbus drivers printed a warning when NUMA node had beed reported as (-1) or not reported by OS: EAL: Invalid NUMA socket, default to 0 This message and its level might confuse users, because configuration is valid and nothing happens that requires attention or intervention. Reduce level to INFO and reword the message. Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe") Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Cc: stable@dpdk.org Signed-off-by: Dmitry Kozlyuk Reviewed-by: Slava Ovsiienko --- Hi Xueming, Please align logging in the pending bus/auxiliary patch. doc/guides/nics/ena.rst | 2 +- drivers/bus/pci/pci_common.c | 2 +- drivers/bus/vmbus/vmbus_common.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst index 0f1f63f722..694ce1da74 100644 --- a/doc/guides/nics/ena.rst +++ b/doc/guides/nics/ena.rst @@ -234,7 +234,7 @@ Example output: [...] EAL: PCI device 0000:00:06.0 on NUMA socket -1 - EAL: Invalid NUMA socket, default to 0 + EAL: Device is not NUMA-aware, defaulting socket to 0 EAL: probe driver: 1d0f:ec20 net_ena Interactive-mode selected diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 35d7d092d1..bf06f81229 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -190,7 +190,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, } if (dev->device.numa_node < 0) { - RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n"); + RTE_LOG(INFO, EAL, " Device is not NUMA-aware, defaulting socket to 0\n"); dev->device.numa_node = 0; } diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index d25fd14ef5..ef23af90ec 100644 --- a/drivers/bus/vmbus/vmbus_common.c +++ b/drivers/bus/vmbus/vmbus_common.c @@ -112,7 +112,7 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr, dev->driver = dr; if (dev->device.numa_node < 0) { - VMBUS_LOG(WARNING, " Invalid NUMA socket, default to 0"); + VMBUS_LOG(INFO, " Device is not NUMA-aware, defaulting socket to 0\n"); dev->device.numa_node = 0; } -- 2.18.2