[dpdk-dev] [PATCH] devtools: fix file listing in maintainers check

[dpdk-dev] [PATCH] devtools: fix file listing in maintainers check

[Thomas Monjalon]

When having multiple working trees, the main one has a .git directory
while attached trees have a .git file.
Thus the git check should work for both file and directory.

In the case there is no working tree (.git not readable), the command
"find" is used and should be able to list paths with wildcards.
Wildcards work only as shell expansion in the case of file paths,
so the quotes must be removed.

Fixes: 27c2ce563216 ("maintainers: start a Linux-style file")
Cc: stable@dpdk.org

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 devtools/check-maintainers.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/devtools/check-maintainers.sh b/devtools/check-maintainers.sh
index df3f740b6e..71697bb352 100755
--- a/devtools/check-maintainers.sh
+++ b/devtools/check-maintainers.sh
@@ -15,10 +15,10 @@ files () # <path> [<path> ...]
 	if [ -z "$1" ] ; then
 		return
 	fi
-	if [ -d .git ] ; then
+	if [ -r .git ] ; then
 		git ls-files "$1"
 	else
-		find "$1" -type f |
+		find $1 -type f |
 		sed 's,^\./,,'
 	fi |
 	# if not ended by /
-- 
2.31.1

Re: [dpdk-dev] [PATCH] devtools: fix file listing in maintainers check

[Thomas Monjalon]

15/06/2021 14:49, Thomas Monjalon:
> When having multiple working trees, the main one has a .git directory
> while attached trees have a .git file.
> Thus the git check should work for both file and directory.
> 
> In the case there is no working tree (.git not readable), the command
> "find" is used and should be able to list paths with wildcards.
> Wildcards work only as shell expansion in the case of file paths,
> so the quotes must be removed.
> 
> Fixes: 27c2ce563216 ("maintainers: start a Linux-style file")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Applied