From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0845DA0C45; Wed, 16 Jun 2021 06:15:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E26A410E3; Wed, 16 Jun 2021 06:15:40 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id BFEF74003C for ; Wed, 16 Jun 2021 06:15:38 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id c12so1145078pfl.3 for ; Tue, 15 Jun 2021 21:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nCpFRTJ3FfnTEUSg7kIVflKwr8EjvftcUGbEJOUUioA=; b=H4xlS/b4pwVBBDEXdrznjRCX7IgMPb2oOgG8AXjgh69buVUnutswGhl7ArB3/rvcF4 6z4Ikgqn7lSYn2ksil4MSvCUPK9BmkK1gzPbxBAkfkdB0bzRd+v0RYt8B+BJ3bpOkuB6 cGWChU+lY+nAbhJ5Hk+hXOY1HHMMd239ju8vHyPwcxqKd53pKdTV8dJJ3YZTwECylr7F 2RmZfIX+9hJQ1uYUu22zH2JzcFFDyXE5kU/HmWyV2IpogJVvr0DLLOf2aN+MspUYPyDW QQEzB4c6PD6xg54sD7gRjfIlPBOOTlt9lRuRmj27KaOO02bj65lkbOIxxH27ZPqXBcuv D+hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nCpFRTJ3FfnTEUSg7kIVflKwr8EjvftcUGbEJOUUioA=; b=oZ5cQ9FNMIjUb8BX4PeofRgyM7dZSu7WFRIegM3vgVhAcGS9hhrZ+OBx0G21bdIwc3 Nu6XFqQuq8SozAW6nFg4h7QXedVt24bG3O/vWG69pHs5T9OVQhxwlzB2ziPDI5gVOFU7 I8Td8JJ9aOKZ8pC8EeLvES8TK6ZRXFCYo3SgD15u6cpZMI6ysYONwijb5bsmn5MD2pFZ qCE6qoRisAXYrWYDEaQdukn+md615g+cllpG2X5/p3KCgSt5dZgeOLo9sbXDzEyWaH97 HDQqm9vV2jKuC/KiY/W3RxsPBAH3wbBMZR1yL/YfX//hhansB0ZPvRCj6DVpcTScBV0R EuHQ== X-Gm-Message-State: AOAM531GkEhNztAVyV7dSL+rFD8dpea0OuvnPCAEyTwtkefJudo9wPCV A5TmA0RcUwLfultpVyEkx5UHOQ== X-Google-Smtp-Source: ABdhPJwB3w22KH2rVC30QoF7NiNVzDC7NIoIZoKN6vF6wwhcA4Ycn9yQMbfN9YQjgqJLj8TPy9xYuw== X-Received: by 2002:a63:ef04:: with SMTP id u4mr2884344pgh.429.1623816937952; Tue, 15 Jun 2021 21:15:37 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id 21sm568749pfh.103.2021.06.15.21.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 21:15:37 -0700 (PDT) From: Stephen Hemminger To: Keith Wiles Cc: dev@dpdk.org, Stephen Hemminger Date: Tue, 15 Jun 2021 21:15:27 -0700 Message-Id: <20210616041528.4229-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210616041528.4229-1-stephen@networkplumber.org> References: <20210616041528.4229-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since these always return 0, they were doing nothing useful. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 5735988e7c82..aeae6e8f5e93 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -373,15 +373,6 @@ tap_verify_csum(struct rte_mbuf *mbuf) } } -static uint64_t -tap_rx_offload_get_port_capa(void) -{ - /* - * No specific port Rx offload capabilities. - */ - return 0; -} - static uint64_t tap_rx_offload_get_queue_capa(void) { @@ -506,15 +497,6 @@ pmd_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) return num_rx; } -static uint64_t -tap_tx_offload_get_port_capa(void) -{ - /* - * No specific port Tx offload capabilities. - */ - return 0; -} - static uint64_t tap_tx_offload_get_queue_capa(void) { @@ -1016,11 +998,9 @@ tap_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->min_rx_bufsize = 0; dev_info->speed_capa = tap_dev_speed_capa(); dev_info->rx_queue_offload_capa = tap_rx_offload_get_queue_capa(); - dev_info->rx_offload_capa = tap_rx_offload_get_port_capa() | - dev_info->rx_queue_offload_capa; + dev_info->rx_offload_capa = dev_info->rx_queue_offload_capa; dev_info->tx_queue_offload_capa = tap_tx_offload_get_queue_capa(); - dev_info->tx_offload_capa = tap_tx_offload_get_port_capa() | - dev_info->tx_queue_offload_capa; + dev_info->tx_offload_capa = dev_info->tx_queue_offload_capa; dev_info->hash_key_size = TAP_RSS_HASH_KEY_SIZE; /* * limitation: TAP supports all of IP, UDP and TCP hash -- 2.30.2