From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B477A0C49; Wed, 16 Jun 2021 12:07:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84B264067A; Wed, 16 Jun 2021 12:07:29 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060.outbound.protection.outlook.com [40.107.223.60]) by mails.dpdk.org (Postfix) with ESMTP id 11FB040140; Wed, 16 Jun 2021 12:07:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lDsD4IjeXdh6afsid1EO1FnLdnhNKlWPFoXfp7O+oLP1Ffli4J2Nu3k2SgDJV30eeqBCQuM8QHeLFZiDgJYwW6X1Vn88mzQvH5ysrgcApdtcut62N3SZPWYWulsE2CSLBPQy0a2JHUXnMwKNHwJA6ROM63zqyV1+6pinyTnH78ErRASnqVcZf66K65pG/dCo7Nhl3VPmEViiod6LCniiztOEmMjIEi5YTRqjDXILbAJLuJ2D8wxSEeFDqJPsK0ocJjcr18e5ZsWMcyFjELE7ql79QlNGwuJFxT/mIOr5ajmc6UXat24VWUp/8tS4OyrdwKmIMxbk00gY3OUYDWr4aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZxT7C8Y88Ybiyj960ha/Yk7bUUKvi9De6kcf0+ZoQss=; b=oQNlJr6VNKd38AxVudTngPJIcjNGCET+RPk629epyovSMiuPBLcFg73JmOQNsXXG/+v/2j9HE4leH+5VyA59q5rDs0vo9WP0VUaXoNd9zBsSchz3JTcpAj0OnjGT7wnmOQM6L6gKCUenPbAokJbzB3pk8+VNeklTpwaXOrTcKL6e8Nuu6o4BBZQruZ8sRvEl/tQ4kDFT9l6C5yZUOu6lZSennbvcuHAT8CclpLZonIIEvG1EXcSgAWJRn1RnSz2sSY9ZtC2Dtzia705yrryLBNTu82dMfYv0di0YuxzxlRgyeD3qaSeOGQAV5leMpHkSICEsFD4Cgn6xO0aHi/TuBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZxT7C8Y88Ybiyj960ha/Yk7bUUKvi9De6kcf0+ZoQss=; b=k2WRVSvW/btEj6cnuoCeGBh94WOJNqkfgorJ7JiP3raEGTvQp1H30gM9kaNxCUqe6F9DU/4SMNvq/uGEL73fesa4uyBRyNGUtwVrvFv8TmL25OsK+ulE4D9X4sOocxVpIJDYuGCekKpZox5WLd2kabQe86jma/rMLBFEusZiPexdvtBqJZIP+6FjBUlWyzdzMc+tz/NWYTqF3tFYnIP26sXgXceaNJ+1zGY9bzFWs4jf061gu8s/LXO3Ct4FCzF2CRXEqDs+Og+virBRkxIAXyQ2l5yFrHpJ/Tte98DuHH9Ylp4Xn3JO95JL4GD5hgizNmSstVJkuRhSCU7AZRAsvA== Received: from MW4PR03CA0311.namprd03.prod.outlook.com (2603:10b6:303:dd::16) by SA0PR12MB4432.namprd12.prod.outlook.com (2603:10b6:806:98::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Wed, 16 Jun 2021 10:07:26 +0000 Received: from CO1NAM11FT051.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dd:cafe::ee) by MW4PR03CA0311.outlook.office365.com (2603:10b6:303:dd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.18 via Frontend Transport; Wed, 16 Jun 2021 10:07:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT051.mail.protection.outlook.com (10.13.174.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4242.16 via Frontend Transport; Wed, 16 Jun 2021 10:07:26 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 16 Jun 2021 10:07:25 +0000 From: Dmitry Kozlyuk To: CC: Date: Wed, 16 Jun 2021 13:07:12 +0300 Message-ID: <20210616100712.829035-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20210615105156.760308-1-dkozlyuk@nvidia.com> References: <20210615105156.760308-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 26952d6d-ad87-41cd-88a9-08d930ae8ae8 X-MS-TrafficTypeDiagnostic: SA0PR12MB4432: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S8eBPAt3/1etLS9q/Hq9v/5+7DDbTy1NZ56AQcUTuoLT/Hp5zxtUofId+cIS6en6jklP6vUwTUvSKzXa19FjJtqkN0quN3GJW1Dyqq1MfCU5iHakLCJmftejX9QO7HwwNojjr0+bKXH3N30/mUGTa9muJrz07Vgcg2z+cM+ahjWJLsIbYRKAVAMgT/pY5ZJGJirkIMoxV7f/+qDC9npCrHX/pwztp88wZEwYgad0c+GfgVJ4p3EnL7kAFA8+hlDHiU8wGPw6lUhZqwQ5wMiYvLvMzlt7Q7uqZLiWexg+siS3SQLIgyzTi3FJTx4Ng3dJTrNzcZgKhtEd8DjNwPq2CMStglcXUHNKdNxL1iQjeFRdvsPBOgBuwbvqlO/H4Iw6LUpLYcdna1fs3XoXr+8tyESQ78aUMme+HkFCXTLIM1EBO8SKEHk0ojm+FcA9k3sQws5Ucx25ZOogNoxwOyZbM9RKlJov+BH1wQyNUG01RehuXuWzAfBym/uDzmojYOywRdRpNI0rtAqXE923zJk7kIrjov1/CeXSs6pp/7fBsTkZD0aWerDyw+YRKyxPiSz22tC/Z+qkj9qfYdZV2et907xIayb/K+WwpY4+4hNhj5TDt2RDgZDUVt+kRBPEo0hYIyq7EGiBV2P/slg2sEQCJg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(396003)(376002)(136003)(346002)(36840700001)(46966006)(2616005)(36756003)(55016002)(426003)(5660300002)(70586007)(8676002)(70206006)(6286002)(36906005)(2906002)(336012)(316002)(26005)(7636003)(16526019)(186003)(82740400003)(6666004)(86362001)(82310400003)(8936002)(1076003)(478600001)(83380400001)(36860700001)(6916009)(47076005)(356005)(4326008)(7696005)(450100002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2021 10:07:26.1344 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 26952d6d-ad87-41cd-88a9-08d930ae8ae8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT051.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4432 Subject: [dpdk-dev] [PATCH v2] bus: clarify log for non-NUMA-aware devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" PCI and vmbus drivers printed a warning when NUMA node had beed reported as (-1) or not reported by OS: EAL: Invalid NUMA socket, default to 0 This message and its level might confuse users, because configuration is valid and nothing happens that requires attention or intervention. Reduce level to INFO, reword the message, and suppress it when there is only one NUMA node, bacause NUMA-awareness does not matter in this case. Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe") Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Cc: stable@dpdk.org Signed-off-by: Dmitry Kozlyuk Reviewed-by: Viacheslav Ovsiienko Reviewed-by: Xueming Li --- v2: Add NUMA node count check (Stephen Hemminger). doc/guides/nics/ena.rst | 2 +- drivers/bus/pci/pci_common.c | 4 ++-- drivers/bus/vmbus/vmbus_common.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst index 0f1f63f722..694ce1da74 100644 --- a/doc/guides/nics/ena.rst +++ b/doc/guides/nics/ena.rst @@ -234,7 +234,7 @@ Example output: [...] EAL: PCI device 0000:00:06.0 on NUMA socket -1 - EAL: Invalid NUMA socket, default to 0 + EAL: Device is not NUMA-aware, defaulting socket to 0 EAL: probe driver: 1d0f:ec20 net_ena Interactive-mode selected diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 35d7d092d1..0bb56d9b7f 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -189,8 +189,8 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, return 1; } - if (dev->device.numa_node < 0) { - RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n"); + if (rte_socket_count() > 1 && dev->device.numa_node < 0) { + RTE_LOG(INFO, EAL, " Device is not NUMA-aware, defaulting socket to 0\n"); dev->device.numa_node = 0; } diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index d25fd14ef5..5b654b0289 100644 --- a/drivers/bus/vmbus/vmbus_common.c +++ b/drivers/bus/vmbus/vmbus_common.c @@ -111,8 +111,8 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr, /* reference driver structure */ dev->driver = dr; - if (dev->device.numa_node < 0) { - VMBUS_LOG(WARNING, " Invalid NUMA socket, default to 0"); + if (rte_socket_count() > 1 && dev->device.numa_node < 0) { + VMBUS_LOG(INFO, " Device is not NUMA-aware, defaulting socket to 0\n"); dev->device.numa_node = 0; } -- 2.18.2