From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 586F7A0A0C; Fri, 18 Jun 2021 21:40:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CAA22410DE; Fri, 18 Jun 2021 21:40:47 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id C60AC40150 for ; Fri, 18 Jun 2021 21:40:46 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id bb10-20020a17090b008ab029016eef083425so8329576pjb.5 for ; Fri, 18 Jun 2021 12:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=edGHTOoqET9yAXm/LaMHH1zN+xJwOkVzXI/7XGOyzJI=; b=O5ndA1G78CndhZbHy0PGqt5ROyrsPkiZQ6UwUk2MxILnyhsLceTl1eHOTUX6Ttf6vm 4Rj7v5RJqzvDT86oaz+UMj3a97ScqnemKJtFJe9eaYFqcHf2bJx2MusutXv7T22Raqn8 qHIWW3gwzavf+EhIZSOxmCjmWzTygKwv1/YSlZRKbJOZN4ilgSk2pH5jKRieaLSsWaIw uw/vVIT5V3PTPX7MkPzPebhiAyGyHoTp+jKD16HwlE2eMlBhpZNGZG0o2+ZF5rg8Y1X8 gPRhnsleI3wc8FXzeHyYWBZBqLVimch6Ql72Ydscy8cFZ9V8yoMFFSCnZn/+vzKZ9Gls 3BqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=edGHTOoqET9yAXm/LaMHH1zN+xJwOkVzXI/7XGOyzJI=; b=UrjpD+rI9tNMm7uxBTMBs1oOxUFdr7wVpY+plJaI1jxg+wOnEWPYYBvuFGeBl6C5ej vbaNzrl3mu5meHugW7Xrf9+RaxweQArGL4U9P18BJFWLlMyFgsbjDECoM9wAOAFAo6lt NrMkoh/LZLI/dRSUWIUBkoAH3FFjEWmOkZvSjRHgddth2I28VeLy6smGt7lwWQwgcbD/ cpEc+coKwmbVZxQmRs7w1WRRQQpqZmso/lCUVbMcDa14v7WlNK/aoLt66gm6Jq0JZyt6 5klS3fUAkj3bXwu8Ta0HjLc0CeeWK81E9Xs4/dWq9BbcaWyuNwfyJFzc01dqrc89YSao 15vA== X-Gm-Message-State: AOAM533iXN5rF6p7ooV1wzakZetEjx/O1+HE+RIQ53nAS7IZvXxvuehk uok1wDGf+DaK3TyCFFmwaICsAA== X-Google-Smtp-Source: ABdhPJxbYzdG5bQYa8Z6XEh4Gr7ocBblXGxPVAi4NRKGdYHD2qX9tNBWdEX9PkiNwiseU6pXBOmbrw== X-Received: by 2002:a17:90a:1e82:: with SMTP id x2mr9307446pjx.11.1624045245755; Fri, 18 Jun 2021 12:40:45 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id 33sm6293523pgt.46.2021.06.18.12.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 12:40:45 -0700 (PDT) Date: Fri, 18 Jun 2021 12:40:36 -0700 From: Stephen Hemminger To: Ray Kinsella Cc: dev@dpdk.org, ferruh.yigit@intel.com, thomas@monjalon.net, ktraynor@redhat.com, bruce.richardson@intel.com Message-ID: <20210618124036.206db2bd@hermes.local> In-Reply-To: <20210618163659.85933-1-mdr@ashroe.eu> References: <20210618163659.85933-1-mdr@ashroe.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] devtools: script to track map symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 18 Jun 2021 17:36:59 +0100 Ray Kinsella wrote: > Script to track growth of stable and experimental symbols > over releases since v19.11. > > Signed-off-by: Ray Kinsella pylint reports some things that should be fixed. Don't worry about the naming style and docstring but others should be addressed. ************* Module count_symbols devtools/count_symbols.py:12:0: W0311: Bad indentation. Found 8 spaces, expected 4 (bad-indentation) devtools/count_symbols.py:14:0: W0311: Bad indentation. Found 8 spaces, expected 4 (bad-indentation) devtools/count_symbols.py:16:0: W0311: Bad indentation. Found 8 spaces, expected 4 (bad-indentation) devtools/count_symbols.py:109:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens) devtools/count_symbols.py:230:0: W0311: Bad indentation. Found 8 spaces, expected 4 (bad-indentation) devtools/count_symbols.py:47:41: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string) devtools/count_symbols.py:47:43: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string) devtools/count_symbols.py:1:0: C0114: Missing module docstring (missing-module-docstring) devtools/count_symbols.py:5:0: C0410: Multiple imports on one line (sys, os) (multiple-imports) devtools/count_symbols.py:16:8: R1722: Consider using sys.exit() (consider-using-sys-exit) devtools/count_symbols.py:18:0: C0103: Constant name "symbolMapGrammar" doesn't conform to UPPER_CASE naming style (invalid-name) devtools/count_symbols.py:37:0: C0116: Missing function or method docstring (missing-function-docstring) devtools/count_symbols.py:39:4: C0103: Variable name "s" doesn't conform to snake_case naming style (invalid-name) devtools/count_symbols.py:40:4: C0103: Variable name "s" doesn't conform to snake_case naming style (invalid-name) devtools/count_symbols.py:44:0: C0116: Missing function or method docstring (missing-function-docstring) devtools/count_symbols.py:46:4: C0103: Variable name "s" doesn't conform to snake_case naming style (invalid-name) devtools/count_symbols.py:50:13: W1510: Using subprocess.run without explicitly set `check` is not recommended. (subprocess-run-check) devtools/count_symbols.py:66:0: C0116: Missing function or method docstring (missing-function-docstring) devtools/count_symbols.py:70:0: C0116: Missing function or method docstring (missing-function-docstring) devtools/count_symbols.py:78:0: C0116: Missing function or method docstring (missing-function-docstring) devtools/count_symbols.py:82:13: W1510: Using subprocess.run without explicitly set `check` is not recommended. (subprocess-run-check) devtools/count_symbols.py:91:0: C0116: Missing function or method docstring (missing-function-docstring) devtools/count_symbols.py:94:13: W1510: Using subprocess.run without explicitly set `check` is not recommended. (subprocess-run-check) devtools/count_symbols.py:112:17: W1510: Using subprocess.run without explicitly set `check` is not recommended. (subprocess-run-check) devtools/count_symbols.py:124:0: C0116: Missing function or method docstring (missing-function-docstring) devtools/count_symbols.py:133:0: C0103: Constant name "fmt" doesn't conform to UPPER_CASE naming style (invalid-name) devtools/count_symbols.py:133:6: C0103: Constant name "col_fmt" doesn't conform to UPPER_CASE naming style (invalid-name) devtools/count_symbols.py:135:0: C0116: Missing function or method docstring (missing-function-docstring) devtools/count_symbols.py:136:4: W0603: Using the global statement (global-statement) devtools/count_symbols.py:136:4: C0103: Constant name "fmt" doesn't conform to UPPER_CASE naming style (invalid-name) devtools/count_symbols.py:136:4: C0103: Constant name "col_fmt" doesn't conform to UPPER_CASE naming style (invalid-name) devtools/count_symbols.py:140:8: W0612: Unused variable 'rel' (unused-variable) devtools/count_symbols.py:144:0: C0116: Missing function or method docstring (missing-function-docstring) devtools/count_symbols.py:145:4: W0603: Using the global statement (global-statement) devtools/count_symbols.py:145:4: C0103: Constant name "fmt" doesn't conform to UPPER_CASE naming style (invalid-name) devtools/count_symbols.py:145:4: C0103: Constant name "col_fmt" doesn't conform to UPPER_CASE naming style (invalid-name) devtools/count_symbols.py:149:8: W0612: Unused variable 'rel' (unused-variable) devtools/count_symbols.py:156:0: C0103: Constant name "directories" doesn't conform to UPPER_CASE naming style (invalid-name) devtools/count_symbols.py:158:0: C0116: Missing function or method docstring (missing-function-docstring) devtools/count_symbols.py:158:0: R0914: Too many local variables (20/15) (too-many-locals) devtools/count_symbols.py:159:4: W0603: Using the global statement (global-statement) devtools/count_symbols.py:159:4: C0103: Constant name "fmt" doesn't conform to UPPER_CASE naming style (invalid-name) devtools/count_symbols.py:159:4: C0103: Constant name "col_fmt" doesn't conform to UPPER_CASE naming style (invalid-name) devtools/count_symbols.py:159:4: C0103: Constant name "symbolMapGrammar" doesn't conform to UPPER_CASE naming style (invalid-name) devtools/count_symbols.py:177:4: C0103: Variable name "MAPParser" doesn't conform to snake_case naming style (invalid-name) devtools/count_symbols.py:192:25: W1510: Using subprocess.run without explicitly set `check` is not recommended. (subprocess-run-check) devtools/count_symbols.py:5:0: W0611: Unused import sys (unused-import) ----------------------------------- Your code has been rated at 6.27/10