From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7863FA0547; Mon, 21 Jun 2021 01:28:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E74E240040; Mon, 21 Jun 2021 01:28:32 +0200 (CEST) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by mails.dpdk.org (Postfix) with ESMTP id 71CF24003F; Mon, 21 Jun 2021 01:28:31 +0200 (CEST) Received: by mail-lj1-f179.google.com with SMTP id r16so22527819ljk.9; Sun, 20 Jun 2021 16:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NLM/F+zJFDa6sAo23lpur0vnn84Vhj1m6Hqt9EuoW8o=; b=gAAPIkUKHDyNvH43SUEVHEJOXq4xihYOjV32EEJStNcvgahQKgSJOfq54iosFZt13Z 7xEZyNntj3d9VbT8xIMS4AeIy2K+Vj7GyU2qKWrsheFk3T3wvbAn2WOVyVXqjKt66RAw RmvoFwml9Q9PIi4gHQEbdF3CWtUzZ4Njt70Z8N4ASpzQ9vjZzln4RA+VcRbbFAOt2vos FYyrsRLD8PuDUJXcw8+fWV7Mzo8CBZ4JuYmiTxYXhgD5Un6f/RrQ/95B20UwBExLEjYO XTurpSd4ywYRkO+HgzU/N7Ai075FQosCsnj/gJOzmS0TVT/UIGNWYWC2PNogh0+3/03+ WnWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NLM/F+zJFDa6sAo23lpur0vnn84Vhj1m6Hqt9EuoW8o=; b=l9pciYzYao4VnOQCHiXUSB/QANJYfD+zryShMiAEmQgd3muVDeKQ/tfp9S/Uau9djQ aGpNBqJWRcKq2yWpwBYe3MwyZ1EThqVSAo7tDcN0QHYicdLMA2wiXJsPIRBJl3pTBxT1 li6cd9qVcu4pTMnKJ5TeHugI6fqzvbyvSFxEeFqPqkiVEkCC51zpkAJe7624Ol48A9Kq pfY56cCC3J+NN0DLSAczTJfF5yQK7+0O0Nuzqfozgmx6umFCe6JqvKq4jY1YKIN4jG+D ZXe0Z1BXCc1FNd94oJWSvFFkJtqUPiofd7FsscRIvye2Ye9dW77SkTWieqD+lcPuqDOO GD6g== X-Gm-Message-State: AOAM53189yU15xPipSjbhetjyX76Dy5wz76LWtNKBomiJGXRaZ31l+0q zdaOe5MU5sSr82fry6AH4As= X-Google-Smtp-Source: ABdhPJwoALigbvyr8EuQt+kqOF0vA6IVAyXS8zthNgmdzGuVZ/ilmDZDeAMwcS6RTvH0LVxdnzhRGg== X-Received: by 2002:a2e:b6c1:: with SMTP id m1mr19841318ljo.97.1624231710940; Sun, 20 Jun 2021 16:28:30 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id k16sm1676542lfo.61.2021.06.20.16.28.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Jun 2021 16:28:29 -0700 (PDT) Date: Mon, 21 Jun 2021 02:28:27 +0300 From: Dmitry Kozlyuk To: Jie Zhou Cc: dev@dpdk.org, xiaoyun.li@intel.com, roretzla@microsoft.com, talshn@nvidia.com, pallavi.kadam@intel.com, thomas@monjalon.net, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, stable@dpdk.org Message-ID: <20210621022827.6f342d73@sovereign> In-Reply-To: <1620241931-28435-3-git-send-email-jizh@linux.microsoft.com> References: <1620236174-10676-1-git-send-email-jizh@linux.microsoft.com> <1620241931-28435-1-git-send-email-jizh@linux.microsoft.com> <1620241931-28435-3-git-send-email-jizh@linux.microsoft.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v13 02/10] eal/windows: add necessary macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-05-05 12:12 (UTC-0700), Jie Zhou: > Add required macros by testpmd on Windows in rte_os_shim.h > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > Acked-by: Tal Shnaiderman > --- > lib/eal/windows/include/rte_os_shim.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h > index 1b314733b..3763cae62 100644 > --- a/lib/eal/windows/include/rte_os_shim.h > +++ b/lib/eal/windows/include/rte_os_shim.h > @@ -21,6 +21,7 @@ > #define strdup(str) _strdup(str) > #define strtok_r(str, delim, saveptr) strtok_s(str, delim, saveptr) > #ifndef RTE_TOOLCHAIN_GCC > +#define strcasecmp _stricmp > #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count) > #endif Please use macros with arguments, like in the next line. This provides better error messages at call site and IDE display a nice hint knowing the parameters. > > @@ -38,6 +39,14 @@ > #define IPPROTO_SCTP 132 > #endif > > +#ifndef IPDEFTTL > +#define IPDEFTTL 64 > +#endif > + > +#ifndef S_ISREG > +#define S_ISREG(mode) (((mode)&S_IFMT) == S_IFREG) > +#endif > + Missing spaces around `&`. > #ifdef RTE_TOOLCHAIN_GCC > > #define TIME_UTC 1