From: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
To: xhavli56@stud.fit.vutbr.cz, Chas Williams <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>,
Declan Doherty <declan.doherty@intel.com>
Cc: dev@dpdk.org, Jan Viktorin <viktorin@cesnet.cz>
Subject: [dpdk-dev] [PATCH 1/3] net/bonding: fix proper return value check and correct log message
Date: Tue, 22 Jun 2021 11:25:28 +0200 [thread overview]
Message-ID: <20210622092531.73112-2-xhavli56@stud.fit.vutbr.cz> (raw)
In-Reply-To: <20210622092531.73112-1-xhavli56@stud.fit.vutbr.cz>
Return value is now saved to errval and log message on error
reports correct function name, doesn't use q_id which was out of context,
and uses up-to-date errval.
Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control")
Cc: tomaszx.kulasek@intel.com
Signed-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
Cc: Jan Viktorin <viktorin@cesnet.cz>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index b01ef003e..4c43bf916 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1805,12 +1805,13 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
!= 0)
return errval;
- if (bond_ethdev_8023ad_flow_verify(bonded_eth_dev,
- slave_eth_dev->data->port_id) != 0) {
+ errval = bond_ethdev_8023ad_flow_verify(bonded_eth_dev,
+ slave_eth_dev->data->port_id);
+ if (errval != 0) {
RTE_BOND_LOG(ERR,
- "rte_eth_tx_queue_setup: port=%d queue_id %d, err (%d)",
- slave_eth_dev->data->port_id, q_id, errval);
- return -1;
+ "bond_ethdev_8023ad_flow_verify: port=%d, err (%d)",
+ slave_eth_dev->data->port_id, errval);
+ return errval;
}
if (internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id] != NULL)
--
2.27.0
next prev parent reply other threads:[~2021-06-22 9:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 9:25 [dpdk-dev] [PATCH 0/3] net/bonding: make dedicated queues work with mlx5 Martin Havlik
2021-06-22 9:25 ` Martin Havlik [this message]
2021-07-08 12:33 ` [dpdk-dev] [PATCH 1/3] net/bonding: fix proper return value check and correct log message Min Hu (Connor)
2021-07-13 9:26 ` Andrew Rybchenko
2021-06-22 9:25 ` [dpdk-dev] [PATCH 2/3] net/bonding: fix not checked return value Martin Havlik
2021-07-08 12:43 ` Min Hu (Connor)
2021-07-08 13:20 ` Havlík Martin
2021-07-09 0:09 ` Min Hu (Connor)
2021-07-13 9:26 ` Andrew Rybchenko
2021-06-22 9:25 ` [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow Martin Havlik
2021-06-23 7:04 ` Min Hu (Connor)
2021-06-24 11:57 ` Havlík Martin
2021-07-04 15:18 ` Matan Azrad
2021-07-07 15:54 ` Jan Viktorin
2021-07-11 8:49 ` Ori Kam
2021-07-11 21:45 ` Jan Viktorin
2021-07-12 13:07 ` Ori Kam
2021-07-13 8:18 ` Havlík Martin
2021-07-13 9:26 ` Andrew Rybchenko
2021-07-13 11:06 ` Jan Viktorin
2021-07-13 17:17 ` Ori Kam
2021-07-14 15:00 ` Jan Viktorin
2021-07-15 13:58 ` Thomas Monjalon
2021-08-24 13:18 ` Ferruh Yigit
2021-08-26 10:15 ` Jan Viktorin
2021-07-04 15:03 ` [dpdk-dev] [PATCH 0/3] net/bonding: make dedicated queues work with mlx5 Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622092531.73112-2-xhavli56@stud.fit.vutbr.cz \
--to=xhavli56@stud.fit.vutbr.cz \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=tomaszx.kulasek@intel.com \
--cc=viktorin@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).