From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9BB2FA0A0C;
	Mon, 28 Jun 2021 16:10:03 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 84E0A4069F;
	Mon, 28 Jun 2021 16:10:03 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id DCFA240692;
 Mon, 28 Jun 2021 16:10:01 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 3D4F420B6C14; Mon, 28 Jun 2021 07:10:01 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3D4F420B6C14
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1624889401;
 bh=41TLIBLpNHvCN9urHEUP7mMnSZudbav+eNzostvz+dY=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=LPFjOF517kyKItzpHLptdssdcrUPmpYAQqDV/GJBhFr/tzm92rli9eSMiy1I9JJJf
 c6qaDKbG4ih2b+9BrfIu1edmWEujHv6+7lCG7e/nsAwmqyDY2U/gvkKJldyMzuHf/j
 JnI++hc9TK9g9ncbzVFdbOK7KE36ufAlVKbIX85o=
Date: Mon, 28 Jun 2021 07:10:01 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Jie Zhou <jizh@linux.microsoft.com>, dev@dpdk.org,
 dmitry.kozliuk@gmail.com, xiaoyun.li@intel.com,
 roretzla@microsoft.com, talshn@nvidia.com, pallavi.kadam@intel.com,
 thomas@monjalon.net, bruce.richardson@intel.com,
 ferruh.yigit@intel.com, konstantin.ananyev@intel.com, stable@dpdk.org
Message-ID: <20210628141001.GA28256@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1620241931-28435-1-git-send-email-jizh@linux.microsoft.com>
 <1624487698-31136-1-git-send-email-jizh@linux.microsoft.com>
 <1624487698-31136-2-git-send-email-jizh@linux.microsoft.com>
 <681deaed-fbbf-998f-65cf-9990b0cdcdaf@oktetlabs.ru>
 <faeb6097-cc35-0be0-1074-d9ac64230f78@oktetlabs.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <faeb6097-cc35-0be0-1074-d9ac64230f78@oktetlabs.ru>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd
 depends on
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jun 28, 2021 at 01:35:09PM +0300, Andrew Rybchenko wrote:
> On 6/28/21 1:01 PM, Andrew Rybchenko wrote:
> >On 6/24/21 1:34 AM, Jie Zhou wrote:
> >>Enable building libraries that testpmd depends on for Windows
> >>
> >>Signed-off-by: Jie Zhou <jizh@microsoft.com>
> >>Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> >
> >Why are two a bit difference Signed-off-by used in these
> >patches? Can we drop the first one and keep the second one
> >which matches E-mail From?
> 
> In fact looking at git log I see both E-mail addresses
> present, but it looks like the first one (w/o linux.) is
> used more often.

yes, the CI system rejects the patch without the first because it
doesn't match the original commit. it also rejects without the second
because it needs to match the dev email list subscriber mail so both
have been provided to pass CI.

i think future patches submitted won't be an issue because git local
config for the dpdk clone has been changed to match the second which is
also the subscription mail but changing the config doesn't re-write
the history on the commits (and it shouldn't).