From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CFA1FA0A0F;
	Wed, 30 Jun 2021 04:02:02 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B2C5241109;
	Wed, 30 Jun 2021 04:02:02 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 32DC640E01
 for <dev@dpdk.org>; Wed, 30 Jun 2021 04:02:01 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1059)
 id 90F2420B7178; Tue, 29 Jun 2021 19:02:00 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 90F2420B7178
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1625018520;
 bh=NS1U3+SQjuWwRa4NAnKKY+mnc6ZKtrckZRka6zxpKpE=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=il+pi8INm5ggf1kKmFkRy6BNNDS7ni93/xjbqzDDgHmLo9RXZZ2Eh3BZfNcHzCBAZ
 qn4skCCl8WCSxvWIYJYrWrimF5RVAULSSYllVLXRalQo1eiYAHS0WyHyxxfwJYpboz
 rI0cpIWBV9UuggYtXcRjSev0yzYcD0OnBh4zKw78=
Date: Tue, 29 Jun 2021 19:02:00 -0700
From: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ocardona@microsoft.com,
 pallavi.kadam@intel.com, talshn@nvidia.com, dmitrym@microsoft.com,
 Narcisa Vasile <navasile@microsoft.com>
Message-ID: <20210630020200.GA27191@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1624580843-4521-1-git-send-email-navasile@linux.microsoft.com>
 <20210625113621.13bd39ae@sovereign>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210625113621.13bd39ae@sovereign>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH] eal/windows: ensure all the CPUs in the set
 are checked
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jun 25, 2021 at 11:36:21AM +0300, Dmitry Kozlyuk wrote:
> 2021-06-24 17:27 (UTC-0700), Narcisa Ana Maria Vasile:
> > From: Narcisa Vasile <navasile@microsoft.com>
> > 
> > Fix count_cpu() to ensure it iterates through all the CPUs in a set.
> > count_cpu() iterates through the CPUs in the set 's' and counts the
> > selected ones.
> > 
> > Previously, it was incorrectly using the number of CPUSETS to iterate
> > through the CPUs.
> >
> > Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> > ---
> >  lib/eal/windows/include/sched.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Hi Naty,
> 
> Thank you for the fix, but we also need a proper commit message:
> 
> https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body
> 
> Specifically, please, describe what was the observable issue (usually first
> comes what was wrong, then how it is fixed now) and add "Fixes" tag and Cc.
> Also, "number of CPUSETS" sounds unclear, as there's no "CPUSET".
> Suggestion: "number of bitset limbs" or maybe if you describe what was
> wrong with the result you won't need to describe its reason precisely at all.

Ah, I've mixed some terminology here..
Thank you Dmitry for the feedback!