* [dpdk-dev] [PATCH] doc: announce SA config option struct changes
@ 2021-06-30 11:20 Archana Muniganti
2021-07-31 17:53 ` Akhil Goyal
0 siblings, 1 reply; 10+ messages in thread
From: Archana Muniganti @ 2021-06-30 11:20 UTC (permalink / raw)
To: gakhil, roy.fan.zhang, hemant.agrawal, konstantin.ananyev
Cc: Archana Muniganti, anoobj, jerinj, dev
Proposing following two new fields for IPsec inner checksum
configuration in the structure ``rte_security_ipsec_sa_options``.
uint32_t ip_csum_enable : 1;
uint32_t l4_csum_enable : 1;
With these config options, per SA, application can specify if
the inner checksum(compute/verify) to be offloaded to the
security device.
https://mails.dpdk.org/archives/dev/2021-June/212977.html
Signed-off-by: Archana Muniganti <marchana@marvell.com>
---
doc/guides/rel_notes/deprecation.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 9584d6bfd7..da65ae68be 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -141,6 +141,10 @@ Deprecation Notices
in "rte_sched.h". These changes are aligned to improvements suggested in the
RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
+* security: The IPsec SA config options structure ``struct rte_security_ipsec_sa_options``
+ will be updated with two new fields to support IPsec inner checksum in case
+ of protocol offload.
+
* metrics: The function ``rte_metrics_init`` will have a non-void return
in order to notify errors instead of calling ``rte_exit``.
--
2.22.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes
2021-06-30 11:20 [dpdk-dev] [PATCH] doc: announce SA config option struct changes Archana Muniganti
@ 2021-07-31 17:53 ` Akhil Goyal
0 siblings, 0 replies; 10+ messages in thread
From: Akhil Goyal @ 2021-07-31 17:53 UTC (permalink / raw)
To: Archana Muniganti, roy.fan.zhang, hemant.agrawal, konstantin.ananyev
Cc: Archana Muniganti, Anoob Joseph, Jerin Jacob Kollanukkaran, dev
> Proposing following two new fields for IPsec inner checksum
> configuration in the structure ``rte_security_ipsec_sa_options``.
> uint32_t ip_csum_enable : 1;
> uint32_t l4_csum_enable : 1;
>
> With these config options, per SA, application can specify if
> the inner checksum(compute/verify) to be offloaded to the
> security device.
>
> https://mails.dpdk.org/archives/dev/2021-June/212977.html
>
> Signed-off-by: Archana Muniganti <marchana@marvell.com>
> ---
Marking this patch as Not applicable,
As a new patch is submitted for consolidating all notices for same structure.
https://mails.dpdk.org/archives/dev/2021-July/215906.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH] doc: announce SA config option struct changes
@ 2021-07-31 17:44 Akhil Goyal
2021-08-02 9:43 ` Anoob Joseph
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Akhil Goyal @ 2021-07-31 17:44 UTC (permalink / raw)
To: dev
Cc: anoobj, radu.nicolau, declan.doherty, abhijits.sinha,
daniel.m.buckley, marchana, ktejasree, hemant.agrawal, matan,
konstantin.ananyev, Akhil Goyal
From: Archana Muniganti <marchana@marvell.com>
Propose new fields to support offloads like
- IPsec inner checksum(L3/L4)
- IPsec tunnel header verification
- TSO
- etc
in the structure ``rte_security_ipsec_sa_options``.
Signed-off-by: Archana Muniganti <marchana@marvell.com>
Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
---
Proposal for changes are floated as per below links.
https://mails.dpdk.org/archives/dev/2021-June/212977.html
https://mails.dpdk.org/archives/dev/2021-July/213484.html
https://mails.dpdk.org/archives/dev/2021-July/214521.html
Cc: Radu Nicolau <radu.nicolau@intel.com>
doc/guides/rel_notes/deprecation.rst | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6a35c7649a..96192b4a41 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -151,3 +151,7 @@ Deprecation Notices
* security: The functions ``rte_security_set_pkt_metadata`` and
``rte_security_get_userdata`` will be made inline functions and additional
flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
+
+* security: The IPsec SA config options ``struct rte_security_ipsec_sa_options``
+ will be updated with new fields to support new features like IPsec inner
+ checksum, tunnel header verification, TSO in case of protocol offload.
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes
2021-07-31 17:44 Akhil Goyal
@ 2021-08-02 9:43 ` Anoob Joseph
2021-08-02 12:41 ` Akhil Goyal
2021-08-04 17:03 ` Akhil Goyal
2021-08-05 10:00 ` Nicolau, Radu
2 siblings, 1 reply; 10+ messages in thread
From: Anoob Joseph @ 2021-08-02 9:43 UTC (permalink / raw)
To: Akhil Goyal, dev
Cc: radu.nicolau, declan.doherty, abhijits.sinha, daniel.m.buckley,
Archana Muniganti, Tejasree Kondoj, hemant.agrawal, matan,
konstantin.ananyev, Akhil Goyal
Hi Akhil,
There are 2 more items that I would like to add.
- IV gen (in ``rte_security_ipsec_sa_options``)
- SA lifetime configuration (in ``rte_security_ipsec_xform``)
http://patches.dpdk.org/project/dpdk/patch/1626759974-334-2-git-send-email-anoobj@marvell.com/
http://patches.dpdk.org/project/dpdk/patch/1626759974-334-3-git-send-email-anoobj@marvell.com/
Do you recommend sending separate deprecation notice or can this patch be updated to cover those as well?
Thanks,
Anoob
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Saturday, July 31, 2021 11:14 PM
> To: dev@dpdk.org
> Cc: Anoob Joseph <anoobj@marvell.com>; radu.nicolau@intel.com;
> declan.doherty@intel.com; abhijits.sinha@intel.com;
> daniel.m.buckley@intel.com; Archana Muniganti <marchana@marvell.com>;
> Tejasree Kondoj <ktejasree@marvell.com>; hemant.agrawal@nxp.com;
> matan@nvidia.com; konstantin.ananyev@intel.com; Akhil Goyal
> <gakhil@marvell.com>
> Subject: [PATCH] doc: announce SA config option struct changes
>
> From: Archana Muniganti <marchana@marvell.com>
>
> Propose new fields to support offloads like
> - IPsec inner checksum(L3/L4)
> - IPsec tunnel header verification
> - TSO
> - etc
> in the structure ``rte_security_ipsec_sa_options``.
>
> Signed-off-by: Archana Muniganti <marchana@marvell.com>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> Proposal for changes are floated as per below links.
> https://mails.dpdk.org/archives/dev/2021-June/212977.html
> https://mails.dpdk.org/archives/dev/2021-July/213484.html
> https://mails.dpdk.org/archives/dev/2021-July/214521.html
>
> Cc: Radu Nicolau <radu.nicolau@intel.com>
>
> doc/guides/rel_notes/deprecation.rst | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 6a35c7649a..96192b4a41 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -151,3 +151,7 @@ Deprecation Notices
> * security: The functions ``rte_security_set_pkt_metadata`` and
> ``rte_security_get_userdata`` will be made inline functions and additional
> flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> +
> +* security: The IPsec SA config options ``struct
> rte_security_ipsec_sa_options``
> + will be updated with new fields to support new features like IPsec inner
> + checksum, tunnel header verification, TSO in case of protocol offload.
> --
> 2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes
2021-08-02 9:43 ` Anoob Joseph
@ 2021-08-02 12:41 ` Akhil Goyal
0 siblings, 0 replies; 10+ messages in thread
From: Akhil Goyal @ 2021-08-02 12:41 UTC (permalink / raw)
To: Anoob Joseph, dev
Cc: radu.nicolau, declan.doherty, abhijits.sinha, daniel.m.buckley,
Archana Muniganti, Tejasree Kondoj, hemant.agrawal, matan,
konstantin.ananyev
> Hi Akhil,
>
> There are 2 more items that I would like to add.
> - IV gen (in ``rte_security_ipsec_sa_options``)
> - SA lifetime configuration (in ``rte_security_ipsec_xform``)
>
> http://patches.dpdk.org/project/dpdk/patch/1626759974-334-2-git-send-
> email-anoobj@marvell.com/
> http://patches.dpdk.org/project/dpdk/patch/1626759974-334-3-git-send-
> email-anoobj@marvell.com/
>
> Do you recommend sending separate deprecation notice or can this patch be
> updated to cover those as well?
>
> Thanks,
> Anoob
>
This patch is to cover changes in ``rte_security_ipsec_sa_options``, hence for iv_gen no need.
For ipsec_xform a new one would be good.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes
2021-07-31 17:44 Akhil Goyal
2021-08-02 9:43 ` Anoob Joseph
@ 2021-08-04 17:03 ` Akhil Goyal
2021-08-05 10:00 ` Nicolau, Radu
2 siblings, 0 replies; 10+ messages in thread
From: Akhil Goyal @ 2021-08-04 17:03 UTC (permalink / raw)
To: Akhil Goyal, dev, konstantin.ananyev, radu.nicolau, hemant.agrawal
Cc: Anoob Joseph, declan.doherty, daniel.m.buckley,
Archana Muniganti, Tejasree Kondoj, matan
> Subject: [PATCH] doc: announce SA config option struct changes
>
> From: Archana Muniganti <marchana@marvell.com>
>
> Propose new fields to support offloads like
> - IPsec inner checksum(L3/L4)
> - IPsec tunnel header verification
> - TSO
> - etc
> in the structure ``rte_security_ipsec_sa_options``.
>
> Signed-off-by: Archana Muniganti <marchana@marvell.com>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
Ping for Acks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes
2021-07-31 17:44 Akhil Goyal
2021-08-02 9:43 ` Anoob Joseph
2021-08-04 17:03 ` Akhil Goyal
@ 2021-08-05 10:00 ` Nicolau, Radu
2021-08-05 10:14 ` Hemant Agrawal
2021-08-07 17:17 ` Thomas Monjalon
2 siblings, 2 replies; 10+ messages in thread
From: Nicolau, Radu @ 2021-08-05 10:00 UTC (permalink / raw)
To: Akhil Goyal, dev
Cc: anoobj, declan.doherty, abhijits.sinha, daniel.m.buckley,
marchana, ktejasree, hemant.agrawal, matan, konstantin.ananyev
On 7/31/2021 6:44 PM, Akhil Goyal wrote:
> From: Archana Muniganti <marchana@marvell.com>
>
> Propose new fields to support offloads like
> - IPsec inner checksum(L3/L4)
> - IPsec tunnel header verification
> - TSO
> - etc
> in the structure ``rte_security_ipsec_sa_options``.
>
> Signed-off-by: Archana Muniganti <marchana@marvell.com>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> ---
> Proposal for changes are floated as per below links.
> https://mails.dpdk.org/archives/dev/2021-June/212977.html
> https://mails.dpdk.org/archives/dev/2021-July/213484.html
> https://mails.dpdk.org/archives/dev/2021-July/214521.html
>
> Cc: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes
2021-08-05 10:00 ` Nicolau, Radu
@ 2021-08-05 10:14 ` Hemant Agrawal
2021-08-07 13:31 ` Jerin Jacob
2021-08-07 17:17 ` Thomas Monjalon
1 sibling, 1 reply; 10+ messages in thread
From: Hemant Agrawal @ 2021-08-05 10:14 UTC (permalink / raw)
To: Nicolau, Radu, Akhil Goyal, dev
Cc: anoobj, declan.doherty, abhijits.sinha, daniel.m.buckley,
marchana, ktejasree, matan, konstantin.ananyev
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes
2021-08-05 10:14 ` Hemant Agrawal
@ 2021-08-07 13:31 ` Jerin Jacob
0 siblings, 0 replies; 10+ messages in thread
From: Jerin Jacob @ 2021-08-07 13:31 UTC (permalink / raw)
To: Hemant Agrawal
Cc: Nicolau, Radu, Akhil Goyal, dev, anoobj, declan.doherty,
abhijits.sinha, daniel.m.buckley, marchana, ktejasree, matan,
konstantin.ananyev
On Thu, Aug 5, 2021 at 3:44 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes
2021-08-05 10:00 ` Nicolau, Radu
2021-08-05 10:14 ` Hemant Agrawal
@ 2021-08-07 17:17 ` Thomas Monjalon
1 sibling, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2021-08-07 17:17 UTC (permalink / raw)
To: Akhil Goyal, marchana, ktejasree
Cc: dev, anoobj, declan.doherty, abhijits.sinha, daniel.m.buckley,
hemant.agrawal, matan, konstantin.ananyev, Nicolau, Radu
> > Propose new fields to support offloads like
> > - IPsec inner checksum(L3/L4)
> > - IPsec tunnel header verification
> > - TSO
> > - etc
> > in the structure ``rte_security_ipsec_sa_options``.
> >
> > Signed-off-by: Archana Muniganti <marchana@marvell.com>
> > Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> > ---
> > Proposal for changes are floated as per below links.
> > https://mails.dpdk.org/archives/dev/2021-June/212977.html
> > https://mails.dpdk.org/archives/dev/2021-July/213484.html
> > https://mails.dpdk.org/archives/dev/2021-July/214521.html
> >
> Acked-by: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-08-07 17:17 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-30 11:20 [dpdk-dev] [PATCH] doc: announce SA config option struct changes Archana Muniganti
2021-07-31 17:53 ` Akhil Goyal
2021-07-31 17:44 Akhil Goyal
2021-08-02 9:43 ` Anoob Joseph
2021-08-02 12:41 ` Akhil Goyal
2021-08-04 17:03 ` Akhil Goyal
2021-08-05 10:00 ` Nicolau, Radu
2021-08-05 10:14 ` Hemant Agrawal
2021-08-07 13:31 ` Jerin Jacob
2021-08-07 17:17 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).