From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 413DEA0A0C; Fri, 2 Jul 2021 08:20:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5E484138A; Fri, 2 Jul 2021 08:18:59 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2065.outbound.protection.outlook.com [40.107.102.65]) by mails.dpdk.org (Postfix) with ESMTP id 06DEF4137E for ; Fri, 2 Jul 2021 08:18:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K/fJYNsrtlJUgVgEolaGGxkVuBGaVA+DQYs6txAkXhxPmQh0Cjfkrlz+fhZWzTzIdRg/8IU+JIozJFA+ERgZLTiHD7D63mN2MdIe/fLLHF3M+t4l7d+hm70qYi1u/kxvB47sCd8WGobhEFJXcHw7+X0oqw+cmBAsBeUys2g5y5WzWrq3XJXQ2nwxeWYEOCLsI9H/L4tONoMGTqSQaHwYocwrj2ChLyvm5pQJvx4IwflXv6W2xPJwheD6XYWtwk2vJoQjYVtnDEiaKXUJ+bzpOUHizXdezSBkfMa5aXtzKgYtD/i9xnYymrx/OUC8QF23/QDLIAO+VIUTPa2ZzQpS4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l3LmN+AS9/0U5ydZCtIGn5QirS8nw3Mk/L0kVAkHic8=; b=TLSl8pi9jHRfEOBoC1Aoeur3GyEZwOkA/oiZSFaqrJhGZVA7CQdyXHSqV9Z+rC1EzO+cDHRw5NbBbzb21PSeXjtqkO/fyeR9Ui5/E7m/Q7HgiNxEBJ5Vhc0LyTcs1fn6jQ6hFQTXfZe1bGuaa5Nng79axvODUYYUF//RlVcufC/6eXKvLVV3eLkpuVgtMtzKnqzWy94Th+6OqB/sK+vyKRTt8M6oFEHmZRto23A3rTQlAKzwERaGFScN5xMSZnV7P/akqsrSKVfsVihpMMnup+tcMpvBueIdZweqwmgA+Qjaynj3m82dKbAGQ95sH7xVv3Ae6SuYtU7XI72YNHQLBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l3LmN+AS9/0U5ydZCtIGn5QirS8nw3Mk/L0kVAkHic8=; b=LwKljoTkH5sd0rFS5ON2uERWZ3rCJglI3tQJpdLUkdpKH78boqeWM5+C97nMtdrygwXNp064Za3MSKEGlP6hs4YeH999WJL4vsUquL4W6ylHKTC+Bph4ODfO5CWLB27HOJr8MnGQgmOIUqr9hdOCiwPZOwS7q3YzPJsgYuvuCigtaykD/UZQy3Pou+w8PSBGrZ1Jz31zWbywdGFyW175UgmuhUtkqd8GY2SQOMkhLGn4SX6r8Os3j7j21QHzkS4bNAGQkezdTAI1Od52zKnf6+p9+IMJEcDucBfWI7ooE9SwpPhmA9giKWyZWyfBMmYmW6K8R0Unl5gz8IuQSVu/GQ== Received: from BN1PR13CA0004.namprd13.prod.outlook.com (2603:10b6:408:e2::9) by DM6PR12MB4579.namprd12.prod.outlook.com (2603:10b6:5:2ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19; Fri, 2 Jul 2021 06:18:56 +0000 Received: from BN8NAM11FT006.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e2:cafe::af) by BN1PR13CA0004.outlook.office365.com (2603:10b6:408:e2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Fri, 2 Jul 2021 06:18:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT006.mail.protection.outlook.com (10.13.177.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 06:18:56 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 2 Jul 2021 06:18:54 +0000 From: Suanming Mou To: , CC: , , Date: Fri, 2 Jul 2021 09:18:08 +0300 Message-ID: <20210702061816.10454-15-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210702061816.10454-1-suanmingm@nvidia.com> References: <20210527093403.1153127-1-suanmingm@nvidia.com> <20210702061816.10454-1-suanmingm@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84dc661a-2db7-48bc-2333-08d93d2145d1 X-MS-TrafficTypeDiagnostic: DM6PR12MB4579: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:628; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PagxcxCARJo11E7NE+b2T749wlNRAdCtyhJtAJWaVkHObmg3/82Z1o3DkuMsGJCnVgrgw6XhQB5jpI5qiHmc71/tOUgB1Y1pzRSADpALyYWpDZI8VR2V/cdpYobUniK5Xc/iZfEKsO19HqEC0ITntBSwOLPNjVA5AEdLgPSy/d2nuQdd9bOyrKqgiJ/9ijXh6RTKnACJ32SaC1AxTUzME2/sf75DeZdkvI5ewt51Z+G2R2icTVDvVrNwemIIJ2v1KIRxv0ZTVGAwi189wsoEF2aHh4HK00UMcgaMzwpefrh8PW16gddWzvAcBmoaH9WZuPX8RR6ozSUYAdauye/QFFXVYD0uWz2DJOsCA6iaQ1bhO0KuG6KV94+InUwn1Lj0yppvbgfAplxGZFYDwOTpNfIxvzn02voMtM3wSBTTmLAEedtF6ydxKQ6109zETUU+GoRBWQUTKDXcV3iHCgrD78mhH3HrExCYpCUZxTB80o31dXDNOclimeq1FrDu8irqzOrS5FnFU1AurB5Dj5wFqee02RTzP82Ps0q3kiX6tDH52mEX9aIwh0YTbGzJStYKJNUU86gqyFv7eDeL8Oav0AHZMbOq17qqP5EW/AuXuBQ3YK7x1v0UnnisgweOWippAbXi4rWkxkNNvHmgXVpYXdpJA6dvhfd4IK2s4BaSOyBT1qCEC1ftKQZOuwqSWmFftqtf2AxYa0Dg6zh/EvW2gA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(376002)(346002)(36840700001)(46966006)(82310400003)(5660300002)(8676002)(6286002)(8936002)(70206006)(36906005)(70586007)(6666004)(1076003)(186003)(26005)(54906003)(47076005)(110136005)(478600001)(7636003)(82740400003)(16526019)(4326008)(356005)(86362001)(316002)(55016002)(336012)(426003)(2616005)(83380400001)(36756003)(7696005)(6636002)(36860700001)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 06:18:56.2385 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 84dc661a-2db7-48bc-2333-08d93d2145d1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT006.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4579 Subject: [dpdk-dev] [PATCH v3 14/22] net/mlx5: adjust the hash bucket size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" With the new per core optimization to the list, the hash bucket size can be tuned to a more accurate number. This commit adjusts the hash bucket size. Signed-off-by: Suanming Mou --- drivers/net/mlx5/linux/mlx5_os.c | 2 +- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5_defs.h | 6 +++--- drivers/net/mlx5/mlx5_flow.c | 5 ++--- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index cf573a9a4d..a82dc4db00 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -50,7 +50,7 @@ #include "mlx5_nl.h" #include "mlx5_devx.h" -#define MLX5_TAGS_HLIST_ARRAY_SIZE 8192 +#define MLX5_TAGS_HLIST_ARRAY_SIZE (1 << 15) #ifndef HAVE_IBV_MLX5_MOD_MPW #define MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED (1 << 2) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 713accf675..8fb7f4442d 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -373,7 +373,7 @@ static const struct mlx5_indexed_pool_config mlx5_ipool_cfg[] = { #define MLX5_FLOW_MIN_ID_POOL_SIZE 512 #define MLX5_ID_GENERATION_ARRAY_FACTOR 16 -#define MLX5_FLOW_TABLE_HLIST_ARRAY_SIZE 4096 +#define MLX5_FLOW_TABLE_HLIST_ARRAY_SIZE 1024 /** * Decide whether representor ID is a HPF(host PF) port on BF2. diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h index 906aa43c5a..ca67ce8213 100644 --- a/drivers/net/mlx5/mlx5_defs.h +++ b/drivers/net/mlx5/mlx5_defs.h @@ -178,15 +178,15 @@ sizeof(struct rte_ipv4_hdr)) /* Size of the simple hash table for metadata register table. */ -#define MLX5_FLOW_MREG_HTABLE_SZ 4096 +#define MLX5_FLOW_MREG_HTABLE_SZ 64 #define MLX5_FLOW_MREG_HNAME "MARK_COPY_TABLE" #define MLX5_DEFAULT_COPY_ID UINT32_MAX /* Size of the simple hash table for header modify table. */ -#define MLX5_FLOW_HDR_MODIFY_HTABLE_SZ (1 << 16) +#define MLX5_FLOW_HDR_MODIFY_HTABLE_SZ (1 << 15) /* Size of the simple hash table for encap decap table. */ -#define MLX5_FLOW_ENCAP_DECAP_HTABLE_SZ (1 << 16) +#define MLX5_FLOW_ENCAP_DECAP_HTABLE_SZ (1 << 12) /* Hairpin TX/RX queue configuration parameters. */ #define MLX5_HAIRPIN_QUEUE_STRIDE 6 diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 7bd45d3895..15a895ea48 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -8625,7 +8625,7 @@ mlx5_flow_tunnel_allocate(struct rte_eth_dev *dev, DRV_LOG(ERR, "Tunnel ID %d exceed max limit.", id); return NULL; } - tunnel->groups = mlx5_hlist_create("tunnel groups", 1024, false, true, + tunnel->groups = mlx5_hlist_create("tunnel groups", 64, false, true, priv->sh, mlx5_flow_tunnel_grp2tbl_create_cb, mlx5_flow_tunnel_grp2tbl_match_cb, @@ -8734,8 +8734,7 @@ int mlx5_alloc_tunnel_hub(struct mlx5_dev_ctx_shared *sh) return -ENOMEM; LIST_INIT(&thub->tunnels); rte_spinlock_init(&thub->sl); - thub->groups = mlx5_hlist_create("flow groups", - rte_align32pow2(MLX5_MAX_TABLES), + thub->groups = mlx5_hlist_create("flow groups", 64, false, true, sh, mlx5_flow_tunnel_grp2tbl_create_cb, mlx5_flow_tunnel_grp2tbl_match_cb, -- 2.25.1