From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 169F2A0C43; Sun, 4 Jul 2021 18:18:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7CB540686; Sun, 4 Jul 2021 18:18:54 +0200 (CEST) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id B10B340040 for ; Sun, 4 Jul 2021 18:18:53 +0200 (CEST) Received: by mail-pg1-f178.google.com with SMTP id s18so481202pgg.8 for ; Sun, 04 Jul 2021 09:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BsLT7pjVBOoPwCewe5yF3bACK8c/Vx5Utih03/HoGzg=; b=rh3AtQbMjm1OZN7HZy0L1J9kH6vLmLxeHUX/5Ka3XXqWHEQnYwjusLXaWt0rWcVqG4 tOVR6PVoXpl5XiJIjPOfSCF6Ja303zJcrRUfpZpXVvq51a9G/U/xG6PPl3OrM14gHXri vkWDyC6sKipxfNQyIx3vLPGF274Ym5megUeNU0/gUkQ0kQX/2vflfrxUbLDQ3bv/veez FERHFvXhJRfcaKL8jbosQ3v9aehUs/Xey2vBKRAR7RoKTohLs0kaz+L11SEOOY5tmVYO OZHpmQfOugnxPxbFM6IVOWwdljJEKn7AHVlHTlhkLCMMtSCxJ4C6dNKRq3ST6/Hps34H LMzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BsLT7pjVBOoPwCewe5yF3bACK8c/Vx5Utih03/HoGzg=; b=Xnopzjbra5pwmqjFjrjjha5VWl74IRjeArL++MUuI2hL23fiehp/nei50B5TAoLV/8 1QkWcI65gbBAUKhxFm++VWsru6BZ8KiuBJbCOHdV71Cu3xeYZUiZAkxNsX1a7VJFpnkB YyL6PtSZPuqBtXVkKdT6CqdAalC5wNGUrdabQk6vRyjgflnchdzbscjswGRH8o1P9E/k Zgd7+YLQdiFVpCzKoSiDiMTkF+bDaNbsvousAUM52hTlsLzHlHe2N0FcE+X7pX0sc0/r QUda1Yb4iwpYtuDZ95jlTz61vy5HlS8xHQWM9K0o+O91ShFpLrA/TQg6ubrI6A9rnFdZ okRw== X-Gm-Message-State: AOAM532o2z0yUjHxfbVoVF/I3CMyzXgoMfr32SUeVF2Abg6ZT0vZV1/p qANHfpLNpAWiETY9mwLOgbuURg== X-Google-Smtp-Source: ABdhPJyZZRE+GRsAzN0LIWkd8ZByo8ySEMZCaSEDOyKlmYP3Ks3ifzqz6jRjqJp9HikJ1KqA3+5Xcg== X-Received: by 2002:a65:680b:: with SMTP id l11mr4644117pgt.349.1625415532823; Sun, 04 Jul 2021 09:18:52 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id l189sm5653251pgl.41.2021.07.04.09.18.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jul 2021 09:18:52 -0700 (PDT) Date: Sun, 4 Jul 2021 09:18:49 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, Andrew Rybchenko , ferruh.yigit@intel.com, keesang.song@amd.com, anatoly.burakov@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, David Christensen , dmitry.kozliuk@gmail.com, ruifeng.wang@arm.com Message-ID: <20210704091849.39b206ef@hermes.local> In-Reply-To: <2008897.KIaY0792Ae@thomas> References: <2863796.yO5TXMfXnl@thomas> <12700395.j6fn4b5UDm@thomas> <9e359fe9-f993-ef6c-1b51-1e08fec5ff9b@oktetlabs.ru> <2008897.KIaY0792Ae@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] NUMA node/socket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 04 Jul 2021 11:28:23 +0200 Thomas Monjalon wrote: > 04/07/2021 10:27, Andrew Rybchenko: > > On 7/4/21 4:53 AM, Thomas Monjalon wrote: > > > 04/07/2021 03:38, Thomas Monjalon: > > >> There are some mix between NUMA node and socket IDs in DPDK. > > >> Examples: > > >> * rte_eth_dev_socket_id() returns the NUMA node. > > >> * rte_malloc use sockets to allocate the memory > > >> > > >> Is it critical? > > > > > > There is a function, implemented for Windows only, > > > which distinguishes clearly node and socket > > > but it assumes there is only 1 node per socket: > > > > > > unsigned int > > > eal_socket_numa_node(unsigned int socket_id) > > > { > > > return cpu_map.sockets[socket_id].node_id; > > > } > > > > > > Reminder: AMD can be configured to have multiple nodes per socket. > > > > Taking the reminder into account the topic definitely > > requires improvements. > > > > I apologize for my ignorance, but > > Is socket ID really interesting to anybody in DPDK? > > I think the socket ID might be interesting for the threads, > but not for memory or devices. > > > If no, we should just clarify terminology and switch > > to NUMA node everywhere. > > I have the same opinion as Andrew. > If socket ID is required, it could be deduced from the NUMA node > or from the CPU core. > > Agree that NUMA node should be used everywhere. There can be some confusion because some architectures define NUMA for lcore's that have slower interconnect even if they are on the same chip. Also Dell used to have different terminology for socket number on some machines. The socket id reported by BIOS started with 1!