From: Richael Zhuang <richael.zhuang@arm.com>
To: dev@dpdk.org
Cc: yux.jiang@intel.com, richael.zhuang@arm.com, stable@dpdk.org,
David Hunt <david.hunt@intel.com>
Subject: [dpdk-dev] [PATCH v6 2/2] test/power: round cpuinfo cur freq only in CPPC cpufreq
Date: Thu, 8 Jul 2021 10:34:46 +0800 [thread overview]
Message-ID: <20210708023447.20495-3-richael.zhuang@arm.com> (raw)
In-Reply-To: <20210708023447.20495-1-richael.zhuang@arm.com>
On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not
be exactly the same as what was set when using CPPC cpufreq driver.
For other cpufreq driver, no need to round it currently, or else
this check will fail with turbo enabled. For example, with acpi_cpufreq,
cpuinfo_cur_freq can be 2401000 which is equal to freqs[0].It should
not be rounded to 2400000.
Fixes: 606a234c6d360 ("test/power: round CPU frequency to check")
Cc: richael.zhuang@arm.com
Cc: stable@dpdk.org
Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
---
app/test/test_power_cpufreq.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c
index 8516df4ca..b8fc53925 100644
--- a/app/test/test_power_cpufreq.c
+++ b/app/test/test_power_cpufreq.c
@@ -55,7 +55,9 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo)
FILE *f;
char fullpath[PATH_MAX];
char buf[BUFSIZ];
+ enum power_management_env env;
uint32_t cur_freq;
+ uint32_t freq_conv;
int ret = -1;
int i;
@@ -80,15 +82,18 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo)
goto fail_all;
cur_freq = strtoul(buf, NULL, TEST_POWER_CONVERT_TO_DECIMAL);
-
- /* convert the frequency to nearest 100000 value
- * Ex: if cur_freq=1396789 then freq_conv=1400000
- * Ex: if cur_freq=800030 then freq_conv=800000
- */
- unsigned int freq_conv = 0;
- freq_conv = (cur_freq + TEST_FREQ_ROUNDING_DELTA)
- / TEST_ROUND_FREQ_TO_N_100000;
- freq_conv = freq_conv * TEST_ROUND_FREQ_TO_N_100000;
+ freq_conv = cur_freq;
+
+ env = rte_power_get_env();
+ if (env == PM_ENV_CPPC_CPUFREQ) {
+ /* convert the frequency to nearest 100000 value
+ * Ex: if cur_freq=1396789 then freq_conv=1400000
+ * Ex: if cur_freq=800030 then freq_conv=800000
+ */
+ freq_conv = (cur_freq + TEST_FREQ_ROUNDING_DELTA)
+ / TEST_ROUND_FREQ_TO_N_100000;
+ freq_conv = freq_conv * TEST_ROUND_FREQ_TO_N_100000;
+ }
if (turbo)
ret = (freqs[idx] <= freq_conv ? 0 : -1);
--
2.20.1
next prev parent reply other threads:[~2021-07-08 2:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 6:15 [dpdk-dev] [PATCH v1 0/1] power: add support for cppc cpufreq driver Richael Zhuang
2021-04-22 6:15 ` [dpdk-dev] [PATCH v1 1/1] power: add support for cppc cpufreq Richael Zhuang
2021-04-22 9:06 ` Burakov, Anatoly
2021-04-22 9:29 ` Richael Zhuang
2021-04-22 9:59 ` Burakov, Anatoly
2021-04-22 10:02 ` Richael Zhuang
2021-04-23 11:37 ` Burakov, Anatoly
2021-04-24 7:03 ` Richael Zhuang
2021-05-12 3:49 ` [dpdk-dev] [PATCH v2 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-05-12 3:49 ` [dpdk-dev] [PATCH v2 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-05-12 3:49 ` [dpdk-dev] [PATCH v2 2/2] test/power: round cpuinfo cur freq only when using CPPC cpufreq Richael Zhuang
2021-05-12 3:57 ` [dpdk-dev] [PATCH v3 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-05-12 3:57 ` [dpdk-dev] [PATCH v3 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-06-23 3:55 ` [dpdk-dev] [PATCH v4 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-06-23 3:55 ` [dpdk-dev] [PATCH v4 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-06-23 14:10 ` David Hunt
2021-06-24 2:13 ` Richael Zhuang
2021-06-25 2:02 ` [dpdk-dev] [PATCH v5 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-06-25 2:02 ` [dpdk-dev] [PATCH v5 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-07-07 13:47 ` David Hunt
2021-07-08 2:09 ` Richael Zhuang
2021-07-08 2:34 ` [dpdk-dev] [PATCH v6 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-07-08 2:34 ` [dpdk-dev] [PATCH v6 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-07-08 8:27 ` David Hunt
2021-07-08 13:30 ` David Marchand
2021-07-08 20:43 ` David Marchand
2021-07-09 2:37 ` Richael Zhuang
2021-07-09 3:34 ` [dpdk-dev] [PATCH v7 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-07-09 3:34 ` [dpdk-dev] [PATCH v7 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-07-09 9:10 ` David Marchand
2021-07-09 10:35 ` Richael Zhuang
2021-07-09 9:52 ` David Hunt
2021-07-09 10:55 ` [dpdk-dev] [PATCH v8 0/2] power: add support for cppc cpufreq driver Richael Zhuang
2021-07-09 10:55 ` [dpdk-dev] [PATCH v8 1/2] power: add support for cppc cpufreq Richael Zhuang
2021-07-09 10:55 ` [dpdk-dev] [PATCH v8 2/2] test/power: round cpuinfo cur freq only in CPPC cpufreq Richael Zhuang
2021-07-09 14:07 ` [dpdk-dev] [PATCH v8 0/2] power: add support for cppc cpufreq driver David Marchand
2021-07-12 2:05 ` Richael Zhuang
2021-07-09 3:34 ` [dpdk-dev] [PATCH v7 2/2] test/power: round cpuinfo cur freq only in CPPC cpufreq Richael Zhuang
2021-07-08 2:34 ` Richael Zhuang [this message]
2021-07-08 8:27 ` [dpdk-dev] [PATCH v6 " David Hunt
2021-06-25 2:02 ` [dpdk-dev] [PATCH v5 2/2] test/power: round cpuinfo cur freq only when using " Richael Zhuang
2021-06-23 3:55 ` [dpdk-dev] [PATCH v4 " Richael Zhuang
2021-06-23 14:13 ` David Hunt
2021-05-12 3:57 ` [dpdk-dev] [PATCH v3 " Richael Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708023447.20495-3-richael.zhuang@arm.com \
--to=richael.zhuang@arm.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).