From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21C68A0548; Fri, 9 Jul 2021 02:16:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D972D4014D; Fri, 9 Jul 2021 02:16:58 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 7BB3240143 for ; Fri, 9 Jul 2021 02:16:57 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id C3F7820B7178; Thu, 8 Jul 2021 17:16:56 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C3F7820B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1625789816; bh=hMnJqM/XyQZBqTi4Wg7+MNosBXvW+nCZMB8Idb0XP28=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xiju//ap0/Ma1X7qRGe2kdxSxetlCSn4EINGPC1yiqpLtiluP6CX01Ipevaf1BLsy 0PP6Fc4ftObL+XjBOLwT/4qZF/iC8u80zfnFut3W5YifTzP/fdDXoCpoA7S8VcsQWf OEpNuCwgzO5ikAvwsZGceUJzrGeSQ6PzvTtz2s8w= Date: Thu, 8 Jul 2021 17:16:56 -0700 From: Tyler Retzlaff To: Thomas Monjalon Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com Message-ID: <20210709001656.GA23346@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20210708192109.GA13966@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <1925991.Mh3L70K1Gt@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1925991.Mh3L70K1Gt@thomas> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] RFC enabling dll/dso for dpdk on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 08, 2021 at 10:39:13PM +0200, Thomas Monjalon wrote: > 08/07/2021 21:21, Tyler Retzlaff: > > (2) importing exported data symbols from a dll/dso on windows requires > > that the symbol be decorated with dllimport. optionally loading > > performance of dll/dso is also further improved by decorating > > exported function symbols. [3] > > > > for (2) we would propose the introduction and use of two macros to > > allow decoration of exported data symbols. these macro would be or > > similarly named __rte_import and __rte_export. of note > > That's the same symbol declared in a single place > which is exported and imported. > So I don't understand the need for 2 macros. i may be misinterpreting your reply. you're saying there is no need for 2 because we use .def files? strictly speaking when exporting C symbols this is true. so yes, we could introduce only __rte_import and not bother with __rte_export. is that what you meant? i don't have any objection to just __rte_import alone but it is mandatory for data symbols.