From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6945FA0A0C; Fri, 9 Jul 2021 10:07:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2963F4014D; Fri, 9 Jul 2021 10:07:16 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 5C5AA40143; Fri, 9 Jul 2021 10:07:14 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="231433304" X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="231433304" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2021 01:07:13 -0700 X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="487967016" Received: from dpdk.cd.intel.com ([10.240.178.134]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2021 01:07:12 -0700 From: Jie Wang To: dev@dpdk.org Cc: xiaoyun.li@intel.com, Jie Wang , stable@dpdk.org Date: Fri, 9 Jul 2021 15:57:17 +0000 Message-Id: <20210709155717.103425-1-jie1x.wang@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] app/testpmd: fix testpmd doesn't show RSS hash offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch reapply Rx/Tx offloads configuration for all ports after the program configuring the device port. When the program configures the ports, the default Rx/Tx offloads are modified. So it is need to reapply Rx/Tx offloads configuration before testpmd showing offloads. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: stable@dpdk.org Signed-off-by: Jie Wang --- app/test-pmd/testpmd.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 1cdd3cdd12..7089ae216d 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2475,6 +2475,9 @@ start_port(portid_t pid) } if (port->need_reconfig > 0) { + const struct rte_eth_dev *dev = &rte_eth_devices[pi]; + int k; + port->need_reconfig = 0; if (flow_isolate_all) { @@ -2508,6 +2511,18 @@ start_port(portid_t pid) port->need_reconfig = 1; return -1; } + + /* Apply TxRx configuration for all ports */ + port->dev_conf.txmode = dev->data->dev_conf.txmode; + port->dev_conf.rxmode = dev->data->dev_conf.rxmode; + /* Apply Rx offloads configuration */ + for (k = 0; k < port->dev_info.max_rx_queues; k++) + port->rx_conf[k].offloads = + port->dev_conf.rxmode.offloads; + /* Apply Tx offloads configuration */ + for (k = 0; k < port->dev_info.max_tx_queues; k++) + port->tx_conf[k].offloads = + port->dev_conf.txmode.offloads; } if (port->need_reconfig_queues > 0) { port->need_reconfig_queues = 0; -- 2.25.1