From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4052A0C4B; Mon, 12 Jul 2021 03:48:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED200411BD; Mon, 12 Jul 2021 03:47:49 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2046.outbound.protection.outlook.com [40.107.220.46]) by mails.dpdk.org (Postfix) with ESMTP id 9CB2F4119E for ; Mon, 12 Jul 2021 03:47:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eYGfy3xmFjSaj2dsG+AdQMOIt8SeCxxCnAICxgxabCyphESyflAaJHu9fS+7zQ5DvQ71L7uULZCazoCcfP1zrZgkMgV+BxeYaLXVl4UOHXybH7QR8EaOFh5sq4In1ybIHLYto49BiV8TSt72r8ohunyDAEVGHNYv9i7ciQZTt31mVWSZjJlk7/zUWrb8OEqsaDv30P/aQb66dF5ty++qGi7Lf0+x/O+eKMaQTwr8rX0HxS+tHC79VkoEXMQsFHNN1QOqp2ruIg3ssnEx88vu3OMEdEkkzr9coezUvw0wyVHzFzlLguN22ryUzPpMx9VPrmeB5iXPKO9GKtQNw5l+dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3WHS4+y1MC7Wqkt3Mfoua9AgUjhNaCjxde6iAfwyUdE=; b=S4HolVUBiGUU3Nhf1tyrBvqxEbSKt08oev5XZPwhhypWbzDUcNaTSudPiiDrSZIfFl3aK0dIPE3wbR7kppAcSXztaxenmcZb9tmq6KsXnOaKZ8lJfrfyGvpjhxVrvSfvtY9n5XZetjdDm+XHm0YL332ntGrFSoku+4RQ8oD88C9l4MqmHQ9VVkeSZW2DyeIU5tR2icDVsJnv1CV4I09aRSW492/8WtRMHjpkITnWXs27A9JgZ0m6tVHbx4CUuUNeeLEzlanJEyA8OArRqtYM7M5FFxruYa4zcRGJsg+LBNrFsXYBWSVdCC8CZYkPCz+4gkqtMSAM0j2069uy3Ma64w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3WHS4+y1MC7Wqkt3Mfoua9AgUjhNaCjxde6iAfwyUdE=; b=VYJIk0OFsb2wV4DIxhfgu2teMHWJ7BoQDSE2WncQdJ18jUVLFwhrrvKvX63jjEkfgczy8tQXSyfkM4hsnTEyc12eNEFTTsJzTXIJTSTPF46q+nmte5JcTDomosNUpvmVxCbhoeFiY2KoYebpEIynm9zcL7HaXSc1UcVUMTjCHCGsqrjR7OdCiOHgzRnKVkXYYeMPEKOaL5dvDl0jb/JI7p2KOplmM1GXOqzA5Ow4EkrSgbvboA7IXWOkwr6CGZggHNa5AO9y/E0cna1Me9KC8NcZ5s4ILTXYa+x49m7gudJ49pxEQiKKp4623sLO3Pc19VGtdiEx0a3WWmLwzEofpg== Received: from BN6PR13CA0021.namprd13.prod.outlook.com (2603:10b6:404:10a::31) by DM6PR12MB4973.namprd12.prod.outlook.com (2603:10b6:5:1b7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.21; Mon, 12 Jul 2021 01:47:44 +0000 Received: from BN8NAM11FT013.eop-nam11.prod.protection.outlook.com (2603:10b6:404:10a:cafe::f1) by BN6PR13CA0021.outlook.office365.com (2603:10b6:404:10a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.11 via Frontend Transport; Mon, 12 Jul 2021 01:47:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT013.mail.protection.outlook.com (10.13.176.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4308.20 via Frontend Transport; Mon, 12 Jul 2021 01:47:43 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Jul 2021 01:47:29 +0000 From: Suanming Mou To: , CC: , , Date: Mon, 12 Jul 2021 04:46:39 +0300 Message-ID: <20210712014654.32428-12-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210712014654.32428-1-suanmingm@nvidia.com> References: <20210527093403.1153127-1-suanmingm@nvidia.com> <20210712014654.32428-1-suanmingm@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a584ee00-9251-485c-51b9-08d944d70aec X-MS-TrafficTypeDiagnostic: DM6PR12MB4973: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:249; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6xvOrNKC4zAcWUpkurZOirYoRgh4I0f+SVcUxJ1+A6NhoJL7kRKEK0JXAlTs6s6cwVNjm2nBLCwnFd8NVRsXXNjYl3MLXy/V/UcVhf6rOK7jw/eevRvX73fUAdhmbh9ZENigbXxY2DBx6ZjXvNQB/FqQunXjvHfe+Q7FFM0sljbzZLJfOOiPrgjbgbKiliv7V+TBMYhQK9Wu9sN45Ihlkt/KeZFBdhAgaK/rzb0dUzRvuhOyNlIfeCJPmi9wt0Ks/6XdX644j9GcPDoZ8Sh6wBWSpYUZGfHAlV03dqQhDBBiLbyZn/aBSDFTHZmy7YpmhYIHpH1atnNngfdNMcUa75iO0Xyr42PKH7+/tmpBs/ZWsFcYDcTkPJSkxN7euLk7D2cRkOPoojTr6NVmYpYdLubSVuQ1m+BmzLO8typfibWBs+KgBSwEtkPaY9nqWguuy6syFIfsph5GGnz8Xt/CsCOY4UelqKAUuwGNEtkVeWD+iueiUhiTIS06dyQrnd+Hh7Cuhy4sxj9vKqm1cvLrF9mZT/vJnREAx1Wp3RvI7iOGhA9VB2VLsy+rPEyz0L3WZ1O6jVncmBktXDhO5L5jmHuaCjdfS+VP+Ea9pERFWUiJuIgkXcCFby4nbalaEnepCDU9gVyJ8RMM6TDMZ+9IqDB/Kb61ts+JjTSLBG0OqvzxMAmguGkJDxsSYKGriqIpymc3/5HkIOY6t7Hv+ncdsPhZWhOazbmGPaLjE2goL4o= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(136003)(396003)(376002)(346002)(36840700001)(46966006)(336012)(478600001)(7696005)(5660300002)(2906002)(16526019)(26005)(186003)(55016002)(1076003)(6286002)(47076005)(36756003)(8936002)(82310400003)(34020700004)(8676002)(110136005)(6666004)(36906005)(82740400003)(4326008)(7636003)(54906003)(70586007)(70206006)(356005)(6636002)(316002)(426003)(2616005)(36860700001)(86362001)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2021 01:47:43.9789 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a584ee00-9251-485c-51b9-08d944d70aec X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT013.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4973 Subject: [dpdk-dev] [PATCH v5 11/26] net/mlx5: relax the list utility atomic operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Matan Azrad The atomic operation in the list utility no need a barriers because the critical part are managed by RW lock. Relax them. Signed-off-by: Matan Azrad Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_utils.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c index 13c7dbe1c2..daecf37575 100644 --- a/drivers/net/mlx5/mlx5_utils.c +++ b/drivers/net/mlx5/mlx5_utils.c @@ -50,13 +50,13 @@ __list_lookup(struct mlx5_list *list, int lcore_index, void *ctx, bool reuse) if (list->cb_match(list, entry, ctx) == 0) { if (reuse) { ret = __atomic_add_fetch(&entry->ref_cnt, 1, - __ATOMIC_ACQUIRE) - 1; + __ATOMIC_RELAXED) - 1; DRV_LOG(DEBUG, "mlx5 list %s entry %p ref: %u.", list->name, (void *)entry, entry->ref_cnt); } else if (lcore_index < RTE_MAX_LCORE) { ret = __atomic_load_n(&entry->ref_cnt, - __ATOMIC_ACQUIRE); + __ATOMIC_RELAXED); } if (likely(ret != 0 || lcore_index == RTE_MAX_LCORE)) return entry; @@ -181,7 +181,7 @@ mlx5_list_register(struct mlx5_list *list, void *ctx) list->gen_cnt++; rte_rwlock_write_unlock(&list->lock); LIST_INSERT_HEAD(&list->cache[lcore_index].h, local_entry, next); - __atomic_add_fetch(&list->count, 1, __ATOMIC_ACQUIRE); + __atomic_add_fetch(&list->count, 1, __ATOMIC_RELAXED); DRV_LOG(DEBUG, "mlx5 list %s entry %p new: %u.", list->name, (void *)entry, entry->ref_cnt); return local_entry; @@ -194,7 +194,7 @@ mlx5_list_unregister(struct mlx5_list *list, struct mlx5_list_entry *gentry = entry->gentry; int lcore_idx; - if (__atomic_sub_fetch(&entry->ref_cnt, 1, __ATOMIC_ACQUIRE) != 0) + if (__atomic_sub_fetch(&entry->ref_cnt, 1, __ATOMIC_RELAXED) != 0) return 1; lcore_idx = rte_lcore_index(rte_lcore_id()); MLX5_ASSERT(lcore_idx < RTE_MAX_LCORE); @@ -207,14 +207,14 @@ mlx5_list_unregister(struct mlx5_list *list, } else { return 0; } - if (__atomic_sub_fetch(&gentry->ref_cnt, 1, __ATOMIC_ACQUIRE) != 0) + if (__atomic_sub_fetch(&gentry->ref_cnt, 1, __ATOMIC_RELAXED) != 0) return 1; rte_rwlock_write_lock(&list->lock); if (likely(gentry->ref_cnt == 0)) { LIST_REMOVE(gentry, next); rte_rwlock_write_unlock(&list->lock); list->cb_remove(list, gentry); - __atomic_sub_fetch(&list->count, 1, __ATOMIC_ACQUIRE); + __atomic_sub_fetch(&list->count, 1, __ATOMIC_RELAXED); DRV_LOG(DEBUG, "mlx5 list %s entry %p removed.", list->name, (void *)gentry); return 0; -- 2.25.1