From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35F67A0C48; Tue, 13 Jul 2021 10:48:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F144F41281; Tue, 13 Jul 2021 10:45:58 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2042.outbound.protection.outlook.com [40.107.223.42]) by mails.dpdk.org (Postfix) with ESMTP id A3A7F4123C for ; Tue, 13 Jul 2021 10:45:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hvhckTw4RuAab30n3SKZPWbyCNbRGlAFDGdGzT+qUJPXsKw1S+0HEr7M6O2qDS5qPVjO94hfLn9lPNPCUnJKVi2DMLI/KbsQy+p1gSCsdGmeVzcQipdNpHqGDDEs3zv56+BwH4BBv51jAC7Vw0O7vQ9SJIKvTNY6BeDDVipvJH9p2T/OFvawv5bQeOL4mfLRerQJrZzTfC4Sfbh9Pxm+G2fRl5amjBlG5wIxewW9627okCW081uAbAb1GOoKWDHODjbOX6PqlAqPocUzWbwTr8TT/baq6qAXymroqd7F2KpUvRu1P12lbRo4FxZhiIYjsbxTvJUODRq12LtSLY5Upw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N+GN/q/xffVPrJb//urff1S6AxS4RYuu4sXwkCSHlFc=; b=lDHbG8qGNrvg8aYITvlkeqtQXufqsRs4x4Lq8TiJXYV4Ez398NKGKPgRXfTrdfjWbrL5J5HvvxGZxZIGWk9P38BMoqnulBoLauu2wSkyaDU8SS6yVdZxB/b9FqscY1pFLpXkK5ou3eWNPiI/VVTWep0uYG0Aend4qc3RCIW6h2nm+FvzoVOi2R8htkG4MiRtLGmrOIyuCbLDBWBqPTX2iO6ZczitBT6R0f2KCWoyn7iK4gnIXPTcQfzWYnrSejMXKHe9BUT5+bxKO/TWx2Yz08r/orv6fXUJDSMDEkhX9DqqkbSS+y2ERtRRyrnjpQgONSBBcWwOIc8YeXdWKjgjUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N+GN/q/xffVPrJb//urff1S6AxS4RYuu4sXwkCSHlFc=; b=rc2QRQI10OwuNS5IQFRQr6/AGsqDeSSIMxrtj4qWbKkm9O+jUxFABp+Nu16r/ktgk/V/qHvk3Wau6omVMGVDh+hpsa6dyFQXdxAMCqN1uc0aKn6sDjU3QFPnaUXXFLg0OUHPJ1Wbn8vW171JAil5QKxZzIqv6e2MT6up0zmoiSRdtCzuHC9Jw8YPnYJJueEWs9vgcKmsPTG5iBsVFszRJUh2FpF+Q3EhV1SX4dVh8xyxe6RHYpf5ctUeMnuhxjhTA3RVsFDkyGJ4l3/pF8URWJPFl36eoZP06pONdviflyXPCUDRGbU2DTHtPRK4/GLrlnuNQ8/gWHF9cCMnslLabg== Received: from DM5PR19CA0018.namprd19.prod.outlook.com (2603:10b6:3:151::28) by BN6PR1201MB0179.namprd12.prod.outlook.com (2603:10b6:405:59::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.21; Tue, 13 Jul 2021 08:45:55 +0000 Received: from DM6NAM11FT014.eop-nam11.prod.protection.outlook.com (2603:10b6:3:151:cafe::a5) by DM5PR19CA0018.outlook.office365.com (2603:10b6:3:151::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.19 via Frontend Transport; Tue, 13 Jul 2021 08:45:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT014.mail.protection.outlook.com (10.13.173.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4308.20 via Frontend Transport; Tue, 13 Jul 2021 08:45:55 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 13 Jul 2021 08:45:53 +0000 From: Suanming Mou To: , CC: , , Date: Tue, 13 Jul 2021 11:44:55 +0300 Message-ID: <20210713084500.19964-22-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210713084500.19964-1-suanmingm@nvidia.com> References: <20210527093403.1153127-1-suanmingm@nvidia.com> <20210713084500.19964-1-suanmingm@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a940fa18-9863-47fa-012f-08d945daa0e2 X-MS-TrafficTypeDiagnostic: BN6PR1201MB0179: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:628; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yKTpErY6dWzb+HGCfM6zCTMWIf9bqwC5vFIm9es5S2t/X4eQniTSDg5hBwZ+ErYPwNeLMxCeSqDNmLjEQp76/cMJn568KYFPU008HoeQGszLEE2h17Hk5CNG07F8DgBfOX9KwawEPf78+dV0+QzETmEspJVbT3n4HvRQ4ENDQug/YHL1e+Qb6podFtVM7+aY2xRwD/VkPLG2gP1OXcOxGFTrx8lSJUHPdpuF57wQUvZwy+/z8nCcJQ+WO2nmWDY8zVvGINytT+hIX97DbMYX/TYJkDZ0ZMoCyn+mAsWv3zHTXSutYaCanXQwvXoFTdGxh6jk2tJiyPhOKiid9Tv9C+R3SGPQ20G5rkqi0NdYldx5Nu+bkjzdW6mGU6MKlLeuHFNsuKJfsIVLJ+dsehS9nmZ/kdSIvbZKaun6rKZndvhYiXzc6llX6CAYe+Jp/U1hHlIJsSfyKCmrqUSvN7L6Hw/ORU5OQKglwIZfO8Rjtf3Q6vVl/l4aI3zj/HZHoGZQQKmIABzLM9USMaqhIFdidpqudNH18yOqXWrSG1Fq9lpBibjZdJzpNdETR2IgSsTK7Azymb/0UmJ+xcJqR/Mshr5VayfDNbtGRnEPJtSzXaVo3zYXc3BHknFgeGPDJxe6wSGjk2fA0XWtYZ2dYYtqPEjtM6zs5DxlvnAMz/qNbgpX7VkUX2PUlL1B0Q7E0FiXJfDDnZ4iFKE92jr1mJA7sm1gFFQlY3ZIA8fVasu17R4= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(136003)(346002)(376002)(396003)(36840700001)(46966006)(36906005)(316002)(478600001)(16526019)(7696005)(186003)(26005)(54906003)(8936002)(6286002)(1076003)(336012)(2906002)(36756003)(36860700001)(6636002)(426003)(8676002)(2616005)(4326008)(82740400003)(110136005)(55016002)(47076005)(356005)(82310400003)(83380400001)(70586007)(7636003)(86362001)(34020700004)(5660300002)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2021 08:45:55.2629 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a940fa18-9863-47fa-012f-08d945daa0e2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT014.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0179 Subject: [dpdk-dev] [PATCH v6 21/26] net/mlx5: adjust the hash bucket size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" With the new per core optimization to the list, the hash bucket size can be tuned to a more accurate number. This commit adjusts the hash bucket size. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 2 +- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5_defs.h | 6 +++--- drivers/net/mlx5/mlx5_flow.c | 5 ++--- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index b04e5f8ba6..969d265350 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -50,7 +50,7 @@ #include "mlx5_nl.h" #include "mlx5_devx.h" -#define MLX5_TAGS_HLIST_ARRAY_SIZE 8192 +#define MLX5_TAGS_HLIST_ARRAY_SIZE (1 << 15) #ifndef HAVE_IBV_MLX5_MOD_MPW #define MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED (1 << 2) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 640d36c6be..3b5c7840a8 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -376,7 +376,7 @@ static const struct mlx5_indexed_pool_config mlx5_ipool_cfg[] = { #define MLX5_FLOW_MIN_ID_POOL_SIZE 512 #define MLX5_ID_GENERATION_ARRAY_FACTOR 16 -#define MLX5_FLOW_TABLE_HLIST_ARRAY_SIZE 4096 +#define MLX5_FLOW_TABLE_HLIST_ARRAY_SIZE 1024 /** * Decide whether representor ID is a HPF(host PF) port on BF2. diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h index 906aa43c5a..ca67ce8213 100644 --- a/drivers/net/mlx5/mlx5_defs.h +++ b/drivers/net/mlx5/mlx5_defs.h @@ -178,15 +178,15 @@ sizeof(struct rte_ipv4_hdr)) /* Size of the simple hash table for metadata register table. */ -#define MLX5_FLOW_MREG_HTABLE_SZ 4096 +#define MLX5_FLOW_MREG_HTABLE_SZ 64 #define MLX5_FLOW_MREG_HNAME "MARK_COPY_TABLE" #define MLX5_DEFAULT_COPY_ID UINT32_MAX /* Size of the simple hash table for header modify table. */ -#define MLX5_FLOW_HDR_MODIFY_HTABLE_SZ (1 << 16) +#define MLX5_FLOW_HDR_MODIFY_HTABLE_SZ (1 << 15) /* Size of the simple hash table for encap decap table. */ -#define MLX5_FLOW_ENCAP_DECAP_HTABLE_SZ (1 << 16) +#define MLX5_FLOW_ENCAP_DECAP_HTABLE_SZ (1 << 12) /* Hairpin TX/RX queue configuration parameters. */ #define MLX5_HAIRPIN_QUEUE_STRIDE 6 diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 45e90bb245..1c5d4c283a 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -8881,7 +8881,7 @@ mlx5_flow_tunnel_allocate(struct rte_eth_dev *dev, DRV_LOG(ERR, "Tunnel ID %d exceed max limit.", id); return NULL; } - tunnel->groups = mlx5_hlist_create("tunnel groups", 1024, false, true, + tunnel->groups = mlx5_hlist_create("tunnel groups", 64, false, true, priv->sh, mlx5_flow_tunnel_grp2tbl_create_cb, mlx5_flow_tunnel_grp2tbl_match_cb, @@ -8990,8 +8990,7 @@ int mlx5_alloc_tunnel_hub(struct mlx5_dev_ctx_shared *sh) return -ENOMEM; LIST_INIT(&thub->tunnels); rte_spinlock_init(&thub->sl); - thub->groups = mlx5_hlist_create("flow groups", - rte_align32pow2(MLX5_MAX_TABLES), + thub->groups = mlx5_hlist_create("flow groups", 64, false, true, sh, mlx5_flow_tunnel_grp2tbl_create_cb, mlx5_flow_tunnel_grp2tbl_match_cb, -- 2.25.1