From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1BBCA0C49; Wed, 14 Jul 2021 09:31:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E21340140; Wed, 14 Jul 2021 09:31:12 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2071.outbound.protection.outlook.com [40.107.237.71]) by mails.dpdk.org (Postfix) with ESMTP id 529344003E; Wed, 14 Jul 2021 09:31:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bjhUL5sUl3Rq+murGS41sGa1rxShQFYVXrRhhrnFNiNY2/8lySWK1Ud1ghCrdv+qU09Npu1qjLIjFOF2tbv0LGa+PWO+oPy14v1B4k6vpySMGSSy5peGgnx+LpRGCAzCz5Zat4DVNPrfxGs1o3MZOlRFDpq6U/7o1piasXsUNzB3UBk7KqPLH/ga4Baz6TkxhPqtk7P6cY4fdDx83JO2KFZmQP5kHfEWybawv/QIA3ejY2nx6XiX7BX6i+SycmonAfBPhV3V4nrlpniYbcw6PicnmLtLw+upqqeHkFSGTirOFEhdJQDP9fJZlhjUKNhDBVDhgTToL44GbswWYU2QfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FjB1zx4jPcnUYz2IbHT1jLmRXAgVfKlI9isLc7jcI/A=; b=TZXAJPiFF8+hqQn2zn61DFiKy5Ao4uWB6RDptSfxFxBWhd5THlmMgf8PljgXoVZC1neWwlO3vOz52W0fBLkrkTh77mc6vUo3Q821A+34M/WE/XpYU8m/JgeXIcfe1Q74n/ThP/BhSH0qOaPvH+5WI95zurj1kygRhqTMLIlPVyTzpj+wal6AMUkvgklw8v/oQrs2oi/unWBi7QOvmTD5TKMmz46W3LZmuluoI8vauSKYFaB4s0lAq7PClQUNUEWDU9ByKYwsCSsulig8y6q17ZRFAIJ3aLrSzQ6Y4ugvx621GGEmk4tuaoV6NC2De2qcfSz9cBPIJL+d40PtczUPIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FjB1zx4jPcnUYz2IbHT1jLmRXAgVfKlI9isLc7jcI/A=; b=Yus06L94Dsl5VXDjDmdio7hLGkd+iaPGc+VsJJM+Sg1qCtOInIWrKIPDHkxlGo7v3Aw5u+VQr1sT8x/sg282IEjL2rbXqC8z6FvVVS1qG+sARPk32gvbOwMgxgPP5ShtOSLbte7wTpcBb/5C9sojQKtnOySI3CEHeYrw/oCZixDe0rqU3jekvRLgliz1/DO+hGcSyfS31NQCgnFoMd8c1u9JowVeVnZxL9eoZbuew2E0hs8qpo8J70fGQ2tTItgPQ4dw6p4wLk6ljByfQUd6XSEACsyq/Qwkvhd2MA/d40nYAqT1fOxDHU/pPpJuHUnMSsoccjfC6R73jUWswJfBRg== Received: from DM8PR12MB5462.namprd12.prod.outlook.com (2603:10b6:8:24::11) by DM4PR12MB5088.namprd12.prod.outlook.com (2603:10b6:5:38b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Wed, 14 Jul 2021 07:31:09 +0000 Received: from DM8PR12MB5462.namprd12.prod.outlook.com ([fe80::d88b:a738:82fb:e407]) by DM8PR12MB5462.namprd12.prod.outlook.com ([fe80::d88b:a738:82fb:e407%9]) with mapi id 15.20.4308.027; Wed, 14 Jul 2021 07:31:09 +0000 From: Jack Min To: Raslan Darawsheh CC: Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Dekel Peled , Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IPv6 frag Thread-Index: AQHXdvSxxCXN54e2NkqW8LHCMWZn9atCFlSA Date: Wed, 14 Jul 2021 07:31:09 +0000 Message-ID: <20210714073029.7lw2kpvk5gdjlq77@nvidia.com> References: <88ccba94f213b6715f34038b6b400a5bab889aa3.1625624590.git.jackmin@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b389c4a-77cc-4f96-f7af-08d94699596d x-ms-traffictypediagnostic: DM4PR12MB5088: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Nzqfh0m3IZMMnkkDo9QAjpT/oZiYcvyCPxntReVrkHXSTJRG22pSGfH6rGOr74mvPSj7wUuNmyyDaxDwYF5wLG9UTvySHgr+Q2DxMLTzyvFFxeX3HH2MLcSxb36KmxhGKE7U61E7d5uQjLplVsAOMMRCNlR7+LtIFMatfEXl/DqZEL3+sotMhxgIvNFwB89ZrKzhBA63JhiSRg2BwivtHeXNZOVE/4jPF0S5+IRqBUFGnCUuhLik5j7TXWxWThTJVbnu7eQHWi39SWYzncPmgX0tWwwzmdNcpIYmg3qeYs4cJcHZ1BIjC5s5dCw8UgAyNrbSIsUL11BAy4aGvtx+hH6K/mV9pRdPmgDFvn4k3kpSCiPgRLmX1crd0c5+smseexI4B1TybxYfaBIHjItzdi34frXiRvZA0G9XRtfAIv0JwjVT1HK5F43Vk1lRV4BnTfrMgWuH2Qt3RgkOQ84c2Cgy8Z1PfP4YHcS17BoaeI9VWaIeSUxMxyWZi4xTtp/7DgINuoDukdo4Jdq4JH4nVDeDLgfLNG4BKstpV+HzFDAxpe2q0Zn0dvCV+dIviABGz/3Pjvscc97vcDCXppE9V/D68VZv8eTgmGW55O3iyBwZ2HAGjt2cZ2ZjWpgN/H70Q+iKVpDnRb1MmTBUqSimh3MtTChI6bGmneoUTEr3v9hucuKLeoItuYAziDiSm2yXXNCTqIbPX8kjys5HY1M2zQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR12MB5462.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(396003)(136003)(376002)(366004)(54906003)(2906002)(86362001)(66446008)(66476007)(66556008)(64756008)(316002)(53546011)(26005)(83380400001)(6506007)(4326008)(6636002)(478600001)(91956017)(186003)(5660300002)(8676002)(6486002)(71200400001)(122000001)(8936002)(6512007)(66946007)(76116006)(2616005)(38100700002)(1076003)(6862004)(37006003)(450100002)(36756003)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rJMCqZ5OjNTgt7vuFgM3UAqv4TitkdjOmm8Lu2AIWcnlJgoY+injzVXUaRPl?= =?us-ascii?Q?o1rQg+ycECnNX6I9tv2VhcH57WV8ksRRAGFBn+Y0ON2gqaVZA6HLxuK53ZGE?= =?us-ascii?Q?gvfondpP4kar36YKT/zGSCeB8ane2ayTW/5dRtk+Nehc/tW9OGDltkBBnFbe?= =?us-ascii?Q?Q5K6JlADEOqlfy5tG5hJlaHIhgk5ys5OoKH52JSazqEUbwfDfbYdDRuM0Cc8?= =?us-ascii?Q?kuqygfJB6oMtTmD2OkriFnOLsyr+XtZZtmHGQpeJM5nLvKjFI2i6BWaDE00Q?= =?us-ascii?Q?tmKA+C5Jion09bR6PrObdaW+S7Zj1J7YxMnQVf8wzhC/fSbuISW+yxPHv+S8?= =?us-ascii?Q?oTRpjJRSF7xkvsCZM2Uvcg32ngIAAf6g2LmdrHeETGEW9hdhA6mJ/Xom/i60?= =?us-ascii?Q?sQzDBGJNW6Oa6fSlit37ueXCzetcbewuonbgn/5IIjua8Rffh/4gzkpDqSLm?= =?us-ascii?Q?cH63gE7RFypUn93cJNdjq6vZ2U3/eQlb3fsDkXT+clZoG3cJrOSbzKAuRvEL?= =?us-ascii?Q?mOCWpFi9AizsFZ93WK+f1OJlfaCc9Q2CVF21KrQd3/OGR0RpWjhn4DQflT1W?= =?us-ascii?Q?vJ/LESW++VhPa61b2HFDO3J+5CUmID3dbvH3wr6wQwKKS5zLiZT0EX1DEBqt?= =?us-ascii?Q?y0uvu9nPSO9lAlmo9TQvaBYImsGu1wQXWO6KuwwKuubjJQGYtnyI0RfQRuj6?= =?us-ascii?Q?V16DEyrxi1ocFCJLRmsjfZfrppp8Z0vY36Gb9jjipLrK2yRha+WBtKR486mU?= =?us-ascii?Q?Fd8gYkel9z73SnojlieQMxq0uVRX0BaC8iD2CZkLCFExWf+MsSOKWooP0/bE?= =?us-ascii?Q?0pWsAb3IF56gdgmAAzDSy+f6oWy7xAQ61opAdRGf4O1O5BGc1AoYz6Owi2F5?= =?us-ascii?Q?XcBKqKViQUyWEj3ixwoQPsmYGRPVa5e6yU5DROxFAC6iJbf5a13iB8W1EMcn?= =?us-ascii?Q?aAdm4BMrGc4z/5L/V7p7RaJtLtiplspoTmhdX+IFH4+c93kXFCnpdA4fzY0G?= =?us-ascii?Q?rLy2MH2tbJfqfwa+//m51svhQPIKLCSt96/3QIis6XqiyXzNvePKCnbHx1Ig?= =?us-ascii?Q?0gQcPXPCfVxU+q6YIogqSQsmDxiCHQwvdcwYIHDrgqOq0ebofDKryBkFmETg?= =?us-ascii?Q?kI/3j5FT2NZGmjM2EM6KqnS9L7rXyMkvpxFmv/ApbbvIVkIwILJriAAJ7l2z?= =?us-ascii?Q?9p9maMb3XZ1cJCCfFIk2lCZjUxaIaiIfYxGVclbnTq1ejdaY8nY6U83TH/tI?= =?us-ascii?Q?vIvkL+H0sT14rckZ69+EItQSTB7yBwjar+cfHJ2vYjy3KL42Z/NI7oB1UX4F?= =?us-ascii?Q?oItVh0fmosd1QoVaiTaabRe2?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5462.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b389c4a-77cc-4f96-f7af-08d94699596d X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 07:31:09.2332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5E0HUOJDRcQZGC0g+K6kXxXWsqgeuWyisQqCOyE7K+iVm0TH0+xb7YSAAon8APNVOqHkyzr4CGzO/fXCxIC9jQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5088 Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IPv6 frag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 21-07-12, 08:05, Raslan Darawsheh wrote: Hey, > Hi, >=20 > > -----Original Message----- > > From: dev On Behalf Of Xiaoyu Min > > Sent: Wednesday, July 7, 2021 5:33 AM > > To: Matan Azrad ; Shahaf Shuler > > ; Slava Ovsiienko ; Dekel > > Peled ; Ori Kam > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of = IPv6 > > frag > >=20 > > IPV6_FRAG_EXT item is missed for RSS expansion which causes flows like > > [1] are wrongly expanded. > >=20 > > Different from other items, IPV6_FRAG_EXT hasn't next field because HW > > only support to do hash of UDP/TCP for non-fragment. > >=20 > > This MLX5_EXPANSION_IPV6_FRAG_EXT node in RSS expansion graph only > > helps > > RSS expansion function to locate right node in graph from which start > > to expand. > >=20 > > Fixes: 0e5a0d8f7556 ("net/mlx5: support match on IPv6 fragment > > extension") > > Cc: stable@dpdk.org > >=20 > > [1]: > > flow create 0 ingress pattern eth / ipv6 / udp dst is 250 / vxlan-gpe / > > ipv6 / ipv6_frag_ext / end actions rss level 2 types ip end / end > >=20 > > Signed-off-by: Xiaoyu Min > > --- > > drivers/net/mlx5/mlx5_flow.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > >=20 > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.= c > > index 1b682ac8ed..90b8cf6692 100644 > > --- a/drivers/net/mlx5/mlx5_flow.c > > +++ b/drivers/net/mlx5/mlx5_flow.c > > @@ -134,6 +134,7 @@ mlx5_flow_is_rss_expandable_item(const struct > > rte_flow_item *item) > > case RTE_FLOW_ITEM_TYPE_MPLS: > > case RTE_FLOW_ITEM_TYPE_VXLAN_GPE: > > case RTE_FLOW_ITEM_TYPE_GRE_KEY: > > + case RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT: >=20 > Adding IPV6_FRAG_EXT to the list of expandable is not accurate, > Assuming HW support matching on L4 info after frag - which I think it doe= sn't. > It will lead that the first frag will get different hash than other frags= since it the only one which contain info of L4 header > This will lead to different RSS spreading and that's not correct. No, it will not expand to any items because the .next field is empty of ent= ry MLX5_EXPANSION_IPV6_FRAG_EXT in mlx5_support_expansion[]. -Jack >=20 > Kindest regards, > Raslan Darawsheh=