From: Richael Zhuang <richael.zhuang@arm.com>
To: dev@dpdk.org
Cc: zhiminx.huang@intel.com, david.hunt@intel.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2 1/1] test/power: fix CPU frequency check
Date: Wed, 14 Jul 2021 18:44:05 +0800 [thread overview]
Message-ID: <20210714104405.23917-2-richael.zhuang@arm.com> (raw)
In-Reply-To: <20210714104405.23917-1-richael.zhuang@arm.com>
For acpi_cpufreq and cppc_cpufreq, both cpuinfo_cur_freq and
scaling_cur_freq exist. For pstate, only scaling_cur_freq exists.
And value in scaling_cur_freq and cpuinfo_cur_freq may not be the
same. For acpi_cpufreq and cppc_cpufreq, we should check
cpuinfo_cur_freq but not scaling_cur_freq. So here change the
check sequence to make sure it works for all cpufreq drivers.
Besides, add rounding for pstate driver.
Fixes: ff6dfb8e492f ("test/power: fix CPU frequency check")
Cc: david.hunt@intel.com
Cc: stable@dpdk.org
Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
---
app/test/test_power_cpufreq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c
index b8fc53925c..1a9549527e 100644
--- a/app/test/test_power_cpufreq.c
+++ b/app/test/test_power_cpufreq.c
@@ -62,13 +62,13 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo)
int i;
if (snprintf(fullpath, sizeof(fullpath),
- TEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) {
+ TEST_POWER_SYSFILE_CPUINFO_FREQ, lcore_id) < 0) {
return 0;
}
f = fopen(fullpath, "r");
if (f == NULL) {
if (snprintf(fullpath, sizeof(fullpath),
- TEST_POWER_SYSFILE_CPUINFO_FREQ, lcore_id) < 0) {
+ TEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) {
return 0;
}
f = fopen(fullpath, "r");
@@ -85,7 +85,7 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo)
freq_conv = cur_freq;
env = rte_power_get_env();
- if (env == PM_ENV_CPPC_CPUFREQ) {
+ if (env == PM_ENV_CPPC_CPUFREQ || env == PM_ENV_PSTATE_CPUFREQ) {
/* convert the frequency to nearest 100000 value
* Ex: if cur_freq=1396789 then freq_conv=1400000
* Ex: if cur_freq=800030 then freq_conv=800000
--
2.20.1
next prev parent reply other threads:[~2021-07-14 10:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 8:44 [dpdk-dev] [PATCH v1 0/1] test/power: check cpuinfo cur freq before Richael Zhuang
2021-07-14 8:44 ` [dpdk-dev] [PATCH v1 1/1] test/power: check cpuinfo cur freq before scaling cur freq Richael Zhuang
2021-07-14 9:15 ` David Hunt
2021-07-14 9:23 ` Richael Zhuang
2021-07-14 10:13 ` David Hunt
2021-07-14 10:29 ` Richael Zhuang
2021-07-14 10:44 ` [dpdk-dev] [PATCH v2 0/1] test/power: fix CPU frequency check Richael Zhuang
2021-07-14 10:44 ` Richael Zhuang [this message]
2021-07-14 12:23 ` [dpdk-dev] [PATCH v2 1/1] " David Hunt
2021-07-15 1:44 ` Richael Zhuang
2021-07-20 15:20 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714104405.23917-2-richael.zhuang@arm.com \
--to=richael.zhuang@arm.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=zhiminx.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).