From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC96DA0C43; Wed, 14 Jul 2021 16:13:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC10540E3C; Wed, 14 Jul 2021 16:13:28 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2080.outbound.protection.outlook.com [40.107.92.80]) by mails.dpdk.org (Postfix) with ESMTP id 946C54069F for ; Wed, 14 Jul 2021 16:13:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RghlSkVd2CBb12lB13zJObDSJhKU2aukZjtjLqpVSonswrhlJqn4dNzTKVsxKRp/1tYzZy82CkvAodWuKlwNGFA8AWFPMNIDJBCa3Y5ZhW9jz9m4YvTRa9ilLaL7uEubASrr57oSwWhdaTw689bBL5Z6mMaHXjLmlJPHyE0cRDe1Y0dbt4VVOP+dhX+tUrl5//B3hjAmm4C2A93jrb3M4CzdhK97hMNgPo/oKINLVgkd2nCnIcH/eCrM8L1aSYAXzy5zuBa0X6QRutSn4f/O8cEGrgjFKOmZDbCWN//9blHtnp8VMryvr75Djfk77/lZV1tk+sGuTNFjGWQ3wOeHbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBk+SFtiLYDfsk7wtBnO8RuwJJdSYFhIsnMdh6PL0A0=; b=fty9HMUkmnSZjjpe1Cm1L3zCRGjMY/5CtochQVc1h3d8fujhnH8WFE+YrUmRW9Mpg6UQDhYx6wtzx0yj5LuDK6IHssbE7RszkgLjwRSzTvolOgz6y30ysH/8FPIXFw7l48CzTUZl8s/8nd1ILilNEWSGkMl8CQGwVmKaFZXUQs1YXcpiUmnN6hMULyGkCdd692A4TcgcwLDMfjkQgDdYwKXv7RzeC+2aiRlOGaXZedbC2xbWgtCms1ws4F3QNdqlcHbDtJW+nUVamAYAURNo/xh+pT5vYlMqkm61DmHHsPZCc/ucoOTPP13VQw8BPIpQSOO0pXQWC9hqlwqtiSbzyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBk+SFtiLYDfsk7wtBnO8RuwJJdSYFhIsnMdh6PL0A0=; b=fe40pqc/D2mXXXXGjG7XPbj/7fedx7BziRZkpm2in5axGGnFSXeU53dZE66msirNe88Jejxsh4565BT83D1g8QZMZDoanFTDO/gHdLHwtdt2LN7XD6H1arU0PKuNrEregUEw/AWmbU4m+5fqJzYkeCh/vLI1ccjWgEvdvCDluN10QppM8ELfEoZGYh6Sbm6m4/0OCxnalpp2MYf07Vk5VckOxvS8OGb+ZVxk+gFfTP4smNeyJqyDpOeQ42aaojVpB04X8dJAXFwux4xYid2qez6iPmIea5WCNld4KXJJ+TqF0ySmm1bPB5LaNJddOycUEtNjdndIrDFx2ZGgbH5DpQ== Received: from MWHPR04CA0060.namprd04.prod.outlook.com (2603:10b6:300:6c::22) by BL0PR12MB2466.namprd12.prod.outlook.com (2603:10b6:207:4e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.26; Wed, 14 Jul 2021 14:13:26 +0000 Received: from CO1NAM11FT016.eop-nam11.prod.protection.outlook.com (2603:10b6:300:6c:cafe::78) by MWHPR04CA0060.outlook.office365.com (2603:10b6:300:6c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.22 via Frontend Transport; Wed, 14 Jul 2021 14:13:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT016.mail.protection.outlook.com (10.13.175.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4331.21 via Frontend Transport; Wed, 14 Jul 2021 14:13:26 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 14 Jul 2021 14:13:24 +0000 From: Suanming Mou To: , CC: Date: Wed, 14 Jul 2021 17:13:00 +0300 Message-ID: <20210714141300.15280-1-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 61b0676d-e0a7-4658-f1c8-08d946d18c2c X-MS-TrafficTypeDiagnostic: BL0PR12MB2466: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1107; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VREMJy0ahP+xfmS4WsWIAWHtN5S5+EB1Y19+L7wOb7dEJ9lfYtpoNdGgTJ+lsWtd9N9zQXF1zIiDzEgoFXJ9GNgN3v8HEJC+eN8GF1/zQydhOisCUok6qxguQ8mgCC+KQRmrc87y60Quc2kvvykc9HZq7pxla1SscfUfxchIJIj+Nv+Gsl+eb+W2p7x7/M02BL8U0aoZv1l5MqzuhriznHxZxvc7cndgxz3YaYS874MvLY6IeaS19mNy9BSkzmdAaSYa1ySnwWOug3yDuW211MmpwhyTYVxkEoM59oOaDVBTEN2zb3u9u7rf49Ge7QHrKaFHdliOeVrG5cpXxosrRpGWgQ5GiAjdh93FfAefXWaxAI4jvoXUKPXVyx3g/4b0Og4sLeB3nXWzdgs4Z95VRXXXhuLUsx5LDXJaKojWQ/BDI+A5DFq2a04B9pykLz4BhrjbFwK2YkVLBsgAijrm5cGth26JWaIW6J2Gc2L5MlmIv70TsJK1Y1fOjQNxucevJPD7yW08Bj3ZbTE1eqTHsx30+4tSaZnk7labVht2xXoBn2vqLt1mAyla3KV0VXclQEOpYjFc9lPfXz/sd+IiYUM/izO36ZjsE1abvOl054lsWsJctDv/Sxcg9a+T2/EDEsADSZOiB8LPao8uOPgGq0gSycZ+WmXa/C7H/dV39YhbIFnyAQZbcyD2KjcEFCYBDRpPvfz/YHlIgIcAIiynnIUPY8AqWzZAWnkYW8yS0Xw= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(136003)(39860400002)(376002)(396003)(36840700001)(46966006)(36756003)(70206006)(1076003)(70586007)(8936002)(47076005)(34020700004)(82310400003)(6286002)(316002)(7636003)(86362001)(356005)(336012)(2906002)(83380400001)(110136005)(82740400003)(426003)(2616005)(36860700001)(7696005)(5660300002)(16526019)(478600001)(26005)(6666004)(8676002)(4326008)(36906005)(55016002)(186003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2021 14:13:26.2491 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 61b0676d-e0a7-4658-f1c8-08d946d18c2c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT016.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2466 Subject: [dpdk-dev] [PATCH] eal: add rte_exit() main lcore limitation description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently, rte_eal_mp_wait_lcore() function will be called by rte_exit() as the routine below: rte_exit() -> rte_eal_cleanup() -> rte_service_finalize() -> rte_eal_mp_wait_lcore() As rte_eal_mp_wait_lcore() is announced can only be called from main lcore, rte_exit() gets the limitation implicitly as well. Or once rte_exit() is called from a worker core, the rte_exit() procedure will get stuck in the rte_eal_mp_wait_lcore() function as the core status is still running. This commit adds the limitation to rte_exit() to make things clear. Signed-off-by: Suanming Mou --- lib/eal/include/rte_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h index d5a32c66a5..ebe2869cc3 100644 --- a/lib/eal/include/rte_common.h +++ b/lib/eal/include/rte_common.h @@ -857,7 +857,7 @@ rte_str_to_size(const char *str) * Function to terminate the application immediately, printing an error * message and returning the exit_code back to the shell. * - * This function never returns + * To be executed on the MAIN lcore only. This function never returns. * * @param exit_code * The exit code to be returned by the application -- 2.25.1