From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2C47A0C4B; Thu, 15 Jul 2021 05:43:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EED74014D; Thu, 15 Jul 2021 05:43:33 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 0883640143; Thu, 15 Jul 2021 05:43:31 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10045"; a="271577275" X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="271577275" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 20:43:29 -0700 X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="494979963" Received: from dpdk.cd.intel.com ([10.240.178.133]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 20:43:27 -0700 From: Jie Wang To: dev@dpdk.org Cc: xiaoyun.li@intel.com, andrew.rybchenko@oktetlabs.ru, Jie Wang , stable@dpdk.org Date: Thu, 15 Jul 2021 11:33:14 +0000 Message-Id: <20210715113314.8837-1-jie1x.wang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210713170401.252445-1-jie1x.wang@intel.com> References: <20210713170401.252445-1-jie1x.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3] app/testpmd: fix testpmd doesn't show RSS hash offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The driver may change offloads info into dev->data->dev_conf in dev_configure which may cause port->dev_conf and port->rx_conf contain outdated values. This patch updates the offloads info if it changes to fix this issue. Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: stable@dpdk.org Signed-off-by: Jie Wang --- v3: - check and update the "offloads" of "port->dev_conf.rx/txmode". - update the commit log. v2: copy "rx/txmode.offloads", instead of copying the entire struct "dev->data->dev_conf.rx/txmode". --- app/test-pmd/testpmd.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 1cdd3cdd12..26550340e4 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2475,6 +2475,11 @@ start_port(portid_t pid) } if (port->need_reconfig > 0) { + const struct rte_eth_dev *dev = &rte_eth_devices[pi]; + struct rte_eth_conf *dev_conf; + int k; + + dev_conf = &dev->data->dev_conf; port->need_reconfig = 0; if (flow_isolate_all) { @@ -2508,6 +2513,28 @@ start_port(portid_t pid) port->need_reconfig = 1; return -1; } + /* Apply Rx offloads configuration */ + if (dev_conf->rxmode.offloads != + port->dev_conf.rxmode.offloads) { + port->dev_conf.rxmode.offloads = + dev_conf->rxmode.offloads; + for (k = 0; + k < port->dev_info.max_rx_queues; + k++) + port->rx_conf[k].offloads = + dev_conf->rxmode.offloads; + } + /* Apply Tx offloads configuration */ + if (dev_conf->txmode.offloads != + port->dev_conf.txmode.offloads) { + port->dev_conf.txmode.offloads = + dev_conf->txmode.offloads; + for (k = 0; + k < port->dev_info.max_tx_queues; + k++) + port->tx_conf[k].offloads = + dev_conf->txmode.offloads; + } } if (port->need_reconfig_queues > 0) { port->need_reconfig_queues = 0; -- 2.25.1