From: Stephen Hemminger <stephen@networkplumber.org>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: <dev@dpdk.org>, <maryam.tahhan@intel.com>, <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump
Date: Sat, 17 Jul 2021 10:51:07 -0700 [thread overview]
Message-ID: <20210717105107.3d87bd56@hermes.local> (raw)
In-Reply-To: <1619355742-15429-1-git-send-email-humin29@huawei.com>
On Sun, 25 Apr 2021 21:02:22 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:
> +
> + memset(®_info, 0, sizeof(reg_info));
> + memset(&dev_info, 0, sizeof(dev_info));
This memset is redundant, rte_eth_dev_info_get already has the same memset.
For the registers, ethdev should be fixed to do it.
> +
> + ret = rte_eth_dev_info_get(i, &dev_info);
> + if (ret) {
> + printf("Error getting device info: %d\n", ret);
> + continue;
> + }
> +
> + ret = rte_eth_dev_get_reg_info(i, ®_info);
> + if (ret) {
> + printf("Error getting device reg info: %d\n", ret);
> + continue;
> + }
next prev parent reply other threads:[~2021-07-17 17:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 13:02 Min Hu (Connor)
2021-05-19 10:16 ` Thomas Monjalon
2021-06-04 15:04 ` Pattan, Reshma
2021-06-05 3:15 ` Chengchang Tang
2021-06-10 16:25 ` Pattan, Reshma
2021-06-21 2:17 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-07-09 21:55 ` Thomas Monjalon
2021-07-17 2:16 ` Min Hu (Connor)
2021-07-17 17:51 ` Stephen Hemminger [this message]
2021-07-19 6:40 ` [dpdk-dev] [PATCH] " Chengchang Tang
2021-07-17 17:53 ` Stephen Hemminger
2021-07-19 7:00 ` Chengchang Tang
2021-07-22 10:58 ` [dpdk-dev] [PATCH v3] " Min Hu (Connor)
2021-07-29 14:14 ` Pattan, Reshma
2021-07-30 16:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210717105107.3d87bd56@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=maryam.tahhan@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).