From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7C8BA0C50; Wed, 21 Jul 2021 14:51:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DBE90410DA; Wed, 21 Jul 2021 14:51:32 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2044.outbound.protection.outlook.com [40.107.243.44]) by mails.dpdk.org (Postfix) with ESMTP id D98BD40F35; Wed, 21 Jul 2021 14:51:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kjVTRJke2cfGBoUvkBKjSF1R7Q3U9ID6DDDQynuVgYxLLcAm/MzQUC5vz+V7JjdwedMBFhWKNLYn1ithrjm5L/qAdpMXO+ZGpG2XnnlnMSXJoHQcAC7EwLn24mLKbmzPpLXarHiaNIB2U8Noe1szgULCkW0P566aqlsYJmUtyTmTXUcCPiVmCAa4exHlCZcHGbbrm4MwXnZhMS10dquJuR4M9IXnzKvFchp0+O235fWeguIpmrSqck6LnQfU+/TJtCEfg5jgYWGHXJbltd/feJkEpa5nHyDm9JS51h/i/5lFIgDncGkBSs/rQn8CBDGyRnw1T0skRJM/ukzJL0eBkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r6UYS6bNNn0I0x90NQPHbPSjpM1PePTGZTkGWyxLEuA=; b=DzOrVJlx2UxqtBg/9WdU1e0o+BEYDIhA7MwAzRIRwju31WLIqT3lyBtmZGHSU3hyn2pnD5abq+28pluOqeN/XXK1MbOWclW0E/wmfe68bxvrsbzAXMymTUGstPX3SPO+HybHNrDj0nEZaFwWdDCo2zoNxSfYyZx2nQGOJWb9NjH4QCWQWCraCBMyyqOje1Zxc7Hv74liGfx8sAzOi8lS9UnPQ6kepS76q6JHaO8bWtFDkYHjbhvVdyngsloyHC/hPuYzxY+uI353trN29d35mRGuwjHODLTFxSsNywMmY8QnHfz3wuI2ErtMePRgbsK3IqPpcjRzowhinzutu4jmcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r6UYS6bNNn0I0x90NQPHbPSjpM1PePTGZTkGWyxLEuA=; b=T+VTbJ+XsohWA7D4IvX2oMvOzZvAqjm9XimyUJ6bsOSFdi9uSiJ/E9lFBhr1XXVf9JsPOlNpE52uCdRc+kUw4u7IDt4R2exeHNpPrwYrNP/I4R0y7XNmY3Ao8EoE5+pHErUVh/BvE1gAXHdX22VEMiYXIUZUZZ82K169YoYDASX0I8vStlkOIYqNvyDeMYIvt5f5z8OHQhctXxgaryrPsvBYkLuuZqKlzagfo8+dvRZCZh11Y6n54LJN9RpiXTVCgLXBsw6h93JZkQ0TIM/epKDzo5N/U9Q7A5YP2/VqO7r3ngFAaWgjhbRhlGrTTBwwKoYPFdHTvja4weW0XNVgsQ== Received: from DM6PR11CA0015.namprd11.prod.outlook.com (2603:10b6:5:190::28) by CY4PR1201MB2550.namprd12.prod.outlook.com (2603:10b6:903:ce::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.29; Wed, 21 Jul 2021 12:51:30 +0000 Received: from DM6NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:5:190:cafe::ef) by DM6PR11CA0015.outlook.office365.com (2603:10b6:5:190::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.25 via Frontend Transport; Wed, 21 Jul 2021 12:51:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT067.mail.protection.outlook.com (10.13.172.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4352.24 via Frontend Transport; Wed, 21 Jul 2021 12:51:29 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 21 Jul 2021 12:51:27 +0000 From: Dmitry Kozlyuk To: CC: , , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko Date: Wed, 21 Jul 2021 15:51:12 +0300 Message-ID: <20210721125112.11161-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ae94ac41-b71f-40bb-fe1e-08d94c464260 X-MS-TrafficTypeDiagnostic: CY4PR1201MB2550: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2150; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q4DPaglRHfUNxVyqoi8WS6vjIAcn4oXbevtjwS9V/5YxYeG+KCImhITUiO913kpnOyNJmMPrtis11Tbs7xTCUkCgmAPaAv/gjHiKEV6mwn/dc1FGwLlvMLfb2seE9Zu5SXDJyNXfLNcBWX/2rrGHIRfV3JqgKzR85ywMXrFJGmOGrHCDIC8c0T9BChXML40Blp8iYQPhFofS7dyrbAndfXFY7tDwwswpyWcOmXC2LZl/8hV6jgLwU1y6rHkf40UCP2Yl5WCkmOvIMkNKL+DVeAySqQW59AyAxNMoPMs1YBYLCJxPp7VCb8KZVmBIbusBhQLIyF9qdDEq0PIEAtZALzO16tQCvB/6G8HQ6jLTjDflnsBMu/8ovFs2sOAsHa1EcbPj2/xVpDf9hjvw2GqG+scepAhO3xhOefD1NTx7KAb+k04zFxzdfVl+iEW1NFmczjrarGA/2rSyARyrqOlosqD1pRwL1yX6fCoPxuX0a4Ofl3ROUgz1VTdQrrilKnjOZnk1ttNYqWR8TQ9t4bN+WAiRzbhzXT72BoxcNg362TdTnxuBTttRF/w8HettK12PQczLChxDIz5gKqbC6y+pNl3JAEI/pEvEP3hOJwKz4/xnNvfgcWzNJOBEbEVARAxgNbNSC7aifwembavNZcVJaID9L1d0feakdkHvgAt6zXVA/+6XfpJfo8OrldVV/vX6JPiKDUyZAK5IPd+WkeHS1w== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(136003)(396003)(36840700001)(46966006)(186003)(356005)(70206006)(2616005)(47076005)(36860700001)(5660300002)(6666004)(2906002)(70586007)(7636003)(4744005)(55016002)(7696005)(450100002)(4326008)(336012)(82310400003)(26005)(16526019)(316002)(6916009)(36756003)(1076003)(36906005)(6286002)(8676002)(83380400001)(82740400003)(8936002)(54906003)(426003)(107886003)(478600001)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2021 12:51:29.3620 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae94ac41-b71f-40bb-fe1e-08d94c464260 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB2550 Subject: [dpdk-dev] [PATCH] net/mlx5: fix indirect action modify rollback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" mlx5_ind_table_obj_modify() first references queues from the new list, then applies the new list to HW. In case of apply failure the function dereferenced queues from the old list, while it should be the new list. Fixes: fa7ad49e96b5 ("net/mlx5: fix shared RSS action update") Cc: andreyv@nvidia.com Cc: stable@dpdk.org Signed-off-by: Dmitry Kozlyuk Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 23685d7654..06545ebf68 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -2086,7 +2086,7 @@ mlx5_ind_table_obj_modify(struct rte_eth_dev *dev, error: err = rte_errno; for (j = 0; j < i; j++) - mlx5_rxq_release(dev, ind_tbl->queues[j]); + mlx5_rxq_release(dev, queues[j]); rte_errno = err; DRV_LOG(DEBUG, "Port %u cannot setup indirection table.", dev->data->port_id); -- 2.25.1