From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 008D7A0C43; Thu, 22 Jul 2021 23:06:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FE5D4014D; Thu, 22 Jul 2021 23:06:13 +0200 (CEST) Received: from mx0a-002c1b01.pphosted.com (mx0a-002c1b01.pphosted.com [148.163.151.68]) by mails.dpdk.org (Postfix) with ESMTP id 90B0740040 for ; Thu, 22 Jul 2021 23:06:11 +0200 (CEST) Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16MKvB8r030839; Thu, 22 Jul 2021 14:06:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=proofpoint20171006; bh=JeuB/4musQ+jARVbb83tB8r1DHh21SxLAbmnfFEBS0A=; b=OTEvTHcOqjjUbV7gvx4OFu3zGGA+s3QMoNVn10P/Mi+Wr72J7gjHu2P7jJqDjUyDVgOc oUaY+2QK1eKM7BW7s2xilV+IuS898CqPR2Jei2LPzNL5p6x/MMPbplLcTHS/zCyRqQ3K iXBOF6t/nmWEs8Ya0yAJ/Ve17eDSRX3Qm7cBZ0hgelNCqNQu1cR6exu+fL0dXM5OeWJU vk+WyznqBeFnA0pa15JnBMhYW8GdMwvK7Zci0KS6EFTXOExOboPv2SgIXBlae+X7cbLl 0Xnh7/0L/bOsNoqY6kfDhFm4hl01SOmitj5UkmvUvN4OWZEd9kL1FL8gaY6SaN95bd1I aw== Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2102.outbound.protection.outlook.com [104.47.58.102]) by mx0a-002c1b01.pphosted.com with ESMTP id 39yccurjjk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jul 2021 14:06:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oUOMCS36EQcw6MpghnQSdCefEFu+aEo9AbW53fp1f5axT31amaVsrDWrjmB+oB9p9mJDmpIbEjzIiuSYCXutNlmpfy1nzAv8bRXkun2iS14SyOfr/QIjlIKoP1xs11UiMQnY+isYZjcLpmQh7zFlKD97LJ74m6REkIkqaOz40cYdJsHF1qMsqaL+DTgnZu/jZ9Huhl5HMyR/RN3WRQANUG/eBUhlBFPltZF4goYGGHE9CLK7qm0Cqhb/JPrcDXPj0/7SsWk3agqP1BJokS9rfbnnkh/XEMQUnqkaTjwAHtXx4OEFKpL3GYQ0CBBq1OJH7Esz9+TwAnHeibV1b1lbLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JeuB/4musQ+jARVbb83tB8r1DHh21SxLAbmnfFEBS0A=; b=ny0r8muBP+ewWScZE4g1tjG6hKVsrYbmKLATcN/OHxMcVXht6qdW/1b2PTPNvvOIS+5Wk+8275k+AiJfyKsNT/7dnM5wnLyXzduO0n8MLrh1yUSwJzhM76ClPIo5aZRrhJsQJkNkFKS76b2PttKtgwfx+/BeLgSEIsSEM9ZBR7P604Akt+1nuGoL57Q6/jmgWrX/VWeUk//W6bzyi1LamRzZGuohVju25BEZr/hWNP7F0CG9qFwfQjqBTRecgZS5h6URBeRVEZECF1KjrGaJJH32Ce+tMffewPyNyJLw4wxmHVCAv/OZbL/9SCG//AkUhMYfWwQ8Y9Z1phTkQI79nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none Received: from BL0PR02MB4580.namprd02.prod.outlook.com (2603:10b6:208:40::27) by BL0PR02MB4817.namprd02.prod.outlook.com (2603:10b6:208:52::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.29; Thu, 22 Jul 2021 21:06:07 +0000 Received: from BL0PR02MB4580.namprd02.prod.outlook.com ([fe80::6903:7fea:be33:66cc]) by BL0PR02MB4580.namprd02.prod.outlook.com ([fe80::6903:7fea:be33:66cc%3]) with mapi id 15.20.4331.034; Thu, 22 Jul 2021 21:06:06 +0000 From: John Levon To: David Marchand CC: dev , "Burakov, Anatoly" , Dmitry Kozlyuk , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3] eal: allow hugetlbfs sub-directories Thread-Index: AQHXc+iAb9kxSoYvIUawUxKm+ygA3qtPiMyAgAAKJYA= Date: Thu, 22 Jul 2021 21:06:06 +0000 Message-ID: <20210722210603.GA1799660@movementarian.org> References: <20210707230605.58a79a47@sovereign> <20210708105958.526656-1-john.levon@nutanix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nutanix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a30f888a-5d52-4061-f344-08d94d5485dc x-ms-traffictypediagnostic: BL0PR02MB4817: x-microsoft-antispam-prvs: x-proofpoint-crosstenant: true x-ms-oob-tlc-oobclassifiers: OLM:1388; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pTv84EyBvzBbBY9hRztTgLnyqsAhqLk9fUBJu7QHfTq7iTnSfi2Q0zZXiuMyinnUOX8w4h6PHXLLp5zYNr6+lrstTfsBNv1wH/QRAI11kFVeDWqdNl/dzsxQ4P10dR5XS1oAEazkp7avql/1cTMwAAJn7mUp5+qLeiA6X0UB1AD/i+sB/psm7CvVdBB9ofHzFhVDPN4No5UOUyLj1+NN0ToGRIV108THhOHIkyZnWpylhX5K0rduADdLASTp6aUCH4ScP3DxmQdKC6+JizFaXz22v0oQymaqeKeUmBoOhnLtlF3INU65QFgN8pSlTpEsAsy+S8AiJ6aa1zyu1TfoLTbDn06nZ10PCGUxyW1QE1oifb7Ib5Hg8mm7MPHtCU3v+EXKKu3w/UfMYKnY/w0ApC6hjCiA/OQU0BsMMTKGSy7LfDrhSASka4MuUIKwljbl6Ol4hTkDJqzQon7cFzCu7KdQS7QBV2gkmfvokd+gN3Zlp7oMzPyl/Csn8HgVd8ayQAopkSygerXrbwjGPanjXT6yDb2PzMPopUeVhAmjNjBmnhLNZSe3YwHL5L2/vxs8xHvuxtO63ScEZrOZ6MRdbIZnCfJhuxzqHUh3F9yY0MkVodGOyjroAP6iQnDaUBrp0tLLI++gWf6pYUD8XziMHPNELp8xFHCBOe7gw0bbW69AyfbIOiPpPY4YCwAeo8FmZRWSHlA+OJya4QSL3xXFvNB1FhuSj0inE/2nVe5TZhBowpa4auOwSVnfHcgO+JoxXGrAGg5Mvf7JX7mDZxNtfB1XFLbeNfdh3uu7lieYoKg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR02MB4580.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(376002)(136003)(346002)(39860400002)(396003)(4326008)(38100700002)(1076003)(186003)(316002)(5660300002)(71200400001)(9686003)(86362001)(8936002)(6916009)(2906002)(478600001)(26005)(66476007)(54906003)(83380400001)(64756008)(53546011)(91956017)(6512007)(6506007)(44832011)(6486002)(8676002)(66946007)(76116006)(66446008)(122000001)(966005)(33656002)(66556008)(36756003)(38070700004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qmiK2HdRMMu/FpfSmfz+U6IoUfCh//12ueCKA8LiIcYazqlGmtVGLlvVDsKI?= =?us-ascii?Q?p3Z3b1IZR7wIES4EezWVpm2NSQA6hrr10PyU53TazTsj5huSBxN44QK7yxsR?= =?us-ascii?Q?irpaiW6x8n1J9L9fyVskOTk4fud1VU9nBn1LpXOPXHfe9RcHdSAUdLpMaavP?= =?us-ascii?Q?N0+EY/iis+4JoEGwvAkifemABvVS435T/0uEphPYA++oTZM21rEaKiXyX+tt?= =?us-ascii?Q?9wZsfJ8F3/VnXKl+k6GmG4oC6k8aHplnNlMMMOwjMX0mlYlO8uXMIyDIifvx?= =?us-ascii?Q?AfFy5UtNRyLpc9ahm/TF2thclAY78igp92Ph0LVIp4HSyduZFbJz/N7oke8m?= =?us-ascii?Q?4f5NIXuvwaWhyHpN4+f0cZSxHgV+Er4pQwGlXzfL+T2w7ToQrJMHlg9pr414?= =?us-ascii?Q?IhLvdi3YFK/cEWZLu1QzbX90ufKKCHbc+b5isEztygfZBfnLweGk2SpCJdpW?= =?us-ascii?Q?+LxLOq8YUkmu+7Vk221I3n/yXHp79AJ0ItbaakI6Yn+vjXKwOA5K9v1EjnSI?= =?us-ascii?Q?oPCwuDSfwVdjms/EHIoqFWYdx/UsG2fIl9Nyql86CiSmiMNI4Zlv2k2oqa2V?= =?us-ascii?Q?IKi71jibKVVsJdxdZ7KGGN9ZM8IX5ByCVTrrPw4ftkZ6SFNqkbZiEf9553uk?= =?us-ascii?Q?p3safcj/+wgHWeiEq2qRYBuD3KfiHsHoYV7dqTX5UURv8ACoFD3kX+y6BtmB?= =?us-ascii?Q?Z4+gViCpxoQ9oyMqAGaLgQILrE+A6+z9AnRgLkcOOJe1a+529bdscTZMzPOF?= =?us-ascii?Q?hUdA6lKSS3ZjYIGUKbRkfeXtqW2hdNSW89AQcNuY/pYiF6dmZbTbp/qJ57L8?= =?us-ascii?Q?DASBZCeUcv7T39/kZC7tc5Stt2dFwH8EauQKHefiS5DElG5TBWFwEhbBuQtL?= =?us-ascii?Q?skO3oPfsMNwHgFPZDuLPFjhXs4VLvk8HklAQENWLbpp686UTHuvaYw50tdrY?= =?us-ascii?Q?bSszrO/etHrB+npspcpCAv2MaeDTQ0qCgXaKSjy3jO4p4b2VywfERkqLrh4x?= =?us-ascii?Q?GRSGS9VUYic5vScO7fAYzAJHbznHjZ5M7hBX9NJmgXQRCPxlS/fp3ClUcjqE?= =?us-ascii?Q?TR9DemywtK+eRqy2WQ7YSYsvvzdwJIY1oWV+Pv8Rsp60TTbkYjopsK6ar2Zr?= =?us-ascii?Q?CmxA2F694z9U4rtAMOMo4lNx6F3A6yAnhT/dDDQm4fP5oFC7f5XmMxuOuuNm?= =?us-ascii?Q?7m0wkX0KXs1yuPsf5X7fGf5I1tHeJ1BvvkJHUfVizDGxI7lvYSnv/sJlyz3v?= =?us-ascii?Q?2jeFomudVUdPbGh+BshTS1LUt+pufXjllmVB43kEkjxtTMBcqnqYkOzhYbdv?= =?us-ascii?Q?9y1odknpRFY8cYQECuwHe1r4?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <2B744C6B8E8CA94D822F3428221D1379@namprd02.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR02MB4580.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a30f888a-5d52-4061-f344-08d94d5485dc X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2021 21:06:06.6987 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +9nHRD/AKnqntvpfViyaeTKNTo9PhQOQAl2EMMZx7kDMbnZFRW7uFBz2Fh0Ru2NowW3fWvEU7lGPCeKtouwrzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB4817 X-Proofpoint-ORIG-GUID: T_fIHWsIBwWEUG-TUqxhotu3yblhaPV2 X-Proofpoint-GUID: T_fIHWsIBwWEUG-TUqxhotu3yblhaPV2 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-22_12:2021-07-22, 2021-07-22 signatures=0 X-Proofpoint-Spam-Reason: safe Subject: Re: [dpdk-dev] [PATCH v3] eal: allow hugetlbfs sub-directories X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 22, 2021 at 10:29:45PM +0200, David Marchand wrote: > On Thu, Jul 8, 2021 at 1:00 PM John Levon wrote: > > > > get_hugepage_dir() was implemented in such a way that a --huge-dir > > option had to exactly match the mountpoint, but there's no reason for > > this restriction. Fix the implementation to allow a sub-directory withi= n > > a suitable hugetlbfs mountpoint to be specified, preferring the closest > > match. > > > > Signed-off-by: John Levon >=20 > This change in EAL hugetlbfs discovery is too dangerous to be taken after= -rc1. Sure. > Could you give some usecases/examples on why this change is needed? Would you like me to expand the commit message? I had hoped it was clear en= ough, but I suppose not. Simply put, DPDK above is assuming its the only user of hugepages on the system - including clear_hugedir(). That is certainly not = the case for our use cases. > Updating the documentation https://doc.dpdk.org/guides/linux_gsg/linux_eal_parameters.html """ --huge-dir Use specified hugetlbfs directory instead of autodetected ones. """ That is, it already says "directory", not "mount". You'd like something additional saying it can be below a mount point? > and the unit test also seem necessary. You're talking about app/test/test_eal_flags.c or something else? thanks, john