* [dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter
@ 2021-07-23 8:12 Naga Harish K, S V
2021-07-23 11:27 ` Jayatheerthan, Jay
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Naga Harish K, S V @ 2021-07-23 8:12 UTC (permalink / raw)
To: jay.jayatheerthan, jerinjacobk; +Cc: dev
The event port config set by application is modified in
default configuration callback function. This patch removes
this override and use application configured event port
config value.
Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
---
lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
index db260bfb68..18c0359db7 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/eventdev/rte_event_eth_tx_adapter.c
@@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
return ret;
}
- pc->event_port_cfg = 0;
ret = rte_event_port_setup(dev_id, port_id, pc);
if (ret) {
RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
--
2.25.1
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter
2021-07-23 8:12 [dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter Naga Harish K, S V
@ 2021-07-23 11:27 ` Jayatheerthan, Jay
2021-07-23 11:36 ` Jerin Jacob
2021-07-24 14:10 ` [dpdk-dev] [PATCH v2] eventdev: fix event port setup " Naga Harish K, S V
2 siblings, 0 replies; 12+ messages in thread
From: Jayatheerthan, Jay @ 2021-07-23 11:27 UTC (permalink / raw)
To: Naga Harish K, S V, jerinjacobk; +Cc: dev
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Friday, July 23, 2021 1:42 PM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinjacobk@gmail.com
> Cc: dev@dpdk.org
> Subject: [PATCH] eventdev: remove event port config override in tx adapter
>
> The event port config set by application is modified in
> default configuration callback function. This patch removes
> this override and use application configured event port
> config value.
>
> Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> ---
> lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index db260bfb68..18c0359db7 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> return ret;
> }
>
> - pc->event_port_cfg = 0;
> ret = rte_event_port_setup(dev_id, port_id, pc);
> if (ret) {
> RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> --
> 2.25.1
Looks good to me.
Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter
2021-07-23 8:12 [dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter Naga Harish K, S V
2021-07-23 11:27 ` Jayatheerthan, Jay
@ 2021-07-23 11:36 ` Jerin Jacob
2021-07-24 14:10 ` [dpdk-dev] [PATCH v2] eventdev: fix event port setup " Naga Harish K, S V
2 siblings, 0 replies; 12+ messages in thread
From: Jerin Jacob @ 2021-07-23 11:36 UTC (permalink / raw)
To: Naga Harish K, S V; +Cc: Jayatheerthan, Jay, dpdk-dev
On Fri, Jul 23, 2021 at 1:42 PM Naga Harish K, S V
<s.v.naga.harish.k@intel.com> wrote:
>
> The event port config set by application is modified in
> default configuration callback function. This patch removes
> this override and use application configured event port
> config value.
Is this enhancement or bug fix?
If it is a bug fix, please add Fixes: and update the git subject. We
will take it in RC3.
>
> Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> ---
> lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index db260bfb68..18c0359db7 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> return ret;
> }
>
> - pc->event_port_cfg = 0;
> ret = rte_event_port_setup(dev_id, port_id, pc);
> if (ret) {
> RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread* [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter
2021-07-23 8:12 [dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter Naga Harish K, S V
2021-07-23 11:27 ` Jayatheerthan, Jay
2021-07-23 11:36 ` Jerin Jacob
@ 2021-07-24 14:10 ` Naga Harish K, S V
2021-07-28 6:44 ` Jayatheerthan, Jay
2 siblings, 1 reply; 12+ messages in thread
From: Naga Harish K, S V @ 2021-07-24 14:10 UTC (permalink / raw)
To: jay.jayatheerthan, jerinjacobk; +Cc: dev
The event port config set by application in
rte_event_eth_tx_adapter_create API is modified in
default configuration callback function. This patch removes
this hardcode to use application provided event port
config value.
Fixes: ("eventdev: fix event port config override in tx adapter")
Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
---
lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
index db260bfb68..18c0359db7 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/eventdev/rte_event_eth_tx_adapter.c
@@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
return ret;
}
- pc->event_port_cfg = 0;
ret = rte_event_port_setup(dev_id, port_id, pc);
if (ret) {
RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
--
2.25.1
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter
2021-07-24 14:10 ` [dpdk-dev] [PATCH v2] eventdev: fix event port setup " Naga Harish K, S V
@ 2021-07-28 6:44 ` Jayatheerthan, Jay
2021-07-28 9:30 ` Jerin Jacob
0 siblings, 1 reply; 12+ messages in thread
From: Jayatheerthan, Jay @ 2021-07-28 6:44 UTC (permalink / raw)
To: Naga Harish K, S V, jerinjacobk; +Cc: dev
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Saturday, July 24, 2021 7:41 PM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinjacobk@gmail.com
> Cc: dev@dpdk.org
> Subject: [PATCH v2] eventdev: fix event port setup in tx adapter
>
> The event port config set by application in
> rte_event_eth_tx_adapter_create API is modified in
> default configuration callback function. This patch removes
> this hardcode to use application provided event port
> config value.
>
> Fixes: ("eventdev: fix event port config override in tx adapter")
@Jerin, does this look good to you ?
>
> Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> ---
> lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index db260bfb68..18c0359db7 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> return ret;
> }
>
> - pc->event_port_cfg = 0;
> ret = rte_event_port_setup(dev_id, port_id, pc);
> if (ret) {
> RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> --
> 2.25.1
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter
2021-07-28 6:44 ` Jayatheerthan, Jay
@ 2021-07-28 9:30 ` Jerin Jacob
2021-07-28 10:57 ` Jayatheerthan, Jay
0 siblings, 1 reply; 12+ messages in thread
From: Jerin Jacob @ 2021-07-28 9:30 UTC (permalink / raw)
To: Jayatheerthan, Jay; +Cc: Naga Harish K, S V, dev
On Wed, Jul 28, 2021 at 12:14 PM Jayatheerthan, Jay
<jay.jayatheerthan@intel.com> wrote:
>
> > -----Original Message-----
> > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Sent: Saturday, July 24, 2021 7:41 PM
> > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinjacobk@gmail.com
> > Cc: dev@dpdk.org
> > Subject: [PATCH v2] eventdev: fix event port setup in tx adapter
> >
> > The event port config set by application in
> > rte_event_eth_tx_adapter_create API is modified in
> > default configuration callback function. This patch removes
> > this hardcode to use application provided event port
> > config value.
> >
> > Fixes: ("eventdev: fix event port config override in tx adapter")
>
> @Jerin, does this look good to you ?
Yes. I will merge this. See below.
>
> >
> > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
@Naga Harish K, S V Can we remove "," from the Signoff name.
Some suggestions for consideration in preferred order. Let me know
your preferred Signoff name, I will change it accordingly.
Naga Harish <s.v.naga.harish.k@intel.com>
or
Naga Harish K <s.v.naga.harish.k@intel.com>
or
Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > ---
> > lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> > index db260bfb68..18c0359db7 100644
> > --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> > return ret;
> > }
> >
> > - pc->event_port_cfg = 0;
> > ret = rte_event_port_setup(dev_id, port_id, pc);
> > if (ret) {
> > RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter
2021-07-28 9:30 ` Jerin Jacob
@ 2021-07-28 10:57 ` Jayatheerthan, Jay
2021-07-30 10:24 ` Jerin Jacob
2021-07-30 10:59 ` Jerin Jacob
0 siblings, 2 replies; 12+ messages in thread
From: Jayatheerthan, Jay @ 2021-07-28 10:57 UTC (permalink / raw)
To: Jerin Jacob; +Cc: Naga Harish K, S V, dev
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Wednesday, July 28, 2021 3:01 PM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
>
> On Wed, Jul 28, 2021 at 12:14 PM Jayatheerthan, Jay
> <jay.jayatheerthan@intel.com> wrote:
> >
> > > -----Original Message-----
> > > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > > Sent: Saturday, July 24, 2021 7:41 PM
> > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinjacobk@gmail.com
> > > Cc: dev@dpdk.org
> > > Subject: [PATCH v2] eventdev: fix event port setup in tx adapter
> > >
> > > The event port config set by application in
> > > rte_event_eth_tx_adapter_create API is modified in
> > > default configuration callback function. This patch removes
> > > this hardcode to use application provided event port
> > > config value.
> > >
> > > Fixes: ("eventdev: fix event port config override in tx adapter")
> >
> > @Jerin, does this look good to you ?
>
> Yes. I will merge this. See below.
Thanks!
>
> >
> > >
> > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
>
>
> @Naga Harish K, S V Can we remove "," from the Signoff name.
>
> Some suggestions for consideration in preferred order. Let me know
> your preferred Signoff name, I will change it accordingly.
>
> Naga Harish <s.v.naga.harish.k@intel.com>
>
> or
>
> Naga Harish K <s.v.naga.harish.k@intel.com>
>
> or
>
> Naga Harish K S V <s.v.naga.harish.k@intel.com>
This option is good. (Harish is out and hence I am responding)
>
> > > ---
> > > lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > index db260bfb68..18c0359db7 100644
> > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> > > return ret;
> > > }
> > >
> > > - pc->event_port_cfg = 0;
> > > ret = rte_event_port_setup(dev_id, port_id, pc);
> > > if (ret) {
> > > RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> > > --
> > > 2.25.1
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter
2021-07-28 10:57 ` Jayatheerthan, Jay
@ 2021-07-30 10:24 ` Jerin Jacob
2021-07-30 10:31 ` Thomas Monjalon
2021-07-30 10:59 ` Jerin Jacob
1 sibling, 1 reply; 12+ messages in thread
From: Jerin Jacob @ 2021-07-30 10:24 UTC (permalink / raw)
To: Jayatheerthan, Jay, Thomas Monjalon, David Marchand
Cc: Naga Harish K, S V, dev
On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
<jay.jayatheerthan@intel.com> wrote:
>
> > -----Original Message-----
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > Sent: Wednesday, July 28, 2021 3:01 PM
> > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
> >
> > >
> > > >
> > > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> >
> >
> > @Naga Harish K, S V Can we remove "," from the Signoff name.
> >
> > Some suggestions for consideration in preferred order. Let me know
> > your preferred Signoff name, I will change it accordingly.
> >
> > Naga Harish <s.v.naga.harish.k@intel.com>
> >
> > or
> >
> > Naga Harish K <s.v.naga.harish.k@intel.com>
> >
> > or
> >
> > Naga Harish K S V <s.v.naga.harish.k@intel.com>
>
> This option is good. (Harish is out and hence I am responding)
1) Option 'Signed-off-by: Naga Harish K S V
<s.v.naga.harish.k@intel.com> is warned by checkpatch
[for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1
### eventdev: fix event port setup in Tx adapter
WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name
mismatch: 'From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>'
!= 'Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>'
2) Option 'Signed-off-by: Naga Harish K, S V
<s.v.naga.harish.k@intel.com>' is warning by check-git-log.sh
[for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
Wrong tag:
Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
@thomas @David Marchand
Could you suggest what Sign-off to take?
>
> >
> > > > ---
> > > > lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > index db260bfb68..18c0359db7 100644
> > > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> > > > return ret;
> > > > }
> > > >
> > > > - pc->event_port_cfg = 0;
> > > > ret = rte_event_port_setup(dev_id, port_id, pc);
> > > > if (ret) {
> > > > RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> > > > --
> > > > 2.25.1
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter
2021-07-30 10:24 ` Jerin Jacob
@ 2021-07-30 10:31 ` Thomas Monjalon
2021-07-30 10:36 ` Jerin Jacob
0 siblings, 1 reply; 12+ messages in thread
From: Thomas Monjalon @ 2021-07-30 10:31 UTC (permalink / raw)
To: Jayatheerthan, Jay, David Marchand, Jerin Jacob; +Cc: Naga Harish K, S V, dev
30/07/2021 12:24, Jerin Jacob:
> On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
> <jay.jayatheerthan@intel.com> wrote:
> >
> > > -----Original Message-----
> > > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > Sent: Wednesday, July 28, 2021 3:01 PM
> > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
>
> > >
> > > >
> > > > >
> > > > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > >
> > >
> > > @Naga Harish K, S V Can we remove "," from the Signoff name.
> > >
> > > Some suggestions for consideration in preferred order. Let me know
> > > your preferred Signoff name, I will change it accordingly.
> > >
> > > Naga Harish <s.v.naga.harish.k@intel.com>
> > >
> > > or
> > >
> > > Naga Harish K <s.v.naga.harish.k@intel.com>
> > >
> > > or
> > >
> > > Naga Harish K S V <s.v.naga.harish.k@intel.com>
> >
> > This option is good. (Harish is out and hence I am responding)
>
> 1) Option 'Signed-off-by: Naga Harish K S V
> <s.v.naga.harish.k@intel.com> is warned by checkpatch
>
> [for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1
>
> ### eventdev: fix event port setup in Tx adapter
>
> WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name
> mismatch: 'From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>'
> != 'Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>'
>
> 2) Option 'Signed-off-by: Naga Harish K, S V
> <s.v.naga.harish.k@intel.com>' is warning by check-git-log.sh
>
> [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
> Wrong tag:
> Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
>
>
> @thomas @David Marchand
>
> Could you suggest what Sign-off to take?
The first option is probably OK but the problem is a mismatch with the author name.
Make sure to change the authorship with --amend --author=
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter
2021-07-30 10:31 ` Thomas Monjalon
@ 2021-07-30 10:36 ` Jerin Jacob
0 siblings, 0 replies; 12+ messages in thread
From: Jerin Jacob @ 2021-07-30 10:36 UTC (permalink / raw)
To: Thomas Monjalon
Cc: Jayatheerthan, Jay, David Marchand, Naga Harish K, S V, dev
On Fri, Jul 30, 2021 at 4:00 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 30/07/2021 12:24, Jerin Jacob:
> > On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
> > <jay.jayatheerthan@intel.com> wrote:
> > >
> > > > -----Original Message-----
> > > > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > > Sent: Wednesday, July 28, 2021 3:01 PM
> > > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > > > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> > > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
> >
> > > >
> > > > >
> > > > > >
> > > > > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > > >
> > > >
> > > > @Naga Harish K, S V Can we remove "," from the Signoff name.
> > > >
> > > > Some suggestions for consideration in preferred order. Let me know
> > > > your preferred Signoff name, I will change it accordingly.
> > > >
> > > > Naga Harish <s.v.naga.harish.k@intel.com>
> > > >
> > > > or
> > > >
> > > > Naga Harish K <s.v.naga.harish.k@intel.com>
> > > >
> > > > or
> > > >
> > > > Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > >
> > > This option is good. (Harish is out and hence I am responding)
> >
> > 1) Option 'Signed-off-by: Naga Harish K S V
> > <s.v.naga.harish.k@intel.com> is warned by checkpatch
> >
> > [for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1
> >
> > ### eventdev: fix event port setup in Tx adapter
> >
> > WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name
> > mismatch: 'From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>'
> > != 'Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>'
> >
> > 2) Option 'Signed-off-by: Naga Harish K, S V
> > <s.v.naga.harish.k@intel.com>' is warning by check-git-log.sh
> >
> > [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
> > Wrong tag:
> > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> >
> >
> > @thomas @David Marchand
> >
> > Could you suggest what Sign-off to take?
>
> The first option is probably OK but the problem is a mismatch with the author name.
> Make sure to change the authorship with --amend --author=
Thanks for the input.
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter
2021-07-28 10:57 ` Jayatheerthan, Jay
2021-07-30 10:24 ` Jerin Jacob
@ 2021-07-30 10:59 ` Jerin Jacob
1 sibling, 0 replies; 12+ messages in thread
From: Jerin Jacob @ 2021-07-30 10:59 UTC (permalink / raw)
To: Jayatheerthan, Jay; +Cc: Naga Harish K, S V, dev
On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
<jay.jayatheerthan@intel.com> wrote:
>
> > -----Original Message-----
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > Sent: Wednesday, July 28, 2021 3:01 PM
> > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
> >
> > On Wed, Jul 28, 2021 at 12:14 PM Jayatheerthan, Jay
> > <jay.jayatheerthan@intel.com> wrote:
> > >
> > > > -----Original Message-----
> > > > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > > > Sent: Saturday, July 24, 2021 7:41 PM
> > > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinjacobk@gmail.com
> > > > Cc: dev@dpdk.org
> > > > Subject: [PATCH v2] eventdev: fix event port setup in tx adapter
> > > >
> > > > The event port config set by application in
> > > > rte_event_eth_tx_adapter_create API is modified in
> > > > default configuration callback function. This patch removes
> > > > this hardcode to use application provided event port
> > > > config value.
> > > >
> > > > Fixes: ("eventdev: fix event port config override in tx adapter")
> > >
> > > @Jerin, does this look good to you ?
> >
> > Yes. I will merge this. See below.
Applied to dpdk-next-net-eventdev/for-main. Thanks
>
> Thanks!
>
> >
> > >
> > > >
> > > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> >
> >
> > @Naga Harish K, S V Can we remove "," from the Signoff name.
> >
> > Some suggestions for consideration in preferred order. Let me know
> > your preferred Signoff name, I will change it accordingly.
> >
> > Naga Harish <s.v.naga.harish.k@intel.com>
> >
> > or
> >
> > Naga Harish K <s.v.naga.harish.k@intel.com>
> >
> > or
> >
> > Naga Harish K S V <s.v.naga.harish.k@intel.com>
>
> This option is good. (Harish is out and hence I am responding)
>
> >
> > > > ---
> > > > lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > index db260bfb68..18c0359db7 100644
> > > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> > > > return ret;
> > > > }
> > > >
> > > > - pc->event_port_cfg = 0;
> > > > ret = rte_event_port_setup(dev_id, port_id, pc);
> > > > if (ret) {
> > > > RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> > > > --
> > > > 2.25.1
^ permalink raw reply [flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter
@ 2021-07-24 13:54 Naga Harish K, S V
0 siblings, 0 replies; 12+ messages in thread
From: Naga Harish K, S V @ 2021-07-24 13:54 UTC (permalink / raw)
To: jay.jayatheerthan, jerinjacobk; +Cc: dev
The event port config set by application in
rte_event_eth_tx_adapter_create API is modified in
default configuration callback function. This patch removes
this hardcode to use application provided event port
config value.
Fixes: ("eventdev: fix event port config override in tx adapter")
Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
---
lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
index db260bfb68..18c0359db7 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/eventdev/rte_event_eth_tx_adapter.c
@@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
return ret;
}
- pc->event_port_cfg = 0;
ret = rte_event_port_setup(dev_id, port_id, pc);
if (ret) {
RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
--
2.25.1
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-07-30 11:00 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-23 8:12 [dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter Naga Harish K, S V
2021-07-23 11:27 ` Jayatheerthan, Jay
2021-07-23 11:36 ` Jerin Jacob
2021-07-24 14:10 ` [dpdk-dev] [PATCH v2] eventdev: fix event port setup " Naga Harish K, S V
2021-07-28 6:44 ` Jayatheerthan, Jay
2021-07-28 9:30 ` Jerin Jacob
2021-07-28 10:57 ` Jayatheerthan, Jay
2021-07-30 10:24 ` Jerin Jacob
2021-07-30 10:31 ` Thomas Monjalon
2021-07-30 10:36 ` Jerin Jacob
2021-07-30 10:59 ` Jerin Jacob
2021-07-24 13:54 Naga Harish K, S V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).