From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C077DA0C4C; Sun, 25 Jul 2021 01:50:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3FB4640A4B; Sun, 25 Jul 2021 01:50:36 +0200 (CEST) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id E3A1040141 for ; Sun, 25 Jul 2021 01:50:34 +0200 (CEST) Received: by mail-pj1-f46.google.com with SMTP id g23-20020a17090a5797b02901765d605e14so8978447pji.5 for ; Sat, 24 Jul 2021 16:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lSjba7m0LvLlrhTPLg2ANYyEFARGhfrsESDAW3p1Xr0=; b=XZxBeAh4NN61MgD00vMtejfBI2PSghiJ9qO2Px8RrMLo+pbiGHnSvxk2ds0UgVH5QZ CU5Jj99l9LUpPMZU5vFPyvnciTMIrXerwUOZURbozgSn7cSohny9kUSkB1/QUkpd+YyO ooqYlKNE0Ak3kJbJhBNGfQeV8e4+FN/1qmuGHCcauNeAhFgL9GpEASOY2WoCPEN2kTx7 FC+Kv4pcOnBvTHbNneVYhxGXvJTsT2McIv4p2DK0fliA9Gd2iEzen5CkPWFw2jbme2ou nxy7u+zDMbqN0X/G0Ojjubdk62Jll4cLRHb0DARLK/RkbsG4D2EKUcqGDE+qYH+0hyNv i2ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lSjba7m0LvLlrhTPLg2ANYyEFARGhfrsESDAW3p1Xr0=; b=gVdq/M/fdkYnaKGPjDXU5rcCpPPfZ73zw4DE4JhU3qNphBYYwzQiTACQoFUK4TWwOB Pr5etsjher5qxXs+OVF1zO5O6D4aHthQnlMpLyEXGhXDyHb4pFhc7suXwPi0ISK/tuBr c6r3wf/czLhsbdkPrSbmD+CBU8eepmmAKbTss7StuWp+mx1oQCky6F5gMJfZ7Qir9AM6 zdAKDFIhVklDzOmDwk0gxl1TV9hh7MXvRmkvnwu/xEgJdp63n10v6yRF/ZzdM6QMxhRW 6QKpOSibf9p5unUctrWqzlD4cAOf3d+sq53sQtFZV/VdyPnbdebLDxlCtBsmPHYZdR+c Nsgg== X-Gm-Message-State: AOAM533SHdX6YBqreRNkwOp1763ZzU9sSrTIeEKRZNtWWiaZs1vGyYKd inpeNySMpaOV0Lj1Ax1WlnxA1A== X-Google-Smtp-Source: ABdhPJwDaAYSusR6Q6OURHZpoW5iNXWa3UsVApfr+9SK7KgiL03LQOewxiF443d//QCYj+OBsdqDVA== X-Received: by 2002:aa7:8584:0:b029:363:7359:f352 with SMTP id w4-20020aa785840000b02903637359f352mr11097791pfn.16.1627170633841; Sat, 24 Jul 2021 16:50:33 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id s5sm8761059pfk.114.2021.07.24.16.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 16:50:33 -0700 (PDT) Date: Sat, 24 Jul 2021 16:50:30 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, anatoly.burakov@intel.com, Tyler Retzlaff Message-ID: <20210724165030.38a5a383@hermes.local> In-Reply-To: <2040984.QlECWYl36d@thomas> References: <20210713201221.301248-1-stephen@networkplumber.org> <20210723154546.7958-1-stephen@networkplumber.org> <2040984.QlECWYl36d@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] eal: fix argument to rte_bsf32_safe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 24 Jul 2021 09:58:44 +0200 Thomas Monjalon wrote: > 23/07/2021 17:45, Stephen Hemminger: > > The first argument to rte_bsf32_safe was incorrectly declared as > > a 64 bit value. The code only works on 32 bit values and the underlying > > function rte_bsf32 only accepts 32 bit values. This was a mistake > > introduced when the safe version was added and probably cause > > by copy/paste from the 64 bit version. > > > > The bug passed silently under the radar until some other code was > > built with -Wall and -Wextra in C++ and C++ complains about the > > missing cast. > > > > Yes, this is a API signature change, but the original code was wrong. > > It is an inline so not an ABI change. > > > > Fixes: 4e261f551986 ("eal: add 64-bit bsf and 32-bit safe bsf functions") > > Cc: anatoly.burakov@intel.com > > Signed-off-by: Stephen Hemminger > > Acked-by: Tyler Retzlaff > > +Cc: stable@dpdk.org > > Applied, thanks. > > I think these functions lack a reference to the name Bit Scan Forward. > > > > Tyler wanted to fix a bunch more stuff in these for 21.11 where it will be a bigger API change.