From: Gaoxiang Liu <clgx0086@163.com>
To: chenbo.xia@intel.com, dev@dpdk.org, liugaoxiang@huawei.com
Cc: Gaoxiang Liu <clgx0086@163.com>
Subject: [dpdk-dev] [PATCH] net/virtio: fix memory leak of interrupt handle
Date: Mon, 26 Jul 2021 19:59:51 +0800 [thread overview]
Message-ID: <20210726115951.92-1-clgx0086@163.com> (raw)
In-Reply-To: <20210725020315.15010-1-clgx0086@163.com>
Free memory of interrupt handle in virtio_user_dev_uninit() to
avoid memory leak.
when virtio user dev closes, the "intr_handle" memory is not freed
that is allocated in virtio_user_fill_intr_handle().
Fixes: 3d4fb6fd2505 <"net/virtio-user: support Rx interrupt">
Signed-off-by: Gaoxiang Liu <clgx0086@163.com>
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index 1cd1e95f4..16c58710d 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -654,6 +654,13 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
void
virtio_user_dev_uninit(struct virtio_user_dev *dev)
{
+ struct rte_eth_dev *eth_dev = &rte_eth_devices[dev->hw.port_id];
+
+ if (eth_dev->intr_handle) {
+ free(eth_dev->intr_handle);
+ eth_dev->intr_handle = NULL;
+ }
+
virtio_user_stop_device(dev);
rte_mem_event_callback_unregister(VIRTIO_USER_MEM_EVENT_CLB_NAME, dev);
--
2.32.0
next prev parent reply other threads:[~2021-07-26 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 2:03 [dpdk-dev] [PATCH] net/virtio: fix memory leak in dev close Gaoxiang Liu
2021-07-26 8:42 ` Xia, Chenbo
2021-07-26 11:38 ` 刘高翔
2021-07-26 11:59 ` Gaoxiang Liu [this message]
2021-07-26 12:54 ` [dpdk-dev] [PATCH] net/virtio: fix memory leak of interrupt handle Maxime Coquelin
2021-07-26 14:42 ` Gaoxiang Liu
2021-07-27 1:52 ` Xia, Chenbo
2021-07-27 1:54 ` Xia, Chenbo
2021-07-28 6:51 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726115951.92-1-clgx0086@163.com \
--to=clgx0086@163.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=liugaoxiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).