From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: dev@dpdk.org
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
stable@dpdk.org,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: [dpdk-dev] [PATCH] eal/windows: cleanup virt2phys handle
Date: Tue, 27 Jul 2021 00:36:32 +0300 [thread overview]
Message-ID: <20210726213632.143296-1-dmitry.kozliuk@gmail.com> (raw)
eal_mem_virt2phys_init() opens a handle for use by rte_mem_virt2phy().
Close this handle on EAL cleanup.
Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
Cc: stable@dpdk.org
Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
lib/eal/windows/eal.c | 1 +
lib/eal/windows/eal_memory.c | 7 +++++++
lib/eal/windows/eal_windows.h | 5 +++++
3 files changed, 13 insertions(+)
diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c
index 5413d4d87f..3d8c520412 100644
--- a/lib/eal/windows/eal.c
+++ b/lib/eal/windows/eal.c
@@ -261,6 +261,7 @@ rte_eal_cleanup(void)
eal_get_internal_configuration();
eal_intr_thread_cancel();
+ eal_mem_virt2iova_cleanup();
/* after this point, any DPDK pointers will become dangling */
rte_eal_memory_detach();
eal_cleanup_config(internal_conf);
diff --git a/lib/eal/windows/eal_memory.c b/lib/eal/windows/eal_memory.c
index 4db048ccb5..71741fc07e 100644
--- a/lib/eal/windows/eal_memory.c
+++ b/lib/eal/windows/eal_memory.c
@@ -198,6 +198,13 @@ eal_mem_virt2iova_init(void)
return ret;
}
+void
+eal_mem_virt2iova_cleanup(void)
+{
+ if (virt2phys_device != INVALID_HANDLE_VALUE)
+ CloseHandle(virt2phys_device);
+}
+
phys_addr_t
rte_mem_virt2phy(const void *virt)
{
diff --git a/lib/eal/windows/eal_windows.h b/lib/eal/windows/eal_windows.h
index 7cc811485d..23ead6d30c 100644
--- a/lib/eal/windows/eal_windows.h
+++ b/lib/eal/windows/eal_windows.h
@@ -79,6 +79,11 @@ void eal_intr_thread_cancel(void);
*/
int eal_mem_virt2iova_init(void);
+/**
+ * Cleanup resources used for virtual to physical address translation.
+ */
+void eal_mem_virt2iova_cleanup(void);
+
/**
* Locate Win32 memory management routines in system libraries.
*
--
2.29.3
next reply other threads:[~2021-07-26 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 21:36 Dmitry Kozlyuk [this message]
2021-07-27 5:43 ` Menon, Ranjit
2021-07-30 16:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726213632.143296-1-dmitry.kozliuk@gmail.com \
--to=dmitry.kozliuk@gmail.com \
--cc=dev@dpdk.org \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).