From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
To: dev@dpdk.org
Cc: gakhil@marvell.com, fiona.trahe@intel.com,
roy.fan.zhang@intel.com,
Arek Kusztal <arkadiuszx.kusztal@intel.com>
Subject: [dpdk-dev] [PATCH 1/2] drivers/qat: fix wrong return value for invalid service
Date: Wed, 28 Jul 2021 17:18:30 +0100 [thread overview]
Message-ID: <20210728161831.6807-2-arkadiuszx.kusztal@intel.com> (raw)
In-Reply-To: <20210728161831.6807-1-arkadiuszx.kusztal@intel.com>
Fix invalid value that is returned when asymmetric crypto
or compression service is selected.
Fixes: 8f393c4ffdc1 ("common/qat: support GEN4 devices")
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
drivers/compress/qat/qat_comp_pmd.c | 2 +-
drivers/crypto/qat/qat_asym_pmd.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c
index cfdcb6b3d1..92a2285b53 100644
--- a/drivers/compress/qat/qat_comp_pmd.c
+++ b/drivers/compress/qat/qat_comp_pmd.c
@@ -713,7 +713,7 @@ qat_comp_dev_create(struct qat_pci_device *qat_pci_dev,
if (qat_pci_dev->qat_dev_gen == QAT_GEN4) {
QAT_LOG(ERR, "Compression PMD not supported on QAT 4xxx");
- return 0;
+ return -(EFAULT);
}
snprintf(name, RTE_COMPRESSDEV_NAME_MAX_LEN, "%s_%s",
qat_pci_dev->name, "comp");
diff --git a/drivers/crypto/qat/qat_asym_pmd.c b/drivers/crypto/qat/qat_asym_pmd.c
index 56ccca36d1..d4680c3847 100644
--- a/drivers/crypto/qat/qat_asym_pmd.c
+++ b/drivers/crypto/qat/qat_asym_pmd.c
@@ -253,7 +253,7 @@ qat_asym_dev_create(struct qat_pci_device *qat_pci_dev,
if (qat_pci_dev->qat_dev_gen == QAT_GEN4) {
QAT_LOG(ERR, "Asymmetric crypto PMD not supported on QAT 4xxx");
- return 0;
+ return -(EFAULT);
}
snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s",
qat_pci_dev->name, "asym");
--
2.30.2
next prev parent reply other threads:[~2021-07-28 16:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 16:18 [dpdk-dev] [PATCH 0/2] drivers/qat: fix handling of unsupported services Arek Kusztal
2021-07-28 16:18 ` Arek Kusztal [this message]
2021-07-29 8:58 ` [dpdk-dev] [PATCH 1/2] drivers/qat: fix wrong return value for invalid service Zhang, Roy Fan
2021-07-30 19:18 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-31 9:29 ` Thomas Monjalon
2021-07-28 16:18 ` [dpdk-dev] [PATCH 2/2] crypto/qat: fix asymmetric crypto pmd create on gen3 Arek Kusztal
2021-07-29 8:57 ` Zhang, Roy Fan
2021-07-30 19:19 ` [dpdk-dev] [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728161831.6807-2-arkadiuszx.kusztal@intel.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=gakhil@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).